Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   SeongJae Park <sj@kernel.org>
To:     Rongwei Wang <rongwei.wang@linux.alibaba.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org, sj@kernel.org,
        akpm@linux-foundation.org
Subject: Re: [PATCH] mm/damon/dbgfs: remove unnecessary variables
Date:   Wed, 13 Oct 2021 15:04:13 +0000
Message-Id: <20211013150413.23027-1-sj@kernel.org>
In-Reply-To: <20211013130901.1017-1-rongwei.wang@linux.alibaba.com>
Precedence: bulk

Hi Rongwei,


Thank you for this patch!  Looks good to me overall.  I left a couple of
nitpicks below, though.

On Wed, 13 Oct 2021 21:09:01 +0800 Rongwei Wang <rongwei.wang@linux.alibaba.com> wrote:

[...]
> @@ -352,7 +350,7 @@ static ssize_t dbgfs_target_ids_write(struct file *file,
>  
>  	nrs = kbuf;
>  
> -	targets = str_to_target_ids(nrs, ret, &nr_targets);
> +	targets = str_to_target_ids(nrs, count, &nr_targets);
>  	if (!targets) {
>  		ret = -ENOMEM;
>  		goto out;
> @@ -378,12 +376,12 @@ static ssize_t dbgfs_target_ids_write(struct file *file,
>  		goto unlock_out;
>  	}
>  
> -	err = damon_set_targets(ctx, targets, nr_targets);
> -	if (err) {
> +	ret = damon_set_targets(ctx, targets, nr_targets);
> +	if (ret < 0) {

I'd prefer 'if (ret) {', to be consistent with other part.

>  		if (targetid_is_pid(ctx))
>  			dbgfs_put_pids(targets, nr_targets);
> -		ret = err;
> -	}
> +	} else
> +		ret = count;

I'd prefer this to have braces:
https://docs.kernel.org/process/coding-style.html#placing-braces-and-spaces

>  
>  unlock_out:
>  	mutex_unlock(&ctx->kdamond_lock);
> @@ -548,8 +546,7 @@ static ssize_t dbgfs_mk_context_write(struct file *file,
[...]


Thanks,
SJ