Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-1345-g8441cd7852-fm-20211006.001-g8441cd78
Mime-Version: 1.0
Message-Id: <98e38690-6be2-4839-99a4-148b61cc9749@www.fastmail.com>
In-Reply-To: <20211013163023.GD8557@1wt.eu>
References: <YWXwQ2P0M0uzHo0o@zn.tnic>
 <20211012222311.578581-1-ammar.faizi@students.amikom.ac.id>
 <YWbUbSUVLy/tx7Zu@zn.tnic> <20211013125142.GD5485@1wt.eu>
 <YWbZz7gHBV18QJC3@zn.tnic> <20211013140723.GE5485@1wt.eu>
 <YWbrR1BqI1CxneN/@zn.tnic> <20211013142433.GB8557@1wt.eu>
 <alpine.LSU.2.20.2110131601000.26294@wotan.suse.de>
 <20211013163023.GD8557@1wt.eu>
Date:   Wed, 13 Oct 2021 09:51:04 -0700
From:   "Andy Lutomirski" <luto@kernel.org>
To:     "Willy Tarreau" <w@1wt.eu>, "Michael Matz" <matz@suse.de>
Cc:     "Borislav Petkov" <bp@alien8.de>,
        "Ammar Faizi" <ammar.faizi@students.amikom.ac.id>,
        "Paul Walmsley" <paul.walmsley@sifive.com>,
        "Palmer Dabbelt" <palmer@dabbelt.com>,
        "Albert Ou" <aou@eecs.berkeley.edu>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@redhat.com>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] tools/nolibc: x86: Remove `r8`, `r9` and `r10` from the clobber
 list
Content-Type: text/plain
Precedence: bulk


On Wed, Oct 13, 2021, at 9:30 AM, Willy Tarreau wrote:
> Hello Michael,
>
> On Wed, Oct 13, 2021 at 04:24:28PM +0000, Michael Matz wrote:
> (...)
>> In short:  Ammars initial claim:
>> 
>> > Linux x86-64 syscall only clobbers rax, rcx and r11 (and "memory").
>> > 
>> >   - rax for the return value.
>> >   - rcx to save the return address.
>> >   - r11 to save the rflags.
>> > 
>> > Other registers are preserved.
>> 
>> is accurate and I will clarify the psABI to make that explicit.
>
> Many thanks for this very detailed explanation! Ammar, I'll take your
> patch.

Acked-by: Andy Lutomirski <luto@kernel.org>

>
> Thanks all,
> Willy