Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211008030529.223682-1-andrealmeid@collabora.com>
 <20211008030529.223682-2-andrealmeid@collabora.com> <20211013113359.redeyos4bc4p5pen@earth.universe>
In-Reply-To: <20211013113359.redeyos4bc4p5pen@earth.universe>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Wed, 13 Oct 2021 19:54:52 +0200
Message-ID: <CAJZ5v0h0BonJCrOm7PnK66JpnbLgsBTmL-RefGPhi=6mZC--gQ@mail.gmail.com>
Subject: Re: [PATCH 1/1] acpi: battery: Accept charges over the design
 capacity as full
To:     Sebastian Reichel <sebastian.reichel@collabora.com>,
        =?UTF-8?Q?Andr=C3=A9_Almeida?= <andrealmeid@collabora.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Collabora Kernel ML <kernel@collabora.com>,
        krisman@collabora.com,
        "Pierre-Loup A . Griffais" <pgriffais@valvesoftware.com>,
        Hans de Goede <hdegoede@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Oct 13, 2021 at 1:34 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> Hi,
>
> On Fri, Oct 08, 2021 at 12:05:29AM -0300, André Almeida wrote:
> > Some buggy firmware and/or brand new batteries can support a charge that's
> > slightly over the reported design capacity. In such cases, the kernel will
> > report to userspace that the charging state of the battery is "Unknown",
> > when in reality the battery charge is "Full", at least from the design
> > capacity point of view. Make the fallback condition accepts capacities
> > over the designed capacity so userspace knows that is full.
> >
> > Signed-off-by: André Almeida <andrealmeid@collabora.com>
> > ---
> >  drivers/acpi/battery.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> > index dae91f906cea..8afa85d6eb6a 100644
> > --- a/drivers/acpi/battery.c
> > +++ b/drivers/acpi/battery.c
> > @@ -169,7 +169,7 @@ static int acpi_battery_is_charged(struct acpi_battery *battery)
> >               return 1;
> >
> >       /* fallback to using design values for broken batteries */
> > -     if (battery->design_capacity == battery->capacity_now)
> > +     if (battery->design_capacity <= battery->capacity_now)
> >               return 1;
> >
> >       /* we don't do any sort of metric based on percentages */
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Applied as 5.16 material, thanks!