Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211011172236.11223-1-mkoutny@suse.com> <CAFpoUr1KrXKdiCp-DVQLnu-c2YS91AszZB6RdZNVLBm9sGjMEw@mail.gmail.com>
 <YWXUuXsA+1nNjZYN@geo.homenetwork>
In-Reply-To: <YWXUuXsA+1nNjZYN@geo.homenetwork>
From:   Odin Ugedal <odin@uged.al>
Date:   Wed, 13 Oct 2021 19:52:34 +0100
Message-ID: <CAFpoUr1AO_qStNOYrFWGnFfc=uSFrXSYD8A5cQ8h0t2pioQzDA@mail.gmail.com>
Subject: Re: [PATCH] sched/fair: Use rq->lock when checking cfs_rq list presence
To:     Tao Zhou <tao.zhou@linux.dev>
Cc:     Odin Ugedal <odin@uged.al>,
        =?UTF-8?Q?Michal_Koutn=C3=BD?= <mkoutny@suse.com>,
        open list <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

tir. 12. okt. 2021 kl. 19:31 skrev Tao Zhou <tao.zhou@linux.dev>:
>
> Er.. this is considered specific to this fix I think. Normal unthrottle(not
> race with delete, avg maybe used in after) also need the normal avg decay.

Yeah, it was more meant as a way to express my idea, should probably have
said that more explicitly. It would essentially be a revert of a7b359fc6a37
("sched/fair: Correctly insert cfs_rq's to list on unthrottle"),
while "temporary" fixing the problem it fixed, by removing the load from the tg.

But yeah, it would still need to decay the load properly to _actually_ be fully
correct and work as it does today. But in most cases nr_running>0 on unthrottle,
but yeah, it is definitely not always the case.

Thanks
Odin