Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3740417pxb; Wed, 13 Oct 2021 11:58:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8ciogYbgdeTqz92fXdpjnaJLlUyPwfJxg3K+/hgWUFbkJ1j/IOPdAaq2QPcL77HN2UNMU X-Received: by 2002:a05:6402:4250:: with SMTP id g16mr1700236edb.26.1634151508236; Wed, 13 Oct 2021 11:58:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634151508; cv=none; d=google.com; s=arc-20160816; b=toF5Lqc3zDgrKC+5J6wkpERs+0bkefIbNKSBl1AiK0/nE7Xliy+/Jb4ylZu9yKGvB/ GoALVtixW4Ld9Hhze1jJCv3Auvpizfnj0iYqoxluTrDE+n1e/PMuUDIG1Xevxw4JMNe2 yU4Cyorr57xkOnqcgTMrgiO+hn08xd06VhRH/aXq6lWREpsiV5JpH0hMMS736ATG7AyH b5nOv8+QOspJB7gfA751RVClFiM1aijPPd4p/f42snvXT57eiXsVxoU9tg2Sgxkm0sAi Fz0CVCve02UgUJa5IxCcJPXK/X0htDg9Qb3eT6g3T/vwg3pFvQ3LMNuAvIBxR9qS/hYP aB8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CeDioKlYWP/Ln2/sv3Boh4vbm3yoXHdApCIilZ4yhGw=; b=jzbyESTUPyRPK6uMW4qB+cDdJj5qgqmM1BSLt7qqgecMhb6f3UVtCqLWVILAGKE93e wE4mT9yQKOmTSXggGE7EDAMEa9TqpABC5KUKJfWRZFuYQJOzbXLLlEk6A3ve7WG76Ecx P0xCxJVRpOeovq9jr732dVWR14mL2x+B6guuLdKGDm9GiHdxIn5ZGmgoVN37LeeiKA0w Zu2hk+ERyndxCihBVOm/s7hWugpwYAy/3R+hpDX2MhfwG0DMkvL5yygSk3QRTFaqzhRx C73OBE58e+eMnnjh1eLilJFEEGVr/WphM6bIgPXGxxAZCo7UfCAYr6b/qfXscXf6NYC6 6uig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=adSofeNp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb8si533994ejc.355.2021.10.13.11.58.01; Wed, 13 Oct 2021 11:58:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=adSofeNp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229814AbhJMS5w (ORCPT + 99 others); Wed, 13 Oct 2021 14:57:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231246AbhJMS5u (ORCPT ); Wed, 13 Oct 2021 14:57:50 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69725C061746 for ; Wed, 13 Oct 2021 11:55:47 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id w14so2474583pll.2 for ; Wed, 13 Oct 2021 11:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CeDioKlYWP/Ln2/sv3Boh4vbm3yoXHdApCIilZ4yhGw=; b=adSofeNpkzFQ7ekSQ+w/o5WGdQNGCajwgRa++HMYHPPE9dE7+IC42Fj/GAeu8fYZ2r T/XBrlk0nCBGvuFRp8tBJuAGrzUUCHkF6HcKiI/zzyA7Z6Ea0LF0Z2ezCoSZ8jcy8UHd LFxEWL7AMGZDGCcK2aRmNHSiq6g3Eol3eDjVI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CeDioKlYWP/Ln2/sv3Boh4vbm3yoXHdApCIilZ4yhGw=; b=drfQEyf3g1o+QfrcS1Cx/r7I5eOotX9jMfqGSyjKq1l879wJkDGw5HGLcA9JVEJRTm QrMcA2hgAVlvMh5JE1ET7VUdRYhKiGgRJYfnA6a84hquGdGjNWKAF2rDz2ZC5kOmalOO +qNLcarMZx7KfiA6e6DK9U4Cy1eI1EP6pXRpFEMNax4kQSxwUFwgK2p22nkfWXHtn1bz Kae3QA64g/WQMbgl04HmI98CS2ZRAo6ZGeYLt8h7gHBiq1IQG/ZIDGhPRa06nPrF2zOZ duXRXwQZwPefS9SgPK2xPS0/6NtO2lygch9utuYm5Lk9lrPsjoqS8nbTqLSnC0mIlV3v +AYQ== X-Gm-Message-State: AOAM530iYbEMip9EVRx8FfJ/YSRObr01BknjWYjuuH1OHwTFnxGNXvNx 1Z9vqmWdPDRui2rQIBSK95PLTg== X-Received: by 2002:a17:90a:bd04:: with SMTP id y4mr1109096pjr.9.1634151346914; Wed, 13 Oct 2021 11:55:46 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j6sm225896pfb.175.2021.10.13.11.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 11:55:46 -0700 (PDT) Date: Wed, 13 Oct 2021 11:55:45 -0700 From: Kees Cook To: Sami Tolvanen Cc: x86@kernel.org, Josh Poimboeuf , Peter Zijlstra , Nathan Chancellor , Nick Desaulniers , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v5 12/15] x86, module: Ignore __typeid__ relocations Message-ID: <202110131155.3A730AB3@keescook> References: <20211013181658.1020262-1-samitolvanen@google.com> <20211013181658.1020262-13-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013181658.1020262-13-samitolvanen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 13, 2021 at 11:16:55AM -0700, Sami Tolvanen wrote: > The R_X86_64_8 __typeid__* relocations are for constants the compiler > generates for indirect call type checking with CONFIG_CFI_CLANG. Ignore > them when loading modules. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook