Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 13 Oct 2021 16:45:00 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Logan Gunthorpe <logang@deltatee.com>
Cc:     linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        Doug Ledford <dledford@redhat.com>,
        Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH] RDMA/core: Set sgtable nents when using
 ib_dma_virt_map_sg()
Message-ID: <20211013194500.GA3494942@nvidia.com>
References: <20211013165942.89806-1-logang@deltatee.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211013165942.89806-1-logang@deltatee.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hlj+KruDWjcqHGQ0d6PMkimzIoVmVBAz6n9/AanqzcUqXeD06b0p235mJ/0z?=
 =?us-ascii?Q?KyMbg0pFRrGaxCLUWu9E7VUh+gsoOHfJ77FxxV6tKc/0ncQRxfLTPTQCWHM5?=
 =?us-ascii?Q?rXxmcJXJPM64+X6BCmhQZDc3ArJNqzp2knt+TT4pGI2V/rK+Fhfr/6AOsOEo?=
 =?us-ascii?Q?XuF562MtUB5O7ZTcMK5kkH8vDHh0nbf3x4fRvRpHUqQ8aJfe851rllSY4nPG?=
 =?us-ascii?Q?jldzMU7UGXKbMCcD7LhA8FRHizznmjBxxcQjfWHMcFo1/8rQ6IWLVhVvr5O3?=
 =?us-ascii?Q?lC8fPlNziIuii1Sp5yiKQkBW05oD5TNU9D8pQMMwrxgpndtCyHClmrs8TZSm?=
 =?us-ascii?Q?/+uIl0wGSG9HKIoxOJK+PQWdEu5vPOcfJb1vDDYSQyr6O5R4y17WY3qxqD1x?=
 =?us-ascii?Q?SI3Ly1CcuokV43vvyc+5tyQeuzRtM1PiwIQ2TkP6P3gGRAI7n7aTi5K0jntK?=
 =?us-ascii?Q?i2tQ2BqwAitTWXxM8aFjgXPqgtjcjhjqKVjju+xVRZinN7pWwELz6orAkavL?=
 =?us-ascii?Q?dk+A2iQhIOWnxHKs5yHQdABJx0PuFJXP1AYNtCfxD+P68nTDkHAbXYd3+6ms?=
 =?us-ascii?Q?VevNMhDgJdgxiNj0yCaJMMfGjTuCJU7EbTg73NXSdWpppT8cEeqcUk0QEffa?=
 =?us-ascii?Q?Ai4rnVbeTsnZPjqPX/59Lbgyx9R0Qa9Gn6WFb8ApFLY4HtgFovHBpSmahCvo?=
 =?us-ascii?Q?lT+xRjd1SSvKZ4vpNuZjOops0PjVbvDC9+3wbyoc/DJZh3IQBQfTgR9B5Ag5?=
 =?us-ascii?Q?8LbJA/nK3EtJC4hFuI8PpM61C7JivzcZHOwIuN3s/f/574WgYya4EgzDjDWT?=
 =?us-ascii?Q?ghqzGAzXoYvqTYBoqPKipao7RxTVI0HU2f+aFqu7SMj8LtssxkF3BLc9uWjX?=
 =?us-ascii?Q?l2KGYPDXXS3PHWwI0w8Urwkt6X6PflVytfOC1bYyfZFYRUtu7CfzaI3h/Ip7?=
 =?us-ascii?Q?8i0TqbdakE++ulaZhP8yaCRJ8hFBEhKu7TWQIMacbo5pAWymO4W9JkzPWNOL?=
 =?us-ascii?Q?tZD/FTuKEOaHuuw/wPL1VKxngipmX00YIswCD/3yr1I4KnNThlHL/D3KcHcz?=
 =?us-ascii?Q?+6GWn/WD4owbTPte5LoygvuuTR4FZXGEcw5BA2tG5Qz827cK4E4wU4xcUf7T?=
 =?us-ascii?Q?nj3ZeNZc+GSPlMvtLvZmuKaweon+9cHe07I/ks8apQE72wH3cT/7pZe3I6p4?=
 =?us-ascii?Q?HQ/ssnSZVQyJnMayUQYWjsMMZ03qCZFgBzBKQzsApo5N08hfZ0fH5UbZ9G0b?=
 =?us-ascii?Q?S2LLTT79XzL58JsSeUYPtY+pALts5/Jt0Stn1P5ZmGSGgj51qTiJFZK31tqf?=
 =?us-ascii?Q?ZQ4HvufwspbuGiINZjWMxuon8FMcK+ebxW5/tzr1f4B3+g=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a58de165-59fc-4c6b-65c8-08d98e81f1d9
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 19:45:01.1696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kUTAYwnUm5xVBgoHlxRybsGPIEcgU6TM32rhNznhRXCaKEiHzN3YE8NEgRs6zEPh
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5254
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 13, 2021 at 10:59:42AM -0600, Logan Gunthorpe wrote:
> ib_dma_map_sgtable_attrs() should be mapping the sgls and setting nents
> but the ib_uses_virt_dma() path falls back to ib_dma_virt_map_sg()
> which will not set the nents in the sgtable.
> 
> Check the return value (per the map_sg calling convention) and set
> sgt->nents appropriately on success.
> 
> Link: https://lore.kernel.org/all/996fa723-18ef-d35b-c565-c9cb9dc2d5e1@acm.org/T/#u
> Reported-by: Bart Van Assche <bvanassche@acm.org>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Tested-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  include/rdma/ib_verbs.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Applied to for-next, thanks

Jason