Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3814761pxb; Wed, 13 Oct 2021 13:36:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIq09f8bl97Zg5cH75h28jBxWM6zLMs9GVQ2SBxPOJQer4beenjJyGpwnxUa7zsiqTB3IV X-Received: by 2002:a05:6402:1157:: with SMTP id g23mr2385116edw.379.1634157369068; Wed, 13 Oct 2021 13:36:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634157369; cv=none; d=google.com; s=arc-20160816; b=I4fSUe/yXFmAMf8Aps0hhdWsLpNhCpye8l3V3DVqT/LzA86i8yIoPKa8+Ukzbb799D n8aTfamfU4BuqINB1TILriTEuMr3JoePcUiUos2GQ2UvHmO7g8LETmJYbZqHvjegmXrv f8u5h1RI+ElcMGkHRfwVWvSjmbPt/JW/RrDp4WNuNo9AZSxky9II9P9XCspEnH0IYfUT nTgeAq65eM+kJQF/bhh3BfFbJZo4kmXvcFdamuLfzqbVVd+UdlTcs7VPIY005/rFoY+Q lj0MXb0tLJUTAMaaevNwErZ7qg2iVyvTHxh0RdGEEpSUgc+7outevJrGti5StsD6M+bE 1XUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=NO1jrBLqgcJAx20Ug3IH6sMC5ZTWwkGxnrZHq0DR5uA=; b=0b+rHYRW8758Maa4gQu0EwgCgRl8GRxvypu0OFKbSTJ+GxJvm+bn/+r3A36oJEo/gx ptZ5Hlg15h3lwofM39kn4key6QGdFXgFy4SJ94dfnALbkpZ5SZvdw1cBoNOR0ephEU1u vP80+PzvXAU9DMS7yvPj10VELO2s7c4SrEDJwpV6tcDNn/HmnQhN7Y3kEUeiN0KvTNhU iXimh97Mb5ahVMZMiTR2Zau5Jcc0jJ4t0vvdwiTeatz8ZEX8IY195+uHDbMDNH2RLJIS UdZQTEtINgx/K3mfaJpQwyCi5h38+z721lo7fdNu9pZBkKHvFSNb145walBBrhDPFxCM aaUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SourJ8Tl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g5si869553ejo.390.2021.10.13.13.35.42; Wed, 13 Oct 2021 13:36:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SourJ8Tl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229770AbhJMUfg (ORCPT + 99 others); Wed, 13 Oct 2021 16:35:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:53174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbhJMUfg (ORCPT ); Wed, 13 Oct 2021 16:35:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1EF13610CE; Wed, 13 Oct 2021 20:33:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634157212; bh=JUi6Yrt6b3RrzaP0GICRbOBRuJGs4INzI/hs1Pv1ynA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SourJ8TlnOofBWndt0Z4Ov7zJeXmPKK9QVPLhT0bssGWje0ZQeexHPnzQKnfRe20G Et06r+zv79HlJn9pahoeu0mQQEvzBCOsMq6wSt/RAOyiBdj9t5eFqZGbOKPVsPlNrh Uena4duOKbT1zt4511C45BmlHC4cg3Tf/isiq7COiQNWqOCd1lmjAGuuNpApID921j RUdLd+8PJ9TW9pIkAW0iXym+eC69E6Dyfd63gjEtJxMyc22yCQBIVCacnXIvo29FkV tIDTmp5ZaUm44LQU+4uIfISb1y9wyrJ3LGIh5DggEmob0XAxjra7jfsa7SLAAsarOl Md98WOalFav3w== Date: Wed, 13 Oct 2021 13:33:31 -0700 From: Jakub Kicinski To: Kyungrok Chung Cc: Roopa Prabhu , Nikolay Aleksandrov , "David S. Miller" , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH net-next] net: bridge: make use of helper netif_is_bridge_master() Message-ID: <20211013133331.0b846cd5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20211012141810.30661-1-acadx0@gmail.com> References: <20211012141810.30661-1-acadx0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Oct 2021 23:18:09 +0900 Kyungrok Chung wrote: > Make use of netdev helper functions to improve code readability. > Replace 'dev->priv_flags & IFF_EBRIDGE' with netif_is_bridge_master(dev). > > Signed-off-by: Kyungrok Chung Why leave these out? net/batman-adv/multicast.c: } while (upper && !(upper->priv_flags & IFF_EBRIDGE)); net/core/rtnetlink.c: !(dev->priv_flags & IFF_EBRIDGE))