Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 13 Oct 2021 15:03:43 -0700
From:   Roman Gushchin <guro@fb.com>
To:     Shakeel Butt <shakeelb@google.com>
CC:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Mel Gorman <mgorman@techsingularity.net>,
        Uladzislau Rezki <urezki@gmail.com>,
        Vasily Averin <vvs@virtuozzo.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        <cgroups@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT
Message-ID: <YWdXv+RBjXvdmsK+@carbon.DHCP.thefacebook.com>
References: <20211013194338.1804247-1-shakeelb@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211013194338.1804247-1-shakeelb@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SDknYSziR/oSpiHB1UyDxYAy/ngCTT9g80m2KuDkqd+ZCo8kOINNK8dB+d5M?=
 =?us-ascii?Q?CB6q4uMLkZT/wbJVmh48i8K79gUu/s9KtwdUk6lxmxDTR32T2RQMgjgt85+u?=
 =?us-ascii?Q?B8fJQNRs1E5O2EMEgrFWHEKf3QiFCyp/6/CTxspM1iezJWVNw5rEyzZ6jrp0?=
 =?us-ascii?Q?6iLOvbFCwRtGhKe3hekVRhnyIp/K7c64LCUZH/Vvwjz24YNoXP2BEPclDgPL?=
 =?us-ascii?Q?sV651p/o1k0EbMY6Yk1b1+H/jf49f0hY0oDbXglhva8ilsWg3KN7GcoE0HMo?=
 =?us-ascii?Q?78U1wm160UxPwcj6AHg+KgKQPkrX3OWLo1IHse+ZkrprJQS5EyP1SweDp/Ud?=
 =?us-ascii?Q?17yeYPfS9YYFHAAlBeAFqxeMi9XBV4trihTcK5wJmSnyqNAR+Acq6jVcPnfx?=
 =?us-ascii?Q?/g1ePrV6Lixk8qCLL5LPuInSq0w0nAehPmWeM6IYxpzqXOQS36bQ52srh7W+?=
 =?us-ascii?Q?El8bkY0JvK+h3uMmZNa1/HhG8QAU/WpBRl3hZQJL98PcsszrHH+aCyBQkR4z?=
 =?us-ascii?Q?iQ6ii90mvb5alIqsSKgvFXXBUCwW6IBw0RMcDL02XAK0OJPdJA+jn+KgGca0?=
 =?us-ascii?Q?wOpvMDVjXxLc5z0MSnU+y7mVmXgGKgaiHvJR/uXXjNFCCd0Z6e81y1nFygpA?=
 =?us-ascii?Q?DjUi7KFEcLcpjAq5u+6scvh8ACNYfuGmqjYOTnF+ElSCD+w+nVoH4IyRv9kr?=
 =?us-ascii?Q?gFbSz8yg2S5LxJAQy2pOZRVnr0ajd9P9jVmccd2og/7lGJIlhUjG2qSEbF86?=
 =?us-ascii?Q?g+mW2bg/s6B4I07PiQDKYWGV/H8GtP47W0y/fv+RyTox+o8jyl+8qFXFgcGa?=
 =?us-ascii?Q?V3V4Q0rIQGn0w1RlQnxsdg42JK81z0wV7eOWjcP7sMQpYWe/6YnNteSW4P9h?=
 =?us-ascii?Q?5ILfWHtL96fkZ2FQODRvM1/WSzgkkzk8Mjri/+tJfpMlWEhI0HmvV8ER3Mvw?=
 =?us-ascii?Q?w7oqAm7zr+V3w6725sRMeJvO9dZ3NOR1mEbHyWUOLfNp0o1b+hQcMTxbECgj?=
 =?us-ascii?Q?oaGN+AlVenzwbAuOykCJS9L66IUlmPq3lXkcTxQljh5l2CTfDhCG4w7cnMjK?=
 =?us-ascii?Q?yPWElc3cuR7dO6daOl2SaAYoLlP+p/x9kUA8XIRegkEmuRG833cqjEe1+dJJ?=
 =?us-ascii?Q?54Q+eFNOOKDFyrOC5zQchd2BIl4TjyvIQjD8vCXaG2qREPOeJ6B3egdNTsoS?=
 =?us-ascii?Q?91Z9iUXF0sSVJls1+Z8QiH6nh8kZB+4xyJYXHplRLg5bGUdi3zexb810ontT?=
 =?us-ascii?Q?chMhbq+G3yuEhqc/gPLdHwV8q8QanMQ9rGeyJD4KWUiDte2bgRJZj3E8JuJk?=
 =?us-ascii?Q?66d1emhPlcJDg9cuPZhXDJNnF5sIVbFX7RqUJ77VqRWsbA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cef49df-27fe-4810-8288-08d98e955466
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 22:03:46.8700
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hJgdxJv1/G1nA8ahGzS0eUkQj11fObrWVJ7VuUVGqIK+VN8ih3BvBzPYSR0G5UIP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR15MB4932
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: 2Ep601Gw28405jULmG8o8Iz2hvOnM7Vx
X-Proofpoint-GUID: 2Ep601Gw28405jULmG8o8Iz2hvOnM7Vx
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-13_08,2021-10-13_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0 malwarescore=0
 suspectscore=0 mlxlogscore=758 impostorscore=0 bulkscore=0
 lowpriorityscore=0 phishscore=0 adultscore=0 clxscore=1011 spamscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110130133
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 13, 2021 at 12:43:38PM -0700, Shakeel Butt wrote:
> The commit 5c1f4e690eec ("mm/vmalloc: switch to bulk allocator in
> __vmalloc_area_node()") switched to bulk page allocator for order 0
> allocation backing vmalloc. However bulk page allocator does not support
> __GFP_ACCOUNT allocations and there are several users of
> kvmalloc(__GFP_ACCOUNT).
> 
> For now make __GFP_ACCOUNT allocations bypass bulk page allocator. In
> future if there is workload that can be significantly improved with the
> bulk page allocator with __GFP_ACCCOUNT support, we can revisit the
> decision.
> 
> Fixes: 5c1f4e690eec ("mm/vmalloc: switch to bulk allocator in __vmalloc_area_node()")
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
> ---
>  mm/page_alloc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 668edb16446a..b3acad4615d3 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5215,6 +5215,10 @@ unsigned long __alloc_pages_bulk(gfp_t gfp, int preferred_nid,
>  	unsigned int alloc_flags = ALLOC_WMARK_LOW;
>  	int nr_populated = 0, nr_account = 0;
>  
> +	/* Bulk allocator does not support memcg accounting. */
> +	if (unlikely(gfp & __GFP_ACCOUNT))
> +		goto out;
> +

Isn't it a bit too aggressive?

How about
    if (WARN_ON_ONCE(gfp & __GFP_ACCOUNT))
       gfp &= ~__GFP_ACCOUNT;

And maybe with some explanatory message?

Thanks!