Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] iio: imx8qxp-adc: mark PM functions as __maybe_unused
To:     Cai Huoqing <caihuoqing@baidu.com>, Arnd Bergmann <arnd@kernel.org>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20211013144338.2261316-1-arnd@kernel.org>
 <20211014012936.GA2999@LAPTOP-UKSR4ENP.internal.baidu.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <50f71530-bab0-58f4-cf90-a7c1b60b9716@infradead.org>
Date:   Wed, 13 Oct 2021 18:40:41 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211014012936.GA2999@LAPTOP-UKSR4ENP.internal.baidu.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/13/21 6:29 PM, Cai Huoqing wrote:
> On 13 10月 21 16:43:26, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Without CONFIG_PM_SLEEP, the runtime suspend/resume functions
>> are unused, producing a warning:
>>
>> drivers/iio/adc/imx8qxp-adc.c:433:12: error: 'imx8qxp_adc_runtime_resume' defined but not used [-Werror=unused-function]
>>    433 | static int imx8qxp_adc_runtime_resume(struct device *dev)
>>        |            ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/iio/adc/imx8qxp-adc.c:419:12: error: 'imx8qxp_adc_runtime_suspend' defined but not used [-Werror=unused-function]
>>    419 | static int imx8qxp_adc_runtime_suspend(struct device *dev)
>>        |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Mark them as __maybe_unused to shut up the compiler.
>>
>> Fixes: 7bce634d02e6 ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Reviewed-by: Cai Huoqing <caihuoqing@baidu.com>

Looks the same as
https://lore.kernel.org/all/20211013014658.2798-1-caihuoqing@baidu.com/

but that one is mixing the Fixes: tag.

>> ---
>>   drivers/iio/adc/imx8qxp-adc.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/adc/imx8qxp-adc.c b/drivers/iio/adc/imx8qxp-adc.c
>> index 5030e0d8318d..901dd8e1b32f 100644
>> --- a/drivers/iio/adc/imx8qxp-adc.c
>> +++ b/drivers/iio/adc/imx8qxp-adc.c
>> @@ -416,7 +416,7 @@ static int imx8qxp_adc_remove(struct platform_device *pdev)
>>   	return 0;
>>   }
>>   
>> -static int imx8qxp_adc_runtime_suspend(struct device *dev)
>> +static __maybe_unused int imx8qxp_adc_runtime_suspend(struct device *dev)
>>   {
>>   	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>>   	struct imx8qxp_adc *adc = iio_priv(indio_dev);
>> @@ -430,7 +430,7 @@ static int imx8qxp_adc_runtime_suspend(struct device *dev)
>>   	return 0;
>>   }
>>   
>> -static int imx8qxp_adc_runtime_resume(struct device *dev)
>> +static __maybe_unused int imx8qxp_adc_runtime_resume(struct device *dev)
>>   {
>>   	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>>   	struct imx8qxp_adc *adc = iio_priv(indio_dev);
>> -- 


-- 
~Randy