Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ipv4: only allow increasing fib_info_hash_size
To:     =?UTF-8?B?5byg5Yev?= <zhangkaiheb@126.com>
Cc:     davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
        kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211012110658.10166-1-zhangkaiheb@126.com>
 <23911752-3971-0230-cfd2-f8e30e8805db@gmail.com>
 <3bd88b51.6c7.17c77339c10.Coremail.zhangkaiheb@126.com>
 <9404e2d8-0976-1726-5f08-c277cdc14945@gmail.com>
 <5219d023.14d1.17c778a9a18.Coremail.zhangkaiheb@126.com>
 <1e3f52c3.350f.17c78afcc56.Coremail.zhangkaiheb@126.com>
From:   David Ahern <dsahern@gmail.com>
Message-ID: <fc1bde05-8f7b-9d1f-a55f-8c77cfd55ee3@gmail.com>
Date:   Wed, 13 Oct 2021 20:51:59 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <1e3f52c3.350f.17c78afcc56.Coremail.zhangkaiheb@126.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/13/21 2:05 AM, 张凯 wrote:
> Should we let the function still work when the below check is true, not goto failure?
> 
>        if (new_size < fib_info_hash_size)
>                goto failure;
> 
> 

no, it can not.

if (fib_info_cnt >= fib_info_hash_size) {

means the hash table is full. It is going down this path to expand. If
expansion can not happen then you can not add more entries.

This is all theory hence the request for a simpler change; in reality
there should never be so many unique fib_info entries across namespaces
to hit an overflow.