Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4112789pxb; Wed, 13 Oct 2021 21:26:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2hDLwCC9mFKvJINrRrsbu4H0VUo8kkCOSReCG8mcwxA1V8Lem1HlU/Eu77jtHibzxKFgJ X-Received: by 2002:a17:907:20d0:: with SMTP id qq16mr1134162ejb.168.1634185611906; Wed, 13 Oct 2021 21:26:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634185611; cv=none; d=google.com; s=arc-20160816; b=iboe/Vep2ZmynYX7zlcTt5Up+GjzsJ3IepZRu9rlzwprkLdwg5Ts/31V30qoB3jsXm djo9FrHv7BWFSboc6tgs0Pb7R/4LbneecYymPM9DxMPt8dSTnE0v9TAnnLnZ1zye6top Cl4rf7ZAPw08e/1Ffj6glhDsii1fhtH5xNhaUAfD9en74BfcEkkDl3qac/UEvTD7en2L ZU8JcV3umkEp4OnNHg0UYdexqHdgTVZdyYumS5V2OapKNypz3dTGCOtwm+Fsj1cd8mnv p3VHfjgJvdKt+vsIEp0eZ7QF3caO/B4VxF8lOgYDeIUXa55OmDqZdUQ6stBhFHnIWNo2 U7cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Sf5LtRGe5F0Qv0Jrs0KeAk3ER+Yqw+OwUL17pIW/4hM=; b=kzIkQNB+1UfCTIUmFkDXV4Z7TOle/x1cAUclDy6RNHybRIn2VSa5EZ7Hr9i3bxgiqX 6SI8UMhdkzR8Aw7wLdty0529ATH6cH2hVldT41npKpaj3bp5/HCRLL9AkHzJS05pHjwE bdM5mQaWHcnndzbq1XWINoDzvjcdN1A3FE8GKf4/g1QMLIMi0NmtwNpw5f1yk6DjbZlG ZP98/8VVPdQMjwaXS8FTGLEqisnqL3waEy1DFXNERcKW4ad1Y5qAR4zW0aIy9CVRlm3c g/nxNhPC27C0MA+VJ0qG1euStGfcr9vDB6+XVLqlUtohDoDMy1P617r35TwkbaIQqC3i vuFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NJsvyTBo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gk1si3232369ejc.31.2021.10.13.21.26.04; Wed, 13 Oct 2021 21:26:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NJsvyTBo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229502AbhJNE0F (ORCPT + 99 others); Thu, 14 Oct 2021 00:26:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:50358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbhJNE0F (ORCPT ); Thu, 14 Oct 2021 00:26:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E55A610E6; Thu, 14 Oct 2021 04:23:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634185441; bh=vJT/Fonji+gCvVPQnpFOqQuK7TrDdMcCq3KD+XwPQrA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NJsvyTBoSfoZNbPYAppoygn4O8oOOzSLbV4yW8U9PKSt1zuesKel5DwhJiNQZgh2U gVywR9Xaj1JXtnZfJyBozyyx9npBCSaSEGAC1ZA0c/wUXz7GwoNGBebdQmDuX/IEaw XqCD22T72Y1odbGgOkWoalVsNitqho2Smn2C+AawksdT56AkZ+ahx5mKIHxfw5WDEB AMBUW/DaLTsUnfw7vxgeJvYvQ1bIFUOckQZdgLumk6JxkZspdDxUFhH7Q2YCM5dgXS RyIOSm+92lVNeDTd1QZDKo6m/UM6iFpkD7BstfUN1TLahQdEDrCtPV5lb2IXBqrurH C83m+8JxxqjBg== Date: Wed, 13 Oct 2021 21:23:56 -0700 From: Nathan Chancellor To: Peter Zijlstra Cc: kernel test robot , Yafang Shao , llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [tip:sched/core 14/47] kernel/sched/fair.c:893:22: error: variable 'p' set but not used Message-ID: References: <202110121132.N2z9JrD0-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 12, 2021 at 03:35:42PM +0200, Peter Zijlstra wrote: > On Tue, Oct 12, 2021 at 01:26:54PM +0200, Peter Zijlstra wrote: > > > Again, I have absolutely no intention of fixing this. IMO this is the > > compiler being a total pain in the arse. > > > > Please stop reporting this. > > How's this then? > > diff --git a/kernel/sched/Makefile b/kernel/sched/Makefile > index 978fcfca5871..b0d9121c5dce 100644 > --- a/kernel/sched/Makefile > +++ b/kernel/sched/Makefile > @@ -3,6 +3,10 @@ ifdef CONFIG_FUNCTION_TRACER > CFLAGS_REMOVE_clock.o = $(CC_FLAGS_FTRACE) > endif > > +# The compilers are complaining about unused variables inside an if(0) scope > +# block. This is daft, shut them up. > +ccflags-y += -Wno-unused-but-set-variable Please consider making this ccflags-y += $(call cc-disable-warning, unused-but-set-variable) because -Wunused-but-set-variable was only added to clang in the 13 release but we support back to 10, meaning this will cause errors for those older compilers. With that: Reviewed-by: Nathan Chancellor Additionally, perhaps this could be restricted to just fair.c? > + > # These files are disabled because they produce non-interesting flaky coverage > # that is not a function of syscall inputs. E.g. involuntary context switches. > KCOV_INSTRUMENT := n >