Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] soc: qcom: smp2p: Add of_node_put() before goto
Date:   Thu, 14 Oct 2021 02:23:49 -0400
Message-Id: <20211014062350.8942-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2QAmlKT1p6hoJPSQLxN/gDnDiM+QrzJs8phkMrJ5WGI9ly3TrxEu9/10uP3G?=
 =?us-ascii?Q?gutCbQHtwgpaZSEifJNXQltPlUOXFgFm6yBnuyPvv5xiXEisQMBwkh9YMOt6?=
 =?us-ascii?Q?hvKbEx1RwdKxxpnppXYqzwl+5xsWhcIu2xPPtPHC0fXvao2zbJlumtm2vuT0?=
 =?us-ascii?Q?5jSSfZt3P73wMkOCMJ9DoOsX/yVc1f4DDNDr7xoRLsJQaaL0FMGsQpCBFRWc?=
 =?us-ascii?Q?8tKHp8PFWYPe1w6IrdE6vbnYyQeT6QWoJ6w0UeCiUR4BNB59aqAwH8cVeCrX?=
 =?us-ascii?Q?moXGEnnJpR0U15CSRf+bGPoNomJZRaa+c+oHKL9Nsyig20d2Af7CLeQaFhfs?=
 =?us-ascii?Q?QXuEKsnvWe0nZgvPS3/hPxZl6ZLSadji6BEmNahbBrqPIb5VkzQdaYmwhpfi?=
 =?us-ascii?Q?3pCNUH++Xf35uQ3HTAyE8cfvk9i05T0ps2NDosOuwQVtQHL0WnS3W8LPnc8p?=
 =?us-ascii?Q?gJQTv7+DwSYvjh8d6zXjejFZzWlua1FjHNlme1+WNSEjinIBVXbBcq9mBCkw?=
 =?us-ascii?Q?T8nndHrUaTTOuy/7LIJgCGkWpWPu1hUJV60FwNlQJC9jydljgm4wGPXoxuJb?=
 =?us-ascii?Q?V+BO11IXIwjmMgQlbr1sd91UIh5xigphnQZY6FSLh7OA3b7m0uvW9jiS0PBt?=
 =?us-ascii?Q?bWV+SQWv7Aj2ZOi/6G+nyevDWPPdBfwLcD1nEhyayOidzJZgBK37HkBpKwpk?=
 =?us-ascii?Q?zQvEktHSqL5HCEIP1Ius/6VjGU/tzwCqagi+RTycqa3QUrNoFjjxvva6mNEd?=
 =?us-ascii?Q?ivKaDK3NQsEAxLgBAh1uoPzF47X6oww5ol+g/NZ/skks5yTLHPAptm9REZiS?=
 =?us-ascii?Q?E3g6+XMMxEPqtJDlhR0enrtEGPX2bVpOc7Roo5EVI2IbuDdQKnzBnVx4YH8i?=
 =?us-ascii?Q?2PLZ4T3qNzM0MLUX+wMDMIXu/EkkNGjP342pywzD5jWmLvPWmaT4fswkj0QS?=
 =?us-ascii?Q?r9+YuPIlA4eQUl6iPjX1T1q9Qj0S/LWJa17Za5fqmNTtsPbTMxljDi4kBK87?=
 =?us-ascii?Q?3aqPMOXi2yCJmDuHU/P7+BZizg9whoKM2KwJ15hsWPcS2CMOjnsHbX1/FM76?=
 =?us-ascii?Q?JDhVahWRgG9qLkLFw42G6HWJ8YfL9VqTZuqYb8FatI3Q1FVINPinuYj/f2+m?=
 =?us-ascii?Q?xjcEzyCBDp++nnEk9ejuH0uMh/UaLihsGQ6S28HrkCv4DNUVINc0tvkIq/lF?=
 =?us-ascii?Q?Jq3nJgvr9aQwHKYSn480Mgn7YZl5gZHM/G66J3hn/sm8cnCRENBVguXPA8Wc?=
 =?us-ascii?Q?l/EtWdwjPYUcJebAQSEX6/E11lD8nEwOZv//NPfGnEYkgHia/W6VYQv/Ukoj?=
 =?us-ascii?Q?4HVa3sB4vBWpPEJjFlCDOpSW?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d421e62-4219-40a7-73eb-08d98edb3716
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 06:24:02.7073
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w7nHOX68LiMOmTN5Y0KTXU8GuS0nPFxFy8X6SqxkYL/QRCzmRW85RywO8ybEbsXXsUvebdko6pN0jAXhFn2lLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2460
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/soc/qcom/smp2p.c:501:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before goto

Early exits from for_each_available_child_of_node should decrement the
node reference counter. 

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/soc/qcom/smp2p.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
index 38585a7edfe7..2733f494009f 100644
--- a/drivers/soc/qcom/smp2p.c
+++ b/drivers/soc/qcom/smp2p.c
@@ -502,6 +502,7 @@ static int qcom_smp2p_probe(struct platform_device *pdev)
 		entry = devm_kzalloc(&pdev->dev, sizeof(*entry), GFP_KERNEL);
 		if (!entry) {
 			ret = -ENOMEM;
+			of_node_put(node);
 			goto unwind_interfaces;
 		}
 
@@ -509,19 +510,25 @@ static int qcom_smp2p_probe(struct platform_device *pdev)
 		spin_lock_init(&entry->lock);
 
 		ret = of_property_read_string(node, "qcom,entry-name", &entry->name);
-		if (ret < 0)
+		if (ret < 0) {
+			of_node_put(node);
 			goto unwind_interfaces;
+		}
 
 		if (of_property_read_bool(node, "interrupt-controller")) {
 			ret = qcom_smp2p_inbound_entry(smp2p, entry, node);
-			if (ret < 0)
+			if (ret < 0) {
+				of_node_put(node);
 				goto unwind_interfaces;
+			}
 
 			list_add(&entry->node, &smp2p->inbound);
 		} else  {
 			ret = qcom_smp2p_outbound_entry(smp2p, entry, node);
-			if (ret < 0)
+			if (ret < 0) {
+				of_node_put(node);
 				goto unwind_interfaces;
+			}
 
 			list_add(&entry->node, &smp2p->outbound);
 		}
-- 
2.20.1