Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     David Gibson <david@gibson.dropbear.id.au>,
        "Liu, Yi L" <yi.l.liu@intel.com>
CC:     "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>, "hch@lst.de" <hch@lst.de>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "jean-philippe@linaro.org" <jean-philippe@linaro.org>,
        "parav@mellanox.com" <parav@mellanox.com>,
        "lkml@metux.net" <lkml@metux.net>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "lushenming@huawei.com" <lushenming@huawei.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "yi.l.liu@linux.intel.com" <yi.l.liu@linux.intel.com>,
        "Tian, Jun J" <jun.j.tian@intel.com>, "Wu, Hao" <hao.wu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "jacob.jun.pan@linux.intel.com" <jacob.jun.pan@linux.intel.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>
Subject: RE: [RFC 13/20] iommu: Extend iommu_at[de]tach_device() for multiple
 devices group
Thread-Topic: [RFC 13/20] iommu: Extend iommu_at[de]tach_device() for multiple
 devices group
Thread-Index: AQHXrSGaa5Rm1P0kqEyK39kAddiKjavSHSOAgAAai+A=
Date:   Thu, 14 Oct 2021 07:06:07 +0000
Message-ID: <BN9PR11MB54337A8E65C789D038D875C68CB89@BN9PR11MB5433.namprd11.prod.outlook.com>
References: <20210919063848.1476776-1-yi.l.liu@intel.com>
 <20210919063848.1476776-14-yi.l.liu@intel.com> <YWe+88sfCbxgMYPN@yekko>
In-Reply-To: <YWe+88sfCbxgMYPN@yekko>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zSzrR2UJ8li2dtWfW+RYnpHwyUnKtxci7FSh5noXWlxdGi4eCK0eOxULicmg?=
 =?us-ascii?Q?P5gjSc9diuWAYUZ5whCdGzerZS1+6Y8D7jI+C1nqI/jXsKCgkJGaZz7YfE4X?=
 =?us-ascii?Q?TCyzcn4Afxm64iCzUn1LBoZa69kQZznkaFxO2Nis5PqX+vzIyKtBszrh5jjG?=
 =?us-ascii?Q?SNhRZhh8fRvpOU6FJDv8eBlzd6o/6hOfsNhxs1ue2MJ20r2BKTiNM1g9B+Jv?=
 =?us-ascii?Q?u7u2FE1+eP+Nh/ovzXiIS0CnyHXPjCPJbaWr/CLu44VbGb99p7qBs+U53yZu?=
 =?us-ascii?Q?peFtOZbJF8qXIYeE+watFfPNOYEWxymWPFpV9Za2iu56oZioSPQ4mRHNfTQ0?=
 =?us-ascii?Q?LwvWQyJQWE5+NzQxi/m7llrkFybFcaohBw9ofXS4rArpy+HSfz/pxNoCcg9h?=
 =?us-ascii?Q?wxUZ003FGdzS90CgmaAd6zo4CTe9WAJwmiQXMy0HUKw1TA9U1GyUMfdb8Fyy?=
 =?us-ascii?Q?i0+OWwq+5/QlcnLgfFoRkf4w+OkA2d+sgyH8Mw0NE5Zoqcd8gUD+68pMjYDn?=
 =?us-ascii?Q?1WIcKiy65145vk53H6NMiF0rRrZKIpg791LrYaR1XExJFC88fZ1WbIokXrpN?=
 =?us-ascii?Q?JQxWoQr7IwO7/8F0/NlfRiM5o/Tuh6NrS8LZtSDF4lrX205w9D/k8kZX1DaO?=
 =?us-ascii?Q?SnLlhby0afoJWFe2FMI2yumfmHpske912NByUYJUUb492TH+qbLjC9XcVovH?=
 =?us-ascii?Q?oh2/lsfOS606QV6WoJ+16gxV/87vy2z/lOtRb2b3S+9veEYPg/g8P7lZ/7Tf?=
 =?us-ascii?Q?ZG40Xm17pYzE21QEYqEhidxZkibPM5ngs8yrNPIAuTR0kMbvHGXMdJtXOkcU?=
 =?us-ascii?Q?AT43uqmY7fcKAZDBzXXo4/RwW7zXYtaMdMqDj9ojk0TB/Sk3xuf5brd01ODG?=
 =?us-ascii?Q?UPI0Fr23k/ul/Kgr5LB7LNpbeseBaDE7GPQqM+QaOXxwwJucRJjD96tzMNrz?=
 =?us-ascii?Q?enj5vulAJEWzLPOysSXyR5sG1NOIxm2dTyezON8PuHsV2w6dpTRU6L9Slrcn?=
 =?us-ascii?Q?YBlU8eRk7+xRadArQ/BG2f+4g32upnUc2uTozP9CeBlqjsvDGCkbeSg1FuqT?=
 =?us-ascii?Q?THKXMTCepgx6kydMbRY5/btpJO29Fln8kciB/en+0DDq/EN6SXS2mXS/GVbr?=
 =?us-ascii?Q?U6XvF8uIMy0brVnXEOqprUWisR2OL+UvVnzi2QlSbKHMuLDKYziI8h15mvg5?=
 =?us-ascii?Q?YjoBsHBtax6LK4Vd3JlM5j1PO2maBveF9gZj8vp06Sz48Ly8QpcacrV5sBRC?=
 =?us-ascii?Q?0Y2A+H2hVmh1zEwzepSo3V9krXJaIIt+JIrgtxaxqW2koFzpyDnMYSfVjd0D?=
 =?us-ascii?Q?d64BzPTDFAZ7A/ppt4rj3Ayq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5433.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec1adbf5-0ad1-47a8-5d12-08d98ee1183b
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 07:06:07.3113
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PFyBb1Xp9jxJmPuDWY28xxAIsOj9dWDP8D1pZ4urgdr8Rb0Y/FBAASwMFq8sj4lsgSMnTvjKlM2AhlMQO5yexg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB2020
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: David Gibson <david@gibson.dropbear.id.au>
> Sent: Thursday, October 14, 2021 1:24 PM
>=20
> On Sun, Sep 19, 2021 at 02:38:41PM +0800, Liu Yi L wrote:
> > From: Lu Baolu <baolu.lu@linux.intel.com>
> >
> > These two helpers could be used when 1) the iommu group is singleton,
> > or 2) the upper layer has put the iommu group into the secure state by
> > calling iommu_device_init_user_dma().
> >
> > As we want the iommufd design to be a device-centric model, we want to
> > remove any group knowledge in iommufd. Given that we already have
> > iommu_at[de]tach_device() interface, we could extend it for iommufd
> > simply by doing below:
> >
> >  - first device in a group does group attach;
> >  - last device in a group does group detach.
> >
> > as long as the group has been put into the secure context.
> >
> > The commit <426a273834eae> ("iommu: Limit
> iommu_attach/detach_device to
> > device with their own group") deliberately restricts the two interfaces
> > to single-device group. To avoid the conflict with existing usages, we
> > keep this policy and put the new extension only when the group has been
> > marked for user_dma.
>=20
> I still kind of hate this interface because it means an operation that
> appears to be explicitly on a single device has an implicit effect on
> other devices.
>=20

I still didn't get your concern why it's such a big deal. With this proposa=
l
the group restriction will be 'explicitly' documented in the attach uAPI
comment and sample flow in iommufd.rst. A sane user should read all
those information to understand how this new sub-system works and
follow whatever constraints claimed there. In the end the user should
maintain the same group knowledge regardless of whether to use an
explicit group uAPI or a device uAPI which has group constraint...

Thanks,
Kevin