Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 14 Oct 2021 10:37:52 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Corentin Labbe <clabbe@baylibre.com>
Cc:     mchehab@kernel.org, hverkuil@xs4all.nl, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, mjpeg-users@lists.sourceforge.net
Subject: Re: [PATCH v2 04/10] staging: media: zoran: add debugfs
Message-ID: <20211014073752.GM8429@kadam>
References: <20211013185812.590931-1-clabbe@baylibre.com>
 <20211013185812.590931-5-clabbe@baylibre.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211013185812.590931-5-clabbe@baylibre.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rh+0clB+uiZMVc8yIGixX/A6tR/JWHXYvi9hxWoWKHyofkZ85lbLVKpgQa+X?=
 =?us-ascii?Q?bulGmH1GEDUsMjoMFnkqkKNZFFdJlcvfzee4rsYzUXB3A4+CIBhVquyjNm8g?=
 =?us-ascii?Q?0y94110MSEUrGVhmIdSmrzx/TVbF3LjUS+yv+X4w/A33tao/16LGCiyUrpKb?=
 =?us-ascii?Q?2JbTuj4dt50vtTWBJueLAIBl10CfmABdTQU80u/ZfA4Rhv5AvU+LeDfGqnzB?=
 =?us-ascii?Q?5mwXDI0mdd03HOWWrfVM1JpAKeAW2LSQNGFlRHIBGlkHTcH/glalv6+9vNbc?=
 =?us-ascii?Q?qN8JL1D1wTAy6dFs/lnig6HLjnkzJLRDljHwxfbr7vdiwC2dvzaAGDN1JU6i?=
 =?us-ascii?Q?/qy0j7IRCEtC2Tvwu0Hc1xL20+4QaDA8OesfPsELJsm2FJPC7VLGogDWq9oC?=
 =?us-ascii?Q?bNNp0hQgrKr7trpBJtPgaKSR3F4BLZd3tQPhoh1tvMc/Pg1fLMY5ONN9x9jw?=
 =?us-ascii?Q?ICt7xBSon/25YrOZkUVuiRgT9i/tUqgnU36xMCJWPjpNAdgpUehXUTKPs7Nb?=
 =?us-ascii?Q?XXXltsCIYZc/UGZ4Tl4rCJXI+kAJvZnxcm6N5E2LO3HcmqAPFZu8NDuunLxp?=
 =?us-ascii?Q?TT0py/frW5SvY575uNLvMBKP/evu2EqYKzS5ksDF9VV2UW/qo1kTX0U+wu9R?=
 =?us-ascii?Q?WslDlG92O+mW6Uc5XuRw+IIuMYz3OXsK5qn8Wezf4T61k/+JwoKCTr57tMok?=
 =?us-ascii?Q?bun2EfX7Az+4cJFgQR66auiqi9ZPik7DJKvwu35OYo7dCvv2zhafgGKY4xp9?=
 =?us-ascii?Q?ELci/OH/BzLfwIFCC5TIHvU6D4/pyAd0thcEI6+NhsXTCGirXrbBF0Intqx8?=
 =?us-ascii?Q?4pK9ISWuKvXG4oxLeiphiyEc9t0fRhkKbwsExzErAYaM8n8mqTPwyVeNR8p3?=
 =?us-ascii?Q?btrbfOO2AJw/ccTJ/sP8Kn5npt/CYmCcXJttN1sjsM5OR4Xc1X47fB3A89FT?=
 =?us-ascii?Q?7/i3OFMxkp4kIrzmCSBLdDbAdAc9L6K4nRCUcG493FmvyGu4wPPx3lG1OYO4?=
 =?us-ascii?Q?v8gypvJYYleShNU1RilTtJfdEGcDqY8/3fLa8TMYwt+5ZlIYlz8x2aC/s02/?=
 =?us-ascii?Q?XXezGjrSjpj5DY2QOs+RjU8ZSJc6Sl9BqNKkEcmEwc0kqdbLK5yqVR+ca+Vd?=
 =?us-ascii?Q?MxhIH2M/PrWovMhd6f43L82wDis4c33B8rVhFiLqdpElYGJK28aq3uOpd7gW?=
 =?us-ascii?Q?vmTBt1SWWcYvU7UH0zV9QR9fju/heYOwlVQbFxPbVVJGPwq8e+g95XdLHZqt?=
 =?us-ascii?Q?5ow7RD+4mQXiUoL92Jpm8C8vjryM7vEa8sthTXqzZjzxaOJnyxdEK4VX8hcf?=
 =?us-ascii?Q?pZjwDup5+KJeVFA7izsa61Gy?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91397aa6-4424-443a-339f-08d98ee591e2
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 07:38:10.0918
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G+gK7zrNjdZNAbk3TqFofWCLrEYSaxUwuvY/GTW8EKO1SUvSdTtCDP3XzcPawY+5Oq30DUWTRMAHIlYp0MnlCLeR5srujIoqp33JGL2yUQg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5460
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10136 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=862
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110140046
X-Proofpoint-GUID: PgDdyjwVaulFJ-nAs9r6yfFEcO52tCYK
X-Proofpoint-ORIG-GUID: PgDdyjwVaulFJ-nAs9r6yfFEcO52tCYK
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 13, 2021 at 06:58:06PM +0000, Corentin Labbe wrote:
> +config VIDEO_ZORAN_DEBUG
> +	bool "Enable zoran debugfs"
> +	depends on VIDEO_ZORAN
> +	depends on DEBUG_FS
> +	help
> +	  Say y to enable zoran debug file.
> +	  This will create /sys/kernel/debug/CARD_NAME/debug for displaying
> +	  stats and debug information.

Why bother with a CONFIG?  Just make it always on?

> @@ -1286,6 +1321,12 @@ static int zoran_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  
>  	zr->map_mode = ZORAN_MAP_MODE_RAW;
>  
> +#ifdef CONFIG_VIDEO_ZORAN_DEBUG
> +	zr->dbgfs_dir = debugfs_create_dir(ZR_DEVNAME(zr), NULL);
> +	debugfs_create_file("debug", 0444,
> +					      zr->dbgfs_dir, zr,
> +					      &zoran_debugfs_fops);

This whitespace is weird.

regards,
dan carpenter