Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Leonardo Bras <leobras.c@gmail.com>,
        Alexey Kardashevskiy <aik@ozlabs.ru>,
        Frederic Barrat <fbarrat@linux.ibm.com>,
        David Gibson <david@gibson.dropbear.id.au>,
        Wan Jiabing <wanjiabing@vivo.com>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net
Subject: [PATCH] powerpc/pseries/iommu: Add of_node_put() before break
Date:   Thu, 14 Oct 2021 03:56:04 -0400
Message-Id: <20211014075624.16344-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hEa0D3FqpeI2kCjKTvU+KVbYcaWZyu848MUuSGihzX7U+eGQVeFtZ0alrFI5?=
 =?us-ascii?Q?yxAQ1MIIHilUe+UMQxCiQp8dijzL0bGOXODPkxo3kvUWhvfEc3Cb6mPZ6V4y?=
 =?us-ascii?Q?RsVuclbybBgQdz7xW5Orbyy2I3XKegIrfpdc1j+iOB07YLkuDacA8ZYwUmgN?=
 =?us-ascii?Q?/A6/WBSz7mSqmsL43pLLm18F1d6rW8GotJ7fzZNXJWG8fBb0p4Y3GnEFWw/p?=
 =?us-ascii?Q?+26ZUE47SJyAryPoTz55mCydVaWRWla5RarlrrviEq0jIw1mBNAPxP202P+9?=
 =?us-ascii?Q?2xAEi+XjSxNPu2J14jOyjeV4NkPBuJx5+IbC9c04fqFsooASe2rDaxdkHVZj?=
 =?us-ascii?Q?5KI0PrVdggJzfOTGTLKvXuAQVOson7f8V8/cX+fqJTMKG5PsBg2lzoH7jmQc?=
 =?us-ascii?Q?TecIAPMGWlgLPGp7g68k9ycxKfbS1itXOTzFFLL7PqZOYOxCmt5ESzt4QA0O?=
 =?us-ascii?Q?/u9k1eN3Y/0+k9cVEFsByZU45+dIlBVyNDbNn/6S7JgRIm/V6WcgtqPFVUY6?=
 =?us-ascii?Q?5cDXvkyVZeyX5AkKZZY7JbjQSa0UZmhxTASeb6zCuchrpnCjUxWAyaMxbt/o?=
 =?us-ascii?Q?RmR02+3G10NGrUYVkML0bfrTUVymRjq+KrPqBg9s8iANC2ZRdmIw3AmFAMRx?=
 =?us-ascii?Q?0a5px9sTffg4lmSB8pBPaavXLvaj186Mg4vdRHbyKlULtAlKF/l/Cm5KTDkN?=
 =?us-ascii?Q?SLK5r+bwncfRfLeuqXiWWq+L5TQqt8DvqCkDKKz6ONvqcQhHEoXRC1/Z3cTn?=
 =?us-ascii?Q?SDAFXm66tCWNiGdisyvEoQrQfzuLVhgKvnZpaAUbtqyR2QtaBGPXk0mLsnnT?=
 =?us-ascii?Q?Bk4/lFSdjNierh33PmKiGjJ9Di4tsLCUcyFAT1Mgdilb4a3noVbucnG3lF8N?=
 =?us-ascii?Q?eosBb5E7qDw6yuVWmg5XKZSqtOaDDTtG8Sy9SjIAI4jq0svw3yDXNzF0KT5r?=
 =?us-ascii?Q?VqDu+LGRtg2sjLzAj6BzyJx5zkimy2rgZYDtGdvaHvtT+L8roPkNDu192L1G?=
 =?us-ascii?Q?fU5IOGC1lvn1DIOGJcdmGrMlhIPoj0tujQBK6rTuh84gPJYtEMTDhdwCVZna?=
 =?us-ascii?Q?rqqaaaww7TRwy3tk5JRUtP/P1eUUwqsRTXsq2R1xTb4bnqR2SHClO71YXQ4/?=
 =?us-ascii?Q?sP1b/+kNHdHd25VQCje3T89q1LbVgyrTryS4pzV2jxEnxOvB1VW5xn91+VBX?=
 =?us-ascii?Q?cqKf3eHGz+hhOQ0rRzRkoL9eaO6L5AGYqLvQzMeJ5i2CMOIfh4ucw3ve95JC?=
 =?us-ascii?Q?h79/u9AI3gXIT8hdVL5HbdoGWvUHKar9+GRX7TyITKMQke/3W5iFhWmgSvvq?=
 =?us-ascii?Q?gw84zWoUi4Lhh9hwebPSGY5i?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72188c63-d293-44bf-5fbb-08d98ee838e5
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 07:57:09.0677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QU/EylE0enkYd5zSS2q0k5hEzTbhEM2OZVFdjczXEiPrQdVNW4WZU1XPaoZG6Llak0AUupBVKP/lNb2BpCB38g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3365
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:

./arch/powerpc/platforms/pseries/iommu.c:924:1-28: WARNING: Function
for_each_node_with_property should have of_node_put() before break

Early exits from for_each_node_with_property should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 arch/powerpc/platforms/pseries/iommu.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c
index 269f61d519c2..c140aa683f66 100644
--- a/arch/powerpc/platforms/pseries/iommu.c
+++ b/arch/powerpc/platforms/pseries/iommu.c
@@ -929,8 +929,10 @@ static void find_existing_ddw_windows_named(const char *name)
 		}
 
 		window = ddw_list_new_entry(pdn, dma64);
-		if (!window)
+		if (!window) {
+			of_node_put(pdn);
 			break;
+		}
 
 		spin_lock(&dma_win_list_lock);
 		list_add(&window->list, &dma_win_list);
-- 
2.20.1