Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 14 Oct 2021 10:56:30 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Corentin Labbe <clabbe@baylibre.com>
Cc:     mchehab@kernel.org, hverkuil@xs4all.nl, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, mjpeg-users@lists.sourceforge.net
Subject: Re: [PATCH v2 06/10] staging: media: zoran: fusion all modules
Message-ID: <20211014075630.GN8429@kadam>
References: <20211013185812.590931-1-clabbe@baylibre.com>
 <20211013185812.590931-7-clabbe@baylibre.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211013185812.590931-7-clabbe@baylibre.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LUrSDA2z6MqKQ+/87IiwYu/t3w0Td8yceGpikLL/xgde66QlZO6bVBlWYpdG?=
 =?us-ascii?Q?dtIToDT1ObKJQAXNul/2hfAy9yL6rIhWBntbMTwH0kRMAElE2RXYAxDFPhMA?=
 =?us-ascii?Q?Vse0zHEP6iHlzB3RAYQGsvq4Ou6tvTw7eZiUtHtvK9l7eZEQ+ivWKAdZJN59?=
 =?us-ascii?Q?cVETYt0cRhYBbAWMwbR+BwS/sZ3iBeATyn7ukNF9TQEi/BJbTYo+tjvIfTsZ?=
 =?us-ascii?Q?lu6G4KgFBgg3BQzZkc/2Uss9TsO/v4qCGNopbvr9NMORghNvEWIawCyqp7sw?=
 =?us-ascii?Q?KAqBbe2S1n/07TVBALtPh81PSgsuxqeHeBu5ihfvYtyI3DzBR9r1HHB6xQ/z?=
 =?us-ascii?Q?xIlbp3xl2IalBqfyN1T+M5+Wlr9mvA5EUu6CPkCA5ic9b2mm49wa9ktE/hr7?=
 =?us-ascii?Q?n2fZ/hLShk3evp1RGfIyDc9aJfRjF8zC9haLywODIOh8YQfx+lAZQQ0L7Whc?=
 =?us-ascii?Q?hLDnV7uuFUitkg82er8FKf2SoiQpmHknlJ0BMHbLm3ShxAWReT7KhoZzFQTD?=
 =?us-ascii?Q?0cePTjkfTFM1KCrdMAL0YeVYSg7i5MQ5gSO8U/XUz0LJ8N4FMrpFxasnthIA?=
 =?us-ascii?Q?JlfPVLskOuGfTO4w6VvIllPOL6nhwJ6oOqoVH4wWZj1bJJXX33EolmNbwsa+?=
 =?us-ascii?Q?nhrRtJd37JpAqgFYeWfb12hQqyRZNHllvBHJsrfqA0A6NfmR9iYrVkLd3gyc?=
 =?us-ascii?Q?KtDeLsqi0U+647+//ONt8AD+EnweURrURoHn0HDySZ46ChUSURS83NyKG9NZ?=
 =?us-ascii?Q?9LeYQCRR7MKEwL1nfqxx3qfuUjUlsB6Ti45B2S/T00lG2O96DAJvaB0ECiVX?=
 =?us-ascii?Q?nrLF94b6X+bEHCfke9htqCJPKfDWeFfUA9Eqk2mF08hD0F3Ikk7m4rMsVJlB?=
 =?us-ascii?Q?O7fYGqaXUVCI6jGVLEqXtbjcLl187BFwqUgbtz5PZ4PT6CyDzqB/9vc7g4mD?=
 =?us-ascii?Q?mQB9kYAZlD8QPQAodM04agSF3O8S84qRdjkM3VpvtNBdNZ0bwTPBNN+aXCOW?=
 =?us-ascii?Q?k2nq08TGjgW22YKsEbkbmh5mHlp+vm2hmXtfeMGiZL62bsJRQ4nGHHl62FXq?=
 =?us-ascii?Q?/VIjdfGYZYdObGBbHvoweXR0GJ0uF5x4xkTZ5EFyilbzm86SU5bADpV5ld0r?=
 =?us-ascii?Q?rwDmVXfPjtTlHlr8dOYLElzbMA601CeOHPYJFMIlww3npI2x0uX637SMN0bh?=
 =?us-ascii?Q?eaaUIfkCraF5K06LCjDgAs5YXcE+pOUrhejvrhg1SQIBef6meGoKFL/td7Af?=
 =?us-ascii?Q?NQrf14EW3YhahfMrSJAX74LuYZj8eFk+hmqCQp0XeWaeGxXODvsRL+/yljUA?=
 =?us-ascii?Q?8Q+xHbmqPDIZ97LB3GXn2S9S?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4728316d-82fa-425b-2071-08d98ee82c08
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 07:56:47.6390
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: czY6t0NHCOlvOE8f+Fn9mzz43d7s5ExdBEmgOMNX73EXPLu0FXgC9NdEa4PYmLZ+uudcYYMtHux3s1yV/7wOMcEEQh/ZXPhCjxfYMqv9G8g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1359
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10136 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110140048
X-Proofpoint-ORIG-GUID: YkckKRMifYb8Nw9YSD55YFm3_mKXDwah
X-Proofpoint-GUID: YkckKRMifYb8Nw9YSD55YFm3_mKXDwah
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 13, 2021 at 06:58:08PM +0000, Corentin Labbe wrote:
> +static int load_codec(struct zoran *zr, u16 codecid)
> +{
> +	switch (codecid) {
> +	case CODEC_TYPE_ZR36060:
> +#ifdef CONFIG_VIDEO_ZORAN_ZR36060
> +		return zr36060_init_module();
> +#else
> +		pci_err(zr->pci_dev, "ZR36060 support is not enabled\n");
> +		return -EINVAL;
> +#endif
> +		break;
> +	case CODEC_TYPE_ZR36050:
> +#ifdef CONFIG_VIDEO_ZORAN_DC30
> +		return zr36050_init_module();
> +#else
> +		pci_err(zr->pci_dev, "ZR36050 support is not enabled\n");
> +		return -EINVAL;
> +#endif
> +		break;
> +	case CODEC_TYPE_ZR36016:
> +#ifdef CONFIG_VIDEO_ZORAN_DC30
> +		return zr36016_init_module();
> +#else
> +		pci_err(zr->pci_dev, "ZR36016 support is not enabled\n");
> +		return -EINVAL;
> +#endif

The caller already prints an error message.  Can you look through the
dmesg and make sure were not printing a bunch of duplicate stuff?  Also
if load_codec() fails, the probe function still does
zoran_setup_videocodec() on the failed codec.

These would be better in a .h file.

#ifdef CONFIG_VIDEO_ZORAN_ZR36060
int zr36060_init_module(void);
#else
int zr36060_init_module(void) { return -EINVAL; }
#endif

regards,
dan carpenter