Message-ID: <4590AADD.2070304@bx.jp.nec.com>
Date: Tue, 26 Dec 2006 13:53:49 +0900
From: Keiichi KII <k-keiichi@bx.jp.nec.com>
User-Agent: Thunderbird 1.5.0.4 (Windows/20060516)
MIME-Version: 1.0
To: Randy Dunlap <randy.dunlap@oracle.com>
CC: mpm@selenic.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH -mm 3/5] add interface for netconsole using sysfs
References: <458BC905.7050003@bx.jp.nec.com>	<458BCC2C.9070802@bx.jp.nec.com> <20061223213426.aa80907e.randy.dunlap@oracle.com>
In-Reply-To: <20061223213426.aa80907e.randy.dunlap@oracle.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1001
Lines: 33

Thank you for your replies and reviews.

I will follow your advices.

>>  static LIST_HEAD(target_list);
>>  
>>  static DEFINE_SPINLOCK(target_list_lock);
>>  
>> +static ssize_t show_local_ip(struct netconsole_target *nt, char *buf)
>> +{
>> +	return sprintf(buf, "%d.%d.%d.%d\n", HIPQUAD(nt->np.local_ip));
> 
> I don't understand the use of HIPQUAD() here instead of
> NIPQUAD().  Explain?
> 
> Also, NIPQUAD_FMT (in kernel.h) uses "%u.%u.%u.%u".
> This should probably be the same.
> Or just use:	NIPQUAD_FMT "\n"

IP address is stored in the form of host byte order in netpoll structure.
So, You can't use NIPQUAD to follow the current implementation of netpoll.

-- 
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: k-keiichi@bx.jp.nec.com


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/