Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] soc: qcom: apr: Add of_node_put() before return
Date:   Thu, 14 Oct 2021 04:30:17 -0400
Message-Id: <20211014083017.19714-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z8pZBS87I9rhX5zWumIPm8FAAt4S6mqmDEXwosowc562PcNzirzlN4a80zfs?=
 =?us-ascii?Q?IybZ5gJtGPSPL347AjlxeVi/Y5AJeF4l0py64CQzrxuZzfepN8IHCDt07EQn?=
 =?us-ascii?Q?ZBG6nYP4e70BLjUS2G5lFs2aCjkMV0LHGccW274ZZc1t95tyyOfXtx69q4RO?=
 =?us-ascii?Q?im29JIccB626Y3ZP+WZmnLM3mtzbQ3PJwcjOfzfUPgB0bdwRNttWYXbBKcrS?=
 =?us-ascii?Q?uOUGmPO0YUz1gNUsLXD2pLbxCL+hLwkTfGN4KCQLJN/JcmB+5vvllv+anerC?=
 =?us-ascii?Q?mK99g+27yE1gA0OFxK7sGrqVed4t2B6dGiY+Ji2C/ssuopyeybVS3i5LauIx?=
 =?us-ascii?Q?B8vtspogsC8rnjv1D1MYbrOtMPzkIziCjqtPV2qAJTwqpFq0fmlLrNtmz7FD?=
 =?us-ascii?Q?5OpM2JkfeJzL3xvcyziQ95y9pEh5LJbUJCa13Oo8l0zSRqCFClDVBCgBfPUx?=
 =?us-ascii?Q?/S3sKiTR37cVCS8ijiltdoxyAohidr0C3WL8049zH463K390w5d1nr7zTjx5?=
 =?us-ascii?Q?vxml798ZFi40pCnVTRQINJViM4BW9PFaNi8xyY0yj/R2OhPj7e63doix/oIm?=
 =?us-ascii?Q?pjppJ70gC3QbLhh8CtG/Xp/mgFVaHhBE6dmrjGF4iFmOb7aqpVYl7AdFKP2G?=
 =?us-ascii?Q?fChvauHnLFJ7lMfLSlri0cTPZ4IjqE1hhyO4lBQ2ClZ5ooz49exMbibkqdnm?=
 =?us-ascii?Q?3faJwngvqOgzUhDuL1Tv4cQV6t9sgV30E3DeqA99/02AC/3q+jeN/xE7Euqt?=
 =?us-ascii?Q?9zYaGkvggtL47bRBDC1fV8gcwR9TKwN1k1sZen6aR2+tiZJr28ZOFl9mzV3+?=
 =?us-ascii?Q?wTKZck+lM6t20g/8m/iWEzbjBo4AQ7EHLqChEpyP/+2weQxJwtgtMpYZnBNG?=
 =?us-ascii?Q?ghloJxeKNIbpRQev0PeAj8P9KmswJybjxzDf+Iyv2keHmKAL38RKVhLytymH?=
 =?us-ascii?Q?1uwdxqqMwsXtCratyqpsO1U1Ys/3oJlpBYyZMuR2STql8AyQThQxh+/jaurt?=
 =?us-ascii?Q?Rt8QQQBhDv0LFHct8KOcilfYJQxkztnGw1uqlqjm6+rpK3FseVI13nAALFaM?=
 =?us-ascii?Q?BLDr2VbHjw0PWSY29VETSwINX11myLhQwHBuOT4ocMdgco1YwSWmFptsJ1rF?=
 =?us-ascii?Q?KFi6B8VkQdFbVyXRTH8wTUhf7x1lO4FI1ZmU9nVqfodU62iUKXO8bxc2sNfe?=
 =?us-ascii?Q?pMiwY/aoe5sPDueM+hQqVAOTT8hzUb90N1oyGM0IrIx30oS+nZ9Chzbhl8On?=
 =?us-ascii?Q?jQrVLrwt+Q6pNIvyP4EQ9sNpRGEWy5OXoUHa0QNqkEHsVB5TYN8+/6hTmF/R?=
 =?us-ascii?Q?+88OtS2xX4X1R7tk2CTPYbAW?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2af17867-eb0a-4571-1a64-08d98eece5e7
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 08:30:37.2458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MV0/tHRuco3TKFjRoB7166ZikyHHoIpHMWx3Azy985c53rqogOV/q6XlokCX6m4p2obkv6UmcIooIvOMLh4/sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2858
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:

./drivers/soc/qcom/apr.c:485:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/soc/qcom/apr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c
index 8a9bfbcd4bb9..82ca12c9328a 100644
--- a/drivers/soc/qcom/apr.c
+++ b/drivers/soc/qcom/apr.c
@@ -492,12 +492,14 @@ static int of_apr_add_pd_lookups(struct device *dev)
 						    1, &service_path);
 		if (ret < 0) {
 			dev_err(dev, "pdr service path missing: %d\n", ret);
+			of_node_put(node);
 			return ret;
 		}
 
 		pds = pdr_add_lookup(apr->pdr, service_name, service_path);
 		if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) {
 			dev_err(dev, "pdr add lookup failed: %ld\n", PTR_ERR(pds));
+			of_node_put(node);
 			return PTR_ERR(pds);
 		}
 	}
-- 
2.20.1