Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     =?UTF-8?q?Beno=C3=AEt=20Cousson?= <bcousson@baylibre.com>,
        Paul Walmsley <paul@pwsan.com>,
        Tony Lindgren <tony@atomide.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] ARM: OMAP2+: hwmod: Add of_node_put() before break
Date:   Thu, 14 Oct 2021 04:57:19 -0400
Message-Id: <20211014085719.23739-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IpYXyxPmI5TWEX7Uo5QlihOyDpJtIZ25dPuPb1FQ1k7/LrqSQcwGdFgBtD1B?=
 =?us-ascii?Q?PbQ3w3Y6jPZh38exE3ttw7VR7QJ/Yc5UFk7CQxMPUE69QFho9Jza08VRpnem?=
 =?us-ascii?Q?5OTskEuO6K5N7b2ZrBwLVx1nv//YpAyzqu2WVaV6U2m17CnGUza2x0ilmd6Q?=
 =?us-ascii?Q?kCYTMaBUm6tP8qAMJLKiKWP9v5b2+NwzSE/RDC4ykco5EeWJYDt2vqpsI6tm?=
 =?us-ascii?Q?O11btJWrD6GLU1d1edxGY5icMW/sGhGiohrfWA6rWKnhkM9z1jYJdyOApq95?=
 =?us-ascii?Q?Uhshc30Yv4jONbFsliq0WlkXh0PE120nLrhZAkhOxlSKMBDhtCOu0gqswDEX?=
 =?us-ascii?Q?AyPJ2xhshyeEo0wZor1WhnIxow5xpRwgz//2+OD164EafqJy9V23vnpWCcxD?=
 =?us-ascii?Q?zwCMv+oz06+bOFCchQcMljXtRo3xIN1bo+Sv9/0wg+yGG/xU7n1nt2MhS/Rb?=
 =?us-ascii?Q?QRm47bYK3SoOqXyu4jaSSNAjgPE8m5bepv0yissAUUFHgnpzu0QUkmzFcnwC?=
 =?us-ascii?Q?Ao1uR2ZyJHYEgrp+dlY1Xwi74apthXKtWdlmyapl5Vod+I1DIDFrEl6R4qcy?=
 =?us-ascii?Q?VBjpIaa7qe8kWV7OlIGDuGs6doUW46zzJRch5TJ5gnM16rMoILktPtf0iBOb?=
 =?us-ascii?Q?hRpH1ORLmn8arKNdbqX+7BaDPpbWUixeb2eOf/5a5fdaQPOGnq/1ecTgpn0n?=
 =?us-ascii?Q?3nKKrSN7J5bvbztoAq/MrBNatzdQmfeq2fUJkPRFJ78BahEWIoOIGQvN1nNo?=
 =?us-ascii?Q?9UyddHTDvo1j6DUL2uW1+Ag3sJPaAl7QXnrbiRGJX/Vi+2KIs6E7fKrOtswI?=
 =?us-ascii?Q?dR5fsCl0SlRKBuIjmG9yKOazDvrLy5+AwPArBHaRi1BAlWiMngwsri3fAhY2?=
 =?us-ascii?Q?WI/V914CDtPCT0r9xiq+YpFZv1QCuJkXkx1a8eEkA/qZgGxSPaJ7fF9cWrJE?=
 =?us-ascii?Q?AZr5ohPePVO7mIHnzDANYwfXI4U5SaVrltettb1kR677qtKVJoWzBA4hNTvl?=
 =?us-ascii?Q?UgfIFUGoYXI3i1tA+gBY0w/EC/kVpn5TzLhgRgWHHWgYjTtca6DxhSS0Pzfo?=
 =?us-ascii?Q?3zkbIXVXeMWa/3DNS+gqTM8fo3HK0saBsBdcll26tPGmF6acruR4R39OGNyt?=
 =?us-ascii?Q?z5ws8LusNFVl08dgYrEeYPvLNyypoU92aZ7MgADdJAOKb0fco/9irNyZwZOD?=
 =?us-ascii?Q?XIPxFKaVMS6RZHtIloWC31rs3gPQmYj7shcEkimK788m1xPA7OtvgqNd//rU?=
 =?us-ascii?Q?vGKUl/6689Yh7CnQAeHxgWSN87atuEMUOWjU4/2AAzotLJ9NHkeVWZcC2lYZ?=
 =?us-ascii?Q?OdBhVhlKtpvgev7UqRbEPAul?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d58b6d4e-dad4-41be-bd45-08d98ef0a88c
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 08:57:32.4334
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ntVhXcLb9PotQEEZ4LIW/Rqdpy9DZX7GctfJjPAMqc0+MspCRct01wlNhOAEeTEggCFWbMcr/AoVpBAk8hmmew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3367
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./arch/arm/mach-omap2/omap_hwmod.c:753:1-23: WARNING: Function
for_each_matching_node should have of_node_put() before break

Early exits from for_each_matching_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 arch/arm/mach-omap2/omap_hwmod.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index ccb0e3732c0d..31d1a21f6041 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -752,8 +752,10 @@ static int __init _init_clkctrl_providers(void)
 
 	for_each_matching_node(np, ti_clkctrl_match_table) {
 		ret = _setup_clkctrl_provider(np);
-		if (ret)
+		if (ret) {
+			of_node_put(np);
 			break;
+		}
 	}
 
 	return ret;
-- 
2.20.1