Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 14 Oct 2021 12:09:16 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Stephane Eranian <eranian@google.com>
Cc:     linux-kernel@vger.kernel.org, kan.liang@intel.com,
        ak@linux.intel.com
Subject: Re: [PATCH] perf/x86/intel: fix ICL/SPR INST_RETIRED.PREC_DIST
 encodings
Message-ID: <YWgBzFf31lR6oGVA@hirez.programming.kicks-ass.net>
References: <20211014001214.2680534-1-eranian@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211014001214.2680534-1-eranian@google.com>
Precedence: bulk

On Wed, Oct 13, 2021 at 05:12:14PM -0700, Stephane Eranian wrote:
> This patch fixes the encoding for INST_RETIRED.PREC_DIST as published by Intel
> (download.01.org/perfmon/) for Icelake. The official encoding
> is event code 0x00 umask 0x1, a change from Skylake where it was code 0xc0
> umask 0x1.
> 
> With this patch applied it is possible to run:
> $ perf record -a -e cpu/event=0x00,umask=0x1/pp .....
> 
> Whereas before this would fail.
> 
> To avoid problems with tools which may use the old code, we maintain the old
> encoding for Icelake.

Uuuuhhhhh.. but we 'stole' event=0x00 for the fake events. There must
not be actual hardware events there or we're in trouble. I thought Intel
knew that, I'm sure I told them that.