Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     pgwipeout@gmail.com
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-rockchip@lists.infradead.org
References: <20210812204116.2303617-1-pgwipeout@gmail.com>
Subject: Re: [PATCH v2 0/8] phy-rockchip-inno-usb2: support rk356x usb2phy
From:   Michael Riesch <michael.riesch@wolfvision.net>
Organization: WolfVision GmbH
Message-ID: <c2df4e64-a0aa-8da4-e279-2666e4d53d63@wolfvision.net>
Date:   Thu, 14 Oct 2021 12:11:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210812204116.2303617-1-pgwipeout@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MG45UktMQUtLN1FHTS84UjYwMU1rZVJDclU0SVNGY2lham4yUFRtSW5hL0pj?=
 =?utf-8?B?S1VOd2RhWlZ0dnR4VmRYZUsrNDZCdmdRZWdOZytpR1gyaEZQUGwzd2x3VTJ0?=
 =?utf-8?B?TmhhNmZPNEJiMlhybSt4OExEUjk2ZGJzbEE2VkJvMDJlSU1oSm13NmNYSUIz?=
 =?utf-8?B?bUtMUHczWnpTQ09ROFR3SEN3NUQvdWlGTUNybFRsK3Myc1dSNU9VVG9LQnBx?=
 =?utf-8?B?VFppZlR1WUdTbTk3dmhqa0VYOTl4c2tvNmh2dU8zWW1Ud3hYbHZJeWUwYjU1?=
 =?utf-8?B?THBLVURSZm5hWWpyNkVQU2R1Sml1NGlqTEdzMk0rRlFHZ0tCaTlyU1FEd0pr?=
 =?utf-8?B?a0xaWjVWTmFWVXA3ZHBFWmlNSW5SMXYrcmxjU3krL1phdlVtclJDbXdRNEoy?=
 =?utf-8?B?Q05ZRzJ5bjgyeGlVdy9DU3phMkphT3JneVhCRjgyYytneTJ1OUsyR2tGWlUy?=
 =?utf-8?B?d1V6b1lSSE1hOWpnYlZmS01RQzlNN3h5cWM2ZjRDQnBCTUtCakg1SzhoT2ZG?=
 =?utf-8?B?bXZBeStnU0I3eTAxeUZpSzVUL3ZabEg3eDB4YytVNmVUYXBONkYrV0ttQWds?=
 =?utf-8?B?NTFDTUJmazZ0ZVZGTFp3OTdKaENWdUFJbjRQMUxndDY3RmsvZUJGaWsvUHJR?=
 =?utf-8?B?ZFBMbzh3UkhUc3dmNGcvTklvcFhMR1VHTDEzNUZ3dThGT0hmWjN3eStvS1NP?=
 =?utf-8?B?c2tkaCsrOXZZVXZUNFBrTFBNRnZLZVBCc2MxaThjeUUrdWVJaDZaMFRHZlBu?=
 =?utf-8?B?K0d6S09DS2hyWnlGWkc1UjJiSk8xNVdPaWgrd3lwc3YxMnBTUUdva1lsVy93?=
 =?utf-8?B?cWpLTVoraC9PU25UTFJYelJBTlVrRU0zc3lxWTF3QStMVCt6SVRFTXV5OFFM?=
 =?utf-8?B?VHljSURtNStnV2dpRDQ5M3cxUlJuakQvQllsT0pDUjhLYmZJVDNyMlRIV1dF?=
 =?utf-8?B?dHBUVlhlYzE5bFRpY3NCN2xZYXVjRFpSMlVZcGJYejQvOTJBVzIxS1BPNXJo?=
 =?utf-8?B?NnhKRGVBODZ6ajFGKzlUallqMU55YytRYzNJbnl5SE1RU2NDN21tMkRUTjNP?=
 =?utf-8?B?Ry9aRDIzNDJDSENGS3VnMmM1cHFYRHNOWWJmQWdmeXBuVmlMcmVFS3VHWUFw?=
 =?utf-8?B?Mk9ZbTQ0ZFovVWZzVU11aXpCM0xTcHVzcUt2bmxmaU8xTkJCNWs1SWY3aGZD?=
 =?utf-8?B?NCt1QUtPenRIKzJDS3RqR0FrTklHUkFkN1N6SXEyNEVwaWZDdXVFRDF6Y1ox?=
 =?utf-8?B?K0w5SjJleUdEeVE5VTVUckVYT3BCY1U1MHFLOGNPVEVERVhxVDQ4SU1nZ21k?=
 =?utf-8?B?VTlVT0YzMXE0cThSSkdqMU1TdWVZZUgrMjFndE5HSG9YZFpFVEtnbFg0aStj?=
 =?utf-8?B?bXB6SHFUbENHay9vaTROSXJWMWxYeUpzd0dwTlNlU25IOXV2aE5PMGN5d21y?=
 =?utf-8?B?UUNhWGZYODZaZ0l1bVFLUnRLR05nUG9tNlhCajc3R3BVU0I0MG9ORk5kbUF5?=
 =?utf-8?B?MlI0OVlFSzhJMHhmWVhYMXFNZzQyQlUwRDV2UjNMcjhDUXI0Yk5MeGtSRXg3?=
 =?utf-8?B?N0lCOFJwcUFGRzNOYUJWSGlQR2ZtVTh4aTNZWXRlVVJuM0t1NHpPRHJxTlRk?=
 =?utf-8?B?VU9WOUx1bU1EZEcwcTl3dEdnY0EyMEhSaHV2V2gxZEhwUzZZTXFic21OS1Q0?=
 =?utf-8?B?WlhYdkJld1VXTmVhelpDSUhjMXdqSTVJMU85eEpzdFExaDZWdnJsbmFRMGpJ?=
 =?utf-8?Q?y+BFp5jsoJFGWb/m+cJZG9eUbBLBosHCDfg9D2c?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b112b55-1b34-4516-688a-08d98efb00f5
X-MS-Exchange-CrossTenant-AuthSource: DBBPR08MB4523.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 10:11:35.5753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q8J5IH+/7g2cUsef84HDgn5RTYxGiETkGSZuj8ecxP2ie/3buE/E9wR8N7mR+vxtIz6NOoBk+LHusDSQyT5FQJisbyrnnBlMhjQw+yH6Px4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5222
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

> Good Afternoon,
> 
> This is my series to support the usb2 phy devices on the rk356x.
> The rk356x phy has a single muxed interrupt and has moved the usb2phy
> nodes out of the grf and into their own nodes.
> The phy needs to tie back into the grf for register control, similar to
> the rv1108.
> By moving the phys into their own nodes, they now have full
> #address_cells = 2 register addresses, but they still reside below the 32bit
> mmio range.
> 
> This driver series only supports the host configuration for the rk356x.
> I have have tested it on the following:
> rk3566 - Pine64 Quartz64 Model A
> rk3399 - Pine64 Rockpro64

On a RK3568 EVB1 with suitable additions to the board dts:
Tested-by: Michael Riesch <michael.riesch@wolfvision.net>

Thanks for your efforts and best regards,
Michael

> 
> Please provide feedback and comments as you see fit.
> 
> Changelog:
> v2:
> - correct the order of the usb2phy-grf dt-bindings patch, thanks Johan
> - correct the conditional requirements of phy-rockchip-inno-usb2, thanks
>   Johan
> - drop increase generic-ohci clocks patch, thanks Heiko
> - correct rk356x.dtsi ordering
> - fix a dtbs-check callout
> 
> Peter Geis (8):
>   dt-bindings: soc: rockchip: add rk3568-usb2phy-grf
>   dt-bindings: phy: phy-rockchip-inno-usb2: add rk3568 documentation
>   phy: phy-rockchip-inno-usb2: support #address_cells = 2
>   phy: phy-rockchip-inno-usb2: support standalone phy nodes
>   phy: phy-rockchip-inno-usb2: support muxed interrupts
>   phy: phy-rockchip-inno-usb2: add rk3568 support
>   arm64: dts: rockchip: add usb2 nodes to rk3568 device tree
>   arm64: dts: rockchip: add Quartz64-A usb2 support
> 
>  .../bindings/phy/phy-rockchip-inno-usb2.yaml  |  31 ++-
>  .../devicetree/bindings/soc/rockchip/grf.yaml |   1 +
>  .../boot/dts/rockchip/rk3566-quartz64-a.dts   |  52 ++++
>  arch/arm64/boot/dts/rockchip/rk356x.dtsi      |  98 +++++++
>  drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 259 ++++++++++++++----
>  5 files changed, 383 insertions(+), 58 deletions(-)
> 
> -- 
> 2.25.1
>