Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4356755pxb;
        Thu, 14 Oct 2021 03:49:11 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxw5gI3wPnI0J9ves1sHElfv6UpzlMDJDAshOsROfmv5yYWO6K5qd+g9BncJ9fl9D1fJ+Ap
X-Received: by 2002:a17:902:8ec5:b0:13a:2789:cbb0 with SMTP id x5-20020a1709028ec500b0013a2789cbb0mr4304959plo.60.1634208550851;
        Thu, 14 Oct 2021 03:49:10 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1634208550; cv=none;
        d=google.com; s=arc-20160816;
        b=w0zP5WZR43IEn8lwFoH5vCzoLm8FIqIfpSn+yjFv+v4up49HY+EgpOe96NC5DNDTro
         SFxPLQNuUtN8SBCnPg2NcafgrF96I6WdmR8vi+t5uovky2hwe43h1hM/FVpiGIIzYlTt
         ZNeWdz7AgaoZUXjYgNCGdYA2cSTRlqRNbriZxKZXpYLbAxPyBNgmQsgojt+8xdW23gac
         PekBQrJAZ7UCyKNSKdCy91HfAJsz5fXBx0atrrDsRC+kPy9bcJOaxrfuV9WfoWtT4DEg
         +Q+w5Y6HgMS60dR+ySNz/zACJgMbMp30GzChQ7Up3/jmPFz2Cg1S4l6+dlfPtdw7GIqP
         1TYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to
         :references:mime-version:dkim-signature;
        bh=Bo5VQ//3tqrnPktse6M9enS5exQT9a929Q+6pOvyezg=;
        b=poERf45Haesz8AgnLC1CZSQolRkFQfm+jOC/qygOtSmiUIoKt0lpMliFnrA7xcVdvE
         V7DddljYJNSOjCFGu3Qd2q1E5w9PSXvnzq69npcoNibeqUbSllNSh1DEYLqGW+d7cXRP
         UTLHGTX/5FThpuZfM/AFiqkxFPfvgDhlT/zOlsmcuhWUbnjZ9bn+WJ3Z15lqXjil1Bcg
         2ppv5Sk0mdgScodojenc/7ZJYTKD2WMXl5JR2nZ0iE4+/DO4N0TawpNL2tM9rJ+8HZJm
         f7gYl+njKPcylO1d6K77KOBRq00i41NETBOWybH9LtYpkWTO2gP7H0laoNcJUkw0jJma
         Dfrg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@google.com header.s=20210112 header.b=qckgPGDz;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id n2si3354359pjp.72.2021.10.14.03.48.58;
        Thu, 14 Oct 2021 03:49:10 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@google.com header.s=20210112 header.b=qckgPGDz;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230026AbhJNKth (ORCPT <rfc822;longbowk@gmail.com> + 99 others);
        Thu, 14 Oct 2021 06:49:37 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45332 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230190AbhJNKtf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Oct 2021 06:49:35 -0400
Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF78CC061753
        for <linux-kernel@vger.kernel.org>; Thu, 14 Oct 2021 03:47:30 -0700 (PDT)
Received: by mail-pf1-x431.google.com with SMTP id v8so970696pfu.11
        for <linux-kernel@vger.kernel.org>; Thu, 14 Oct 2021 03:47:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Bo5VQ//3tqrnPktse6M9enS5exQT9a929Q+6pOvyezg=;
        b=qckgPGDzOiDMdPYjj7VihdXg+SypVSMzKyRh0i8VyoYbdQK7zHYwg6WWpI1xbAbUym
         CShHABDahGp5aiQ8u85i5AZTkOsGkF0uDlzmh8HdLrpJLC5C02YFQN2bJAGFnk+Zlxu9
         2ACVTFFx+Bdk4OJFPoeW/qxMbq6y9E76qvS0avPgVpBsJvHQ/k2tmFw+unky1iyEYfYz
         vUPV541kyFSu6oz5rM9WoXI6n3l5I1+STH7kWoP9ll/IJLCgpGx/qWRedvHpCLhhWbyF
         /jORo46Bv0f6LEKgJx2BhgT7ql3arbNoVhhSQwaDFYuKjLnEjfjYWCMZyoTO48B4HUs2
         zXVg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Bo5VQ//3tqrnPktse6M9enS5exQT9a929Q+6pOvyezg=;
        b=voPhFF/Y1hBr4pEXktgmR7ym1ytvPsIjiHWlNXx7fumjKPRJi4xE6Rb1Y39L4aMtw7
         OHkJtNn6ptktBZN5Z/hUC1fCctQKjqRsJx/xen/U1oc+X0BtwE5At+LfQNDarXuQ4d1j
         Guusw586FGJ5X/qbGlYtrcp10dXFmUBsB1wd/G5U8H0uJAfdN2+xd0k8C5gbanfoJGSm
         tz95vXnm2XNKkg7kIClNTWJtS/V/qsO8RvzxY6O1CrK4QJ8Zzwnsz4+5PYmhEm8VZI2q
         /J3YfvzLbPUIyoXnNgE5akd9ks7LWEq3j8sJCTcyiUbFaRp3HSx8dAa3NaBcoQvMdCi+
         WE1g==
X-Gm-Message-State: AOAM532apjWS9vcJArLNFFTEZHVE4eOHB8IyrLzeNsvOelo2uLpq+6J2
        gJnEfvehZ+kAi7c2PSu1svK3NYlKXkuZ1ylxYV5nNA==
X-Received: by 2002:a05:6a00:d63:b0:44d:186d:c4c0 with SMTP id
 n35-20020a056a000d6300b0044d186dc4c0mr4622573pfv.47.1634208450140; Thu, 14
 Oct 2021 03:47:30 -0700 (PDT)
MIME-Version: 1.0
References: <20211014093112.3852491-1-fshao@chromium.org> <20211014093112.3852491-2-fshao@chromium.org>
In-Reply-To: <20211014093112.3852491-2-fshao@chromium.org>
From:   Tzung-Bi Shih <tzungbi@google.com>
Date:   Thu, 14 Oct 2021 18:47:19 +0800
Message-ID: <CA+Px+wUKXJ7a9th1HyxvCgDTQXL9kHtZH+O9z9oRqCfcF8H-sg@mail.gmail.com>
Subject: Re: [PATCH 2/2] mailbox: mtk-cmdq: Fix local clock ID usage
To:     Fei Shao <fshao@chromium.org>
Cc:     Jassi Brar <jaswinder.singh@linaro.org>,
        Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        "jason-jh.lin" <jason-jh.lin@mediatek.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 14, 2021 at 05:31:11PM +0800, Fei Shao wrote:
> +const char *clk_name = "gce";
> +const char *clk_names[] = { "gce0", "gce1" };
Does letting them static make more sense?