Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4501523pxb; Thu, 14 Oct 2021 06:31:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMq0OFxqwNudSpDSjd8dWZfztojX6L+9liXNU6eq4cDRiXLEZKwRWGn5yw46hFvDG0hane X-Received: by 2002:a17:90a:718b:: with SMTP id i11mr21091732pjk.22.1634218267843; Thu, 14 Oct 2021 06:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634218267; cv=none; d=google.com; s=arc-20160816; b=Cq63aZSuBrovkXouZMl4OIYSgoXs91qbagOuLKbMapugXjqds1OLR4Mqy2aySXAogR AHK4xV2Zg3/ARhpbxww/2g1PAPzpEeUP9aj8TgCUAdli+3Aj7vhyzp/nx1jIVxyifYBp N9TDRg5dLUjPdla7h1gG0hk7rhF7Lz3RAIQVyAy4mZlYzACYJwlw+nTTnVpe03RSsOTE zPsY9OJpkWibX2ICWZkIaXtlA3Mr8SlWuzTq6vv4JgT/XGmxqn1Zj7xvUvT1GSAsQF2r H8uxh4/y/PQhOZAfSMSmKJ2RBa7e7fegKuwe/D1xHDO10SmXwiqcukbiN2sWo4bJcuRI UPkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=mcFm+BU1QZtdhOrofoEVcMB+erUX8EDSFwAU0wWT54I=; b=QUS+arr/MtV4QeLAO7+m0GC4FHDqNzFMkEr1qkVDBcjfgtyJYJFk2n1scywezqDlJx pMWxDid543P7QhWiCgVPfio8fqNRCbKQ0zzEI9/Uxk9A6BOP7x0RU3sDagbTCKFlTKrx DwMIq2vXTKBa0H2J03PiUR0qYCGAcxK7a8swgwGD0P1+xhBgvfCbznOTrkHWxl/W53bP sIqDWb/xuDj4dGINYtoDiM2xU9N51URI3qY298naoOG0Q2y8dIw3oD2Huka20gNhsz7j 8EurUGhgfj8u/JuYV5q/1hSoaaD89+T4NJ8GYYaAcp1K6lltUruB1h0ls/2ZR3bkPhbV GVdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s17si4737772pfu.221.2021.10.14.06.30.52; Thu, 14 Oct 2021 06:31:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231698AbhJNN2a (ORCPT + 99 others); Thu, 14 Oct 2021 09:28:30 -0400 Received: from mga14.intel.com ([192.55.52.115]:48478 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231357AbhJNN2W (ORCPT ); Thu, 14 Oct 2021 09:28:22 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="227957952" X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="227957952" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 06:26:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="442802411" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 14 Oct 2021 06:26:14 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1A5575EA; Thu, 14 Oct 2021 16:26:20 +0300 (EEST) From: Andy Shevchenko To: Ulf Hansson , Eric Biggers , Adrian Hunter , Raul E Rangel , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: [PATCH v3 5/5] mmc: sdhci-pci: Remove dead code (rst_n_gpio et al) Date: Thu, 14 Oct 2021 16:26:13 +0300 Message-Id: <20211014132613.27861-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211014132613.27861-1-andriy.shevchenko@linux.intel.com> References: <20211014132613.27861-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no user of this member. Remove the dead code for good. The removal is dependent on the previous removal of the struct sdhci_pci_data. Signed-off-by: Andy Shevchenko Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-pci-core.c | 27 --------------------------- drivers/mmc/host/sdhci-pci.h | 2 -- 2 files changed, 29 deletions(-) diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c index e2b6f60e9f01..6f9877546830 100644 --- a/drivers/mmc/host/sdhci-pci-core.c +++ b/drivers/mmc/host/sdhci-pci-core.c @@ -1915,21 +1915,6 @@ int sdhci_pci_enable_dma(struct sdhci_host *host) return 0; } -static void sdhci_pci_gpio_hw_reset(struct sdhci_host *host) -{ - struct sdhci_pci_slot *slot = sdhci_priv(host); - int rst_n_gpio = slot->rst_n_gpio; - - if (!gpio_is_valid(rst_n_gpio)) - return; - gpio_set_value_cansleep(rst_n_gpio, 0); - /* For eMMC, minimum is 1us but give it 10us for good measure */ - udelay(10); - gpio_set_value_cansleep(rst_n_gpio, 1); - /* For eMMC, minimum is 200us but give it 300us for good measure */ - usleep_range(300, 1000); -} - static void sdhci_pci_hw_reset(struct sdhci_host *host) { struct sdhci_pci_slot *slot = sdhci_priv(host); @@ -2060,7 +2045,6 @@ static struct sdhci_pci_slot *sdhci_pci_probe_slot( slot->chip = chip; slot->host = host; - slot->rst_n_gpio = -EINVAL; slot->cd_idx = -1; host->hw_name = "PCI"; @@ -2086,17 +2070,6 @@ static struct sdhci_pci_slot *sdhci_pci_probe_slot( goto cleanup; } - if (gpio_is_valid(slot->rst_n_gpio)) { - if (!devm_gpio_request(&pdev->dev, slot->rst_n_gpio, "eMMC_reset")) { - gpio_direction_output(slot->rst_n_gpio, 1); - slot->host->mmc->caps |= MMC_CAP_HW_RESET; - slot->hw_reset = sdhci_pci_gpio_hw_reset; - } else { - dev_warn(&pdev->dev, "failed to request rst_n_gpio\n"); - slot->rst_n_gpio = -EINVAL; - } - } - host->mmc->pm_caps = MMC_PM_KEEP_POWER; host->mmc->slotno = slotno; host->mmc->caps2 |= MMC_CAP2_NO_PRESCAN_POWERUP; diff --git a/drivers/mmc/host/sdhci-pci.h b/drivers/mmc/host/sdhci-pci.h index 8bb3b9c78589..5e3193278ff9 100644 --- a/drivers/mmc/host/sdhci-pci.h +++ b/drivers/mmc/host/sdhci-pci.h @@ -157,8 +157,6 @@ struct sdhci_pci_slot { struct sdhci_pci_chip *chip; struct sdhci_host *host; - int rst_n_gpio; - int cd_idx; bool cd_override_level; -- 2.33.0