Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 1/3] soc: samsung: exynos-chipid: Pass revision reg
 offsets
To:     Sam Protsenko <semen.protsenko@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20211013202110.31701-1-semen.protsenko@linaro.org>
 <1cd31098-ba9d-f2e3-e34c-5bada00a2696@canonical.com>
 <CAPLW+4mtSnt8dCCtSeu-yNTR0F5ZO-hdjFjyGChi=tTWQQt85Q@mail.gmail.com>
 <dd61666c-fd1a-c152-9423-9dc6718b1626@canonical.com>
 <CAPLW+4mA64Q8t07tJ_Yi9=AHmGe2NixEmCaMP-Lj65D2TNBt+w@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Message-ID: <125ed340-cec7-5f65-c4c1-ab5162b420f6@canonical.com>
Date:   Thu, 14 Oct 2021 14:05:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <CAPLW+4mA64Q8t07tJ_Yi9=AHmGe2NixEmCaMP-Lj65D2TNBt+w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14/10/2021 14:03, Sam Protsenko wrote:
> On Thu, 14 Oct 2021 at 14:48, Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>>>
>>>> Did you test it that it produces same result? Looks not - I gave it a
>>>> try and got wrong revision.
>>>>
>>>
>>> I only have Exynos850 based board, and that has 0x0 in Revision ID
>>> register. But for v3 I'll try to emulate register value in the code
>>> and make sure that the read value does not change with patch applied.
>>
>> You should get one of Odroid boards to test it. The MC1 is fairly cheap.
>>
> 
> Will do, I see how it can be useful for further work. For this series,
> I'm pretty sure I can test all cases by emulating the read register
> values. Would it be enough? Also, if you have some time, I'd ask you
> to check v3 on your board.

Yes, it's OK. I can test it.

Best regards,
Krzysztof