Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 14 Oct 2021 07:47:53 -0500
From:   Andrew Halaney <ahalaney@redhat.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     rostedt@goodmis.org, bp@suse.de, rdunlap@infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init: Make unknown command line param message clearer
Message-ID: <20211014124753.wng5iuzluukz4val@halaneylaptop>
References: <20211013223502.96756-1-ahalaney@redhat.com>
 <20211013161259.39e88182200b7a582c0cf632@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211013161259.39e88182200b7a582c0cf632@linux-foundation.org>
Precedence: bulk

On Wed, Oct 13, 2021 at 04:12:59PM -0700, Andrew Morton wrote:
> On Wed, 13 Oct 2021 17:35:02 -0500 Andrew Halaney <ahalaney@redhat.com> wrote:
> 
> > The prior message is confusing users, which is the exact opposite of the
> > goal. If the message is being seen, one of the following situations is
> > happening:
> > 
> >  1. the param is misspelled
> >  2. the param is not valid due to the kernel configuration
> >  3. the param is intended for init but isn't after the '--'
> >     delineator on the command line
> > 
> > To make that more clear to the user, explicitly mention "kernel command
> > line" and also note that the params are still passed to user space to
> > avoid causing any alarm over params intended for init.
> > 
> > Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters")
> > Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> 
> Thanks.
> 
> BTW, I'm still sitting on your "init/main.c: silence some
> -Wunused-parameter warnings", awaiting a response to Rasmus's
> suggestion:
> https://lkml.kernel.org/r/f06b8308-645b-031b-f9c6-b92400a269aa@rasmusvillemoes.dk
> 

Whoops, that got caught in spam (along with rostedt's replies
yesterday... darn gmail). Let me add looking at that to the todo list,
thanks Andrew!