Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 14 Oct 2021 17:57:26 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Saurav Girepunje <saurav.girepunje@gmail.com>
Cc:     gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
        ross.schm.dev@gmail.com, marcocesati@gmail.com,
        insafonov@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH v3] staging: rtl8723bs: os_dep: simplify the return
 statement
Message-ID: <20211014145726.GO8429@kadam>
References: <YWhBQF4yUH0/r53A@Sauravs-MacBook-Air.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YWhBQF4yUH0/r53A@Sauravs-MacBook-Air.local>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aVSoxzq76in9uEtcKQSZ7AF4WaaQhBK6MYGNQLg9WXuKkxUp3z7R6yo97lv9?=
 =?us-ascii?Q?tMfzwPz53DH6IDsTMcHbzrpg2JjoN/BLJ79QP6s+NL6NsTUzFwVbYdXkDlPj?=
 =?us-ascii?Q?cQ52jo/OXzowk3XgRPjtJ7L+Dc4RQP97IXFD5o6eAmxd0DzoN2n7wZ4eF5q5?=
 =?us-ascii?Q?OGPUSat3Mz0rDeqVDNJzq/F8MmaFUTMFR9MuINgkk6HS9LFx/W2UHIui73Wz?=
 =?us-ascii?Q?jl4rUw16cNKy1dVOvEnBrp5Md00BYrkP/l9awfjET91qOMen8d2rxELezphV?=
 =?us-ascii?Q?R9FZvHNk1KTHxtV3m+dULn9i8VOJ6p9WEj4HYsN6sx0QjSeVU8grOwcN3LRe?=
 =?us-ascii?Q?5X2o2aa5CkQkLdz96nvwppHqK9/YdH50D/KlbTC2jw4SElaZgfJP/n0ReUK4?=
 =?us-ascii?Q?AjiiT6RNaMX7xnhZxvEpaKmmamouPltomo+GnajgqBTmECmy7QIREfY7fYgj?=
 =?us-ascii?Q?HH6K4P7YjElGi9PV7ufsZ5FdcoLICajEp2hWo0e68MZmqpVMOqs+HVikPKFd?=
 =?us-ascii?Q?duuBrkDTtqajvcZfeVjlwFWEN2njNvl2H5YL2SntxeItBUk+l9czBDtK3Len?=
 =?us-ascii?Q?PXBcnEnQGkwh2zldLrPdmWTpTCXTbW0893tQIan6zleCI+GSvFy7oadDR8Kj?=
 =?us-ascii?Q?L9jQ7uVlB2HYV467bu0s18mW5KXuqMCbz2lGapTgMZAAnCzRJMmfdLA77NBg?=
 =?us-ascii?Q?yos0tbL7Ku6753ioJuQWXCg7Smy/Z+PC1Anuqh6tRZLJ7dSPEa3oGzmfijkB?=
 =?us-ascii?Q?SopeU1ugUmQNV0eKNVLp6uiqglO5JCIvQbr4RKdk1k1RvvGtHI1I80uUSIH7?=
 =?us-ascii?Q?dyH+TrYFH5OoF9pHoGg4BkJ8aJrlZJ26lnjXR84TfrrhbTLlwY3zN1k19Zxf?=
 =?us-ascii?Q?0ff0VrpDFtMhIuDKpnFkiZ64qtofR4hh34VAE8zmf9DmiV1ZzFglVu9jtpZz?=
 =?us-ascii?Q?Ej8df5Gmv8iHTN3XNf2vKW3fe0VGWEm6JwOICFPudyNO+EkDIZgVTrwMe9T8?=
 =?us-ascii?Q?4Shan23MhHx40Nskh366M+xAZT1jVgDPP5VjzrckR8Mto9P/WrvvSJ8jPmKp?=
 =?us-ascii?Q?zbFRtbUjJXkcMo9uoCtlSFJSyf283k8dqNv+7ifYrB9AS6JQ1w2t5wD31dYo?=
 =?us-ascii?Q?E2dhHGvGe1EIkwvn+XF/pR/bPHhTRoqJudyCEl3RVB0QpJ/fV0ghiDp47opB?=
 =?us-ascii?Q?3JKk/D3P7De2O68j6e11i1g+6fqEbWQjGrY0l0GC1VPFf2ZDQiCnfljkPbGX?=
 =?us-ascii?Q?awKGo0CZyPbvzInVHsZ81zJenPWRlKxKJspGUT57OvCEAuRKGhdZozkLUP6h?=
 =?us-ascii?Q?X5I4MJJ6Okix3QVwSifzuxMF?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc9d197e-9dab-4da9-cfbf-08d98f22fbef
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 14:57:46.9962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Do8ax4IF7f0MX2+WuDzltky8ng+OvWGJFHi1vgHW4WmtSwLnSMmpUsJX5aIf/BuUYeEMY5lt3Zoov1aAUy/Usd571amp/onoQV3Ztc+dwnU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2095
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10137 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110140091
X-Proofpoint-GUID: pwFCyxArIdiajF-LktmuTTIqEXHuiU_H
X-Proofpoint-ORIG-GUID: pwFCyxArIdiajF-LktmuTTIqEXHuiU_H
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 14, 2021 at 08:10:00PM +0530, Saurav Girepunje wrote:
>  .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 29 ++++++++-----------
>  1 file changed, 12 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index 0868f56e2979..217b86bfb722 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -2281,19 +2281,16 @@ static int rtw_cfg80211_add_monitor_if(struct adapter *padapter, char *name, str
>  	struct rtw_wdev_priv *pwdev_priv = adapter_wdev_data(padapter);
> 
>  	if (!name) {
> -		ret = -EINVAL;
> -		goto out;
> +		return -EINVAL;
>  	}

You need to delete the curly braces, otherwise your patch will introduce
a checkpatch warning.  Same below as well.

regards,
dan carpenter