Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4618371pxb; Thu, 14 Oct 2021 08:40:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWmP/920UVzd4sBF8YcSd55anJcfMBDfBqE2K34RafgbsfmniCCu9/ZQ1l6D9KB4cpmod9 X-Received: by 2002:a62:60c7:0:b0:40a:4bd7:752c with SMTP id u190-20020a6260c7000000b0040a4bd7752cmr6090222pfb.52.1634226059101; Thu, 14 Oct 2021 08:40:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634226059; cv=none; d=google.com; s=arc-20160816; b=hWzqX6fYI1p6R2ofK6PvAVCuL71u3j/eUfmnRhECfguCFQosvEzJFx0NOWaAFXJQkk NQ6O5TrnJcALgupIG9ZLqNMaHDRjOoff39mSvRbt9nm3KzI5DYsHGa7PL2JGEbNsiI+h SKc/Kdp71S1I4ymrOpch3CIBNAJKLC94eASZhTWNd3ga+m7M93aiDHQHdVkQqGX5b1PI g6xpS8X+/Ho8FKkKlGaMysSNTSGLPEbVn90NXafgvTofHj8Y97zXkul4nuTm8PgOtSwP lqd4clv21Itayl6RYOf+J02aqhFKIvXP7ufgqQnYG0j/NGRDp2D+8LwWDoXP50ukocUl CZHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4UDSRZNLbujPIMgHpMxdcCEUXw1BBdhLqNoRmR+wHFg=; b=WyMxxvqOj9wB8iC62RAbB0p005lPYFKE8C7SBfnOFe1FU/YIdBaqC0JY/EYjubsk5z +IxSQjHKWH2Tv3M2c9lbCE6E2/TA+HUf/yKpFFnGSE34Y9eGntrU3IgXleUeb635isQm O7YaUtVhCiNutIxeZvS7E14zr9SyCR23Orfvv9sDNADuezCqiGRrKiwpqGxulCVqR61U nsS5z2QjwfhfTbzmIjaRKt9bWEm+oYlh6n8JYovuCN8sUp5bM2xxwkDnLP2OzP9zmPtZ 0WWxwgA7Akl/D171SMcNsIRSdcYqtCDWCl8YSV3JlymyGSyoWWUV4UlFOs/JxdZwO6Va PaaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=iLtR1bF1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mh4si16316144pjb.115.2021.10.14.08.40.46; Thu, 14 Oct 2021 08:40:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=iLtR1bF1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231168AbhJNO3Q (ORCPT + 99 others); Thu, 14 Oct 2021 10:29:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229953AbhJNO3P (ORCPT ); Thu, 14 Oct 2021 10:29:15 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1690BC061570 for ; Thu, 14 Oct 2021 07:27:11 -0700 (PDT) Received: from zn.tnic (p200300ec2f0c72008718c38cc37e4684.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:7200:8718:c38c:c37e:4684]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4931E1EC04B9; Thu, 14 Oct 2021 16:27:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1634221629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4UDSRZNLbujPIMgHpMxdcCEUXw1BBdhLqNoRmR+wHFg=; b=iLtR1bF1mRNcV6+xUyanug+PaG/VCmB6cg7pXYslKB4NcVnLGe8/5pdmacz63+hrZcc3vc iD6dldpHkzBhetlsMYE169aKDJciVwbTtlSzpljTpfq3tmQMAurJ+aiwisyvcu1fbKz6Ol mG6/SX2zFHDllWBhsIENM0DIypeNHYQ= Date: Thu, 14 Oct 2021 16:27:07 +0200 From: Borislav Petkov To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Ser Olmy , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [regression] commit d298b03506d3 ("x86/fpu: Restore the masking out of reserved MXCSR bits") Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 14, 2021 at 02:44:33PM +0300, Ville Syrjälä wrote: > I have a 32bit installation here that stopped working. Bisected it > to commit d298b03506d3 ("x86/fpu: Restore the masking out of reserved > MXCSR bits"). Lemme make sure I understand this correctly: this patch is bad and with it reverted it works? Because before this patch, the restoring would be a more restrictive than before and this patch reverts the code to the old behavior for invalid MXCSR bits. > Tested the same disk on on both a 64bit capable Pentium D > and a 32bit only Pentium 4 just to rule out the specific CPU. > Busted on both. So that's a purely 32-bit installation and a 32-bit kernel and you've booted it on two different machines? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette