Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a2964246-f90f-f205-ce99-707cc1a114cc@kernel.org>
Date:   Thu, 14 Oct 2021 16:55:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Subject: Re: [PATCH] input&tty: Fix the keyboard led light display problem
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        lianzhi chang <changlianzhi@uniontech.com>
Cc:     linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
        gregkh@linuxfoundation.org, linux-input@vger.kernel.org,
        282827961@qq.com
References: <20211014071627.23256-1-changlianzhi@uniontech.com>
 <YWhI/DzNjivU6jQ6@smile.fi.intel.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <YWhI/DzNjivU6jQ6@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14. 10. 21, 17:13, Andy Shevchenko wrote:
> On Thu, Oct 14, 2021 at 03:16:27PM +0800, lianzhi chang wrote:
>> Switching from the desktop environment to the tty environment,
>> the state of the keyboard led lights and the state of the keyboard
>> lock are inconsistent. This is because the attribute kb->kbdmode
>> of the tty bound in the desktop environment (xorg) is set to
>> VC_OFF, which causes the ledstate and kb->ledflagstate
>> values of the bound tty to always be 0, which causes the switch
>> from the desktop When to the tty environment, the LED light
>> status is inconsistent with the keyboard lock status.
> 
> ...
> 
>> +void update_value_ledstate(unsigned int flag, unsigned int value)
>> +{
>> +	unsigned int bit;
> 
> unsigned long bit;
> 
> (see below why)

You'd need ledstate to be ulong, not bit. Or am I missing something?

-- 
js