Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4805153pxb; Thu, 14 Oct 2021 12:18:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxv/yPsLYTQcK4+z7DdA7wJsc33zIoth0tZWvAnrEitI5UrIOSMIrYFjcuxCiqkVy2ANX5t X-Received: by 2002:a17:902:6808:b0:13e:a85b:52bd with SMTP id h8-20020a170902680800b0013ea85b52bdmr6541303plk.76.1634239109409; Thu, 14 Oct 2021 12:18:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634239109; cv=none; d=google.com; s=arc-20160816; b=fbdLCFL/jqThfUfqXK4eE1nsJY9u2cVFGNzavFR7vuzdqQcsh3u4e6NtuTjrJv4/mq bU4Xlq+pDaE9UBezCIhlalBapMUe+aSAbvF+vKRb34k/EnMijVMPProWH+EmHmBXWFtb L+7qjvpnq1BSvaw7qXWo2/6wBiOXVqOsaxuBDLDeap2Equ0MN28HYsyiENpVoyF8U84p TTSd21o0855tqRNlr7xPMt78VqdC6GVbvSp7cu/DR7lUjFDX4RmL5ZjiPTzX8YoXL2p9 hPUPgyEOTvSchWg8MmNJjmwtx9if9A1PEQNWOJs5Q+grBg5YbDtiPHnu/MtXsJvVT4n3 rV+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zJB8zVukIQ+/02Rc0y98q23z81gJRt8QzQtT1HzSbCg=; b=IAGXsg4zv21S3NU11NT3g8Kat0pPqhfZmHFyIAtKCvLbPp9sPZsE7YX/y3A5/Xs8Hg 2l6kTCJwLMNmaNB5Qb+1jQuG6huIb5AkJfX2uAO2/8tVEylA9hLVD3ZDC2wqkvWvuAtW YMNuewDVstzWV/QAQ8E1pFMVpfSshZV5mKUmsXhb3hilShuXLf13fP7FasVpNaX9HrQe IKmEQNOp3Du3GWitg7RMFUNu6eZXhiDYeQeZA1fzBqKQME0iWJvxqqHLyYQk9c8ij9Gx MM6h0MLInOKSjSAktknIM/UxNzVdb52xtkeUsxhKZnXQul2Zksn2zvOmmT6K0KQi+tXB qZvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=ELuQkXd9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a11si6335476plh.292.2021.10.14.12.18.16; Thu, 14 Oct 2021 12:18:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=ELuQkXd9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231573AbhJNRz5 (ORCPT + 99 others); Thu, 14 Oct 2021 13:55:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232212AbhJNRz4 (ORCPT ); Thu, 14 Oct 2021 13:55:56 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF8A3C061570 for ; Thu, 14 Oct 2021 10:53:51 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id z3so4198458qvl.9 for ; Thu, 14 Oct 2021 10:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zJB8zVukIQ+/02Rc0y98q23z81gJRt8QzQtT1HzSbCg=; b=ELuQkXd9ubC+OOcBV7fXc70bOKtTagxKSxoApRUZ/4BsKndSk0l6tVMuHdx9fGF8zH GORoT66pFq9wl8kI1VG/IbM0ZkQtbmbFy28q5ZyHmlwRLBj6NWqSXekY1Otqk933Qbv7 ZzzvXg8ECuwL+T68M4ziC52MUIzd1A/c3vjxaTKvNjOdZKbK5kJbRJOctsmBzxNUL/YD 1THlLPXxUs/+yF6XR1swIr/l3cprEL6aLrnPAQw8H4lRzMDB8F20ARkbeGD9svke4yjt Whnosw86G4eJkcVRzBte5sAgcWStb1FwWIYYSpxBMgiIP2ZHEgXw9eYXD0AKGy59C/HR pa9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zJB8zVukIQ+/02Rc0y98q23z81gJRt8QzQtT1HzSbCg=; b=6CYXrOj4eMgKimDI9dESOjvrHZau0sOXlcfHWmhqa9vWVsTOjqL3Tl1H/0FeqSrIQf qZnkOUcUNS4VJK+nauTAaZ8MXHIN4GMvpBnNcBbONVJ6VlEQgnsRZi9g8BgIJhzIWAqI g0GzTeVLOytkbFxGuK3SuJNh7qy8kNzHZpymXG+z5kbB/NglaFEe2mbR3u62L7PunOlg t6vdzAhW2TjU9YSUUCAXrSv8ZkZ9MVVnEFcbRinLVwVR5iORQpEue6bHoIy3H2h9PP3Q 7jN2dEEUM9geHZ2vreLXUXnSVJw3L1+dPp0DQxYNgHOia7i9/mQt1/byhWcvJA/UeAe6 Y+hA== X-Gm-Message-State: AOAM530k5up6bP1SzJHkPxlrky/bSjY1xWga05+8uaNVZs1AjvEvxg8f zCAYZ3qQcYOjlR9/dinV/fmccHcZPo4= X-Received: by 2002:a0c:e885:: with SMTP id b5mr6594010qvo.18.1634234031011; Thu, 14 Oct 2021 10:53:51 -0700 (PDT) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id l3sm896707qkj.18.2021.10.14.10.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 10:53:50 -0700 (PDT) Date: Thu, 14 Oct 2021 13:53:49 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Michal Hocko , Mel Gorman , Uladzislau Rezki , Vasily Averin , Roman Gushchin , Matthew Wilcox , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT Message-ID: References: <20211014151607.2171970-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211014151607.2171970-1-shakeelb@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 14, 2021 at 08:16:07AM -0700, Shakeel Butt wrote: > The commit 5c1f4e690eec ("mm/vmalloc: switch to bulk allocator in > __vmalloc_area_node()") switched to bulk page allocator for order 0 > allocation backing vmalloc. However bulk page allocator does not support > __GFP_ACCOUNT allocations and there are several users of > kvmalloc(__GFP_ACCOUNT). > > For now make __GFP_ACCOUNT allocations bypass bulk page allocator. In > future if there is workload that can be significantly improved with the > bulk page allocator with __GFP_ACCCOUNT support, we can revisit the > decision. > > Fixes: 5c1f4e690eec ("mm/vmalloc: switch to bulk allocator in __vmalloc_area_node()") > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner