Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4850721pxb; Thu, 14 Oct 2021 13:17:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTMs9LxM4gsDj6tyWr6Fi2cbcmYu7hZD83yG8dLQdJPm8U+rYMgMFn/X9pw3x/g1joHezh X-Received: by 2002:a17:902:9303:b029:12c:29c:43f9 with SMTP id bc3-20020a1709029303b029012c029c43f9mr6974013plb.5.1634242635376; Thu, 14 Oct 2021 13:17:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634242635; cv=none; d=google.com; s=arc-20160816; b=vJWPBXRxv5taSIxvu+DiE7fMMlRrXqkkVTIKQfQn/5xqtYm/REr2/zIc09GV8B3og9 mEMMRA/NClqKLJeI/KYIIVK5zIqpFI6Lync27+cE9sLGE1cbw8f2ShwbcUnQ9WrwP+Cb Vjj9582naEarpq+CQneSDG0SWCXzewnhYCTnkpFp60dO1IrOVgKK7mBU6qzOmljyabaj +cPMuN2yCHVwH1MJPlHHOOCicnW+IlFoXZAPyNo8ejI0SXJEPJslxfZD98kWQemT3MmM cCCENJyuaTgUunKKa9ppF8zhOCtEti2j2IkHCz7K12vQsXBt0bk9MYLA7olN+YXhiyHW 5dZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=By52BGa835IE4lyaZQwwtW5rAiE3tQH6DwCoYXbpm9E=; b=Khwj+eOdKO7IsRRsYCHKHoZqRKh2LM85oJe1mxkmWXT3ngi/g4X6zngRyNWcvjDFNy 9Cy2VJOwoQ84PXrasfG/BJrNXUIYUwnfu3HnffgFj6MTI/BUsOtBj0sW2qQR1DW2Olal ezStVmTNPNKeDal1c97mMm11Dev8K4kvIkRNuIdI9+d4Q0vw0Eq5BouuH6lNE6ktBh/i esP3EPZ1GmiVca91Vm5DTrJgXCNRaldqlAyaVacVMX4U6qYM/jI+Jpq+LbbNBetC19yv tve/vQCtGZXYmE5T+z+XFFSBXdv/xf47EPC4n/+5kkjfq2vqUx/ZprogXIdh8GNALuhc qt8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=acZGhTze; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mu4si16920403pjb.174.2021.10.14.13.17.01; Thu, 14 Oct 2021 13:17:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=acZGhTze; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231708AbhJNPZo (ORCPT + 99 others); Thu, 14 Oct 2021 11:25:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231867AbhJNPZo (ORCPT ); Thu, 14 Oct 2021 11:25:44 -0400 Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38D63C061753 for ; Thu, 14 Oct 2021 08:23:39 -0700 (PDT) Received: by mail-qt1-x82a.google.com with SMTP id b12so6096254qtq.3 for ; Thu, 14 Oct 2021 08:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=By52BGa835IE4lyaZQwwtW5rAiE3tQH6DwCoYXbpm9E=; b=acZGhTzeICP5dR16o7d44zA806wjXfAFaH1u+XIyklzn3XApXetVdZA3xTVlo6FV5W 7mhpqHdrKn7qQG7YCGWrsqMSJ/LTR/sUkidAix1OyA/T5a0UqzOy5hF3mNNla4ltmNFv Oay9ZIvxwsHCCOhe7oxdDn96wZcPm2/8GRVyNXK3Tsya2KnW4E7zPJ8qnAmCU+MNu/ve HLuf6dKzLLJhCV4MCVolKpTi/TjWPmfzTh0oahUwDKa7TbJkhez4zxc3/dtIjbEd9/lt Hx+Gx9w2Nxx8DFDInfXyLREY1KDQ3Irf/QLYT1oM84jVfQXe/4exZYV8UPDJWWWD9OtT spzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=By52BGa835IE4lyaZQwwtW5rAiE3tQH6DwCoYXbpm9E=; b=b/MS5hNTsTRzTGzcrH7MjfWKUHh7Tgtxnqpx81GK8U5O3UEAyVMt/CR359xgc7p/aU 84JoX+eyKKZWYt5NrD7vtmdcjiNsQSvnWRIRlpIhe0V4kSwWQ1X6X587TivMPtenuRh3 PyMxWFzfjLGhCSCqIZXCUnq9YROOdRDQnomAYrmqoOyeb7jrQlrhB/hn0IcTjKscxI5E QarU1agSkf7EPf/fVd/Sd46dntYV3TRqqsc7hbXOXZu1y3sG30cVhlQ5eQEWvsOXY4De D1/b9Rzbb28MFGU8i2FP6202wKVabrwIix8c5V3umg9qiJoXpfhpe+gGE8ZTNTBwMkHA /1ug== X-Gm-Message-State: AOAM533wmESrV5fMXt8X6+yFXDcPMX+GsvOM/SG5nMVPu/EewkZ9qK7q iiZFSPPT5EI9fpSNKX+adSuVGg== X-Received: by 2002:a05:622a:88:: with SMTP id o8mr7363114qtw.244.1634225018371; Thu, 14 Oct 2021 08:23:38 -0700 (PDT) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id 201sm1430966qkm.34.2021.10.14.08.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 08:23:37 -0700 (PDT) Date: Thu, 14 Oct 2021 11:23:36 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Michal Hocko , Mel Gorman , Uladzislau Rezki , Vasily Averin , Roman Gushchin , Andrew Morton , Cgroups , Linux MM , LKML Subject: Re: [PATCH] memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT Message-ID: References: <20211013194338.1804247-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 14, 2021 at 08:01:16AM -0700, Shakeel Butt wrote: > Regarding xfs_buf_alloc_pages(), it is not using __GFP_ACCOUNT It probably should, actually. Sorry, somewhat off-topic, but we've seen this consume quite large amounts of memory. __GFP_ACCOUNT and vmstat tracking seems overdue for this one.