Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 14 Oct 2021 13:25:43 -0500
From:   Rob Herring <robh@kernel.org>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
Cc:     kishon@ti.com, vkoul@kernel.org, linux@armlinux.org.uk,
        andrew@lunn.ch, alexandre.belloni@bootlin.com,
        linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: phy: Add binding includes for
 lan966x serdes
Message-ID: <YWh2J32hZftzIi+F@robh.at.kernel.org>
References: <20211006063523.3962427-1-horatiu.vultur@microchip.com>
 <20211006063523.3962427-3-horatiu.vultur@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211006063523.3962427-3-horatiu.vultur@microchip.com>
Precedence: bulk

On Wed, Oct 06, 2021 at 08:35:22AM +0200, Horatiu Vultur wrote:
> Add include bindings for lan966x serdes
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  include/dt-bindings/phy/lan966x_serdes.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 include/dt-bindings/phy/lan966x_serdes.h
> 
> diff --git a/include/dt-bindings/phy/lan966x_serdes.h b/include/dt-bindings/phy/lan966x_serdes.h
> new file mode 100644
> index 000000000000..06e529473475
> --- /dev/null
> +++ b/include/dt-bindings/phy/lan966x_serdes.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> +
> +#ifndef __LAN966X_SERDES_H__
> +#define __LAN966X_SERDES_H__
> +
> +#define CU(x)		(x)
> +#define CU_MAX		CU(2)
> +#define SERDES6G(x)	(CU_MAX + 1 + (x))
> +#define SERDES6G_MAX	SERDES6G(3)
> +#define RG(x)		(SERDES6G_MAX + 1 + (x))
> +#define RG_MAX		RG(2)
> +#define SERDES_MAX	(RG_MAX + 1)

I'm guessing these are used for the phy cells? If so, I can't figure out 
how and I shouldn't have to search the driver to figure it out.

What's CU? What's RG?