Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH V1] firmware: tegra: fix error application of sizeof to
 pointer
From:   Jon Hunter <jonathanh@nvidia.com>
To:     <cgel.zte@gmail.com>, <thierry.reding@gmail.com>, <arnd@arndb.de>
CC:     <lv.ruyi@zte.com.cn>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Zeal Robot <zealci@zte.com.cn>
References: <20211009085900.509697-1-lv.ruyi@zte.com.cn>
 <10dd0afe-432e-4798-1680-3edbd2b07bcb@nvidia.com>
Message-ID: <32c183a5-01bb-f86a-a614-ea46ad405de1@nvidia.com>
Date:   Thu, 14 Oct 2021 19:31:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <10dd0afe-432e-4798-1680-3edbd2b07bcb@nvidia.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 18:31:29.0593
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ad8ff414-e1d9-400c-e7ac-08d98f40d6a7
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT029.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0022
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/10/2021 19:26, Jon Hunter wrote:
> Hi Lv,
> 
> On 09/10/2021 09:59, cgel.zte@gmail.com wrote:
>> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>>
>> Application of sizeof to pointer yields the number of bytes of the 
>> pointer,
>> but it should use the length of buffer in the code.
>>
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
>> ---
>>   drivers/firmware/tegra/bpmp-debugfs.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/firmware/tegra/bpmp-debugfs.c 
>> b/drivers/firmware/tegra/bpmp-debugfs.c
>> index 6d66fe03fb6a..fd89899aeeed 100644
>> --- a/drivers/firmware/tegra/bpmp-debugfs.c
>> +++ b/drivers/firmware/tegra/bpmp-debugfs.c
>> @@ -77,13 +77,14 @@ static const char *get_filename(struct tegra_bpmp 
>> *bpmp,
>>       const char *root_path, *filename = NULL;
>>       char *root_path_buf;
>>       size_t root_len;
>> +    size_t root_path_buf_len = 512;
>> -    root_path_buf = kzalloc(512, GFP_KERNEL);
>> +    root_path_buf = kzalloc(root_path_buf_len, GFP_KERNEL);
>>       if (!root_path_buf)
>>           goto out;
>>       root_path = dentry_path(bpmp->debugfs_mirror, root_path_buf,
>> -                sizeof(root_path_buf));
>> +                root_path_buf_len);
>>       if (IS_ERR(root_path))
>>           goto out;
>>
> 
> Thanks for fixing this! I just noticed that the debugfs for BPMP is 
> broken on -next right now and this fixes it. We should add the fixes tag 
> ...
> 
> Fixes: 06c2d9a078ab ("firmware: tegra: Reduce stack usage")
> 
> Otherwise ...
> 
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> Tested-by: Jon Hunter <jonathanh@nvidia.com>
> 
> Arnd, do you want to pick this up?

Nevermind I see that Thierry queued up the offending patch and so I will 
ask Thierry to pick this up.

Jon

-- 
nvpublic