Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4973315pxb; Thu, 14 Oct 2021 16:09:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyq5cf8sYcB4XcHU2UzFMniJM4f0AJy+RblGWLxDd5gaH4xU99Y6R50TVwKflCga32vw6N/ X-Received: by 2002:a17:90a:4:: with SMTP id 4mr9161531pja.221.1634252967165; Thu, 14 Oct 2021 16:09:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634252967; cv=none; d=google.com; s=arc-20160816; b=loXJ0IoedUkVKDy/Y1whd9LUEHXVc0JmbofUI5//qOaZijH3qmzsSzny4PHmWmSEA3 TcvUoVdzBxDG0/hpJqox3bCcCYPbt3yi8LPzRuXrYvMolcpLc1r3E/mfyBFNg7KzcCs8 Jai1V3dOryAIPQWc/oI45HDPtlWcdjEqIPJo+TByElAx5ZASYnE1OGKFjWwxsmMJzDqO B6Nm7yOcbOyqqwSJLka41ZmwbxI/Wg5AVT+5t8pgo+CtDetODwxwb92xBVfySiA9MZgN MIHiiJCsMQt3T40e8mDqz6TPghOjaU5ib9uRN5khaXdtx7E2FDuYrAWeydfVMftLhwPB ZTaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=QRkv4elV61kBAnd3thuI0wHoR+mEFkVs4HEzbYRK1C0=; b=yNWHQirwHZLQxHeNOOtfyAoMSoZ5CbKMoc0uH2Iz9gkIXCKrxlekvAnYAY98FYfDn9 WwS0sAlMHmVEU9mUnGd+3t3FFO78z2tniUYbPNxML98C0cp0VE9WJXUEgaHjp1OZsBH9 wEBNUt5m6WgwNiPaJpkHFYTD7xqNdB048pY4U5RQ+QAVkh3VHUjAjaOdITPwK/mCJIAL sYTr1jbBvlgd3emprW+cRmKP2IVhZWL3I7hXb06G6QeVAUIfhrV+nFaqUDL3hbMXt+AN 5Kp2plYCnaodOONXOMn+PjDrcmrmFas6YWRsJOCv5qo4tDsGi3D5dpGmt6sHTa49h513 53kA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v10si843081plp.24.2021.10.14.16.09.14; Thu, 14 Oct 2021 16:09:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233958AbhJNSjK (ORCPT + 99 others); Thu, 14 Oct 2021 14:39:10 -0400 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:63113 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231529AbhJNSjK (ORCPT ); Thu, 14 Oct 2021 14:39:10 -0400 Received: from pop-os.home ([92.140.161.106]) by smtp.orange.fr with ESMTPA id b5bCmBF2MBazob5bDmY8O8; Thu, 14 Oct 2021 20:37:04 +0200 X-ME-Helo: pop-os.home X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Thu, 14 Oct 2021 20:37:04 +0200 X-ME-IP: 92.140.161.106 From: Christophe JAILLET To: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] xen/pvcalls-back: Remove redundant 'flush_workqueue()' calls Date: Thu, 14 Oct 2021 20:37:01 +0200 Message-Id: <2d6c2e031e4aa2acf2ac4e0bbbc17cfdcc8dbee2.1634236560.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workqueue(E); Signed-off-by: Christophe JAILLET --- drivers/xen/pvcalls-back.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c index b47fd8435061..d6f945fd4147 100644 --- a/drivers/xen/pvcalls-back.c +++ b/drivers/xen/pvcalls-back.c @@ -465,7 +465,6 @@ static int pvcalls_back_release_passive(struct xenbus_device *dev, write_unlock_bh(&mappass->sock->sk->sk_callback_lock); } sock_release(mappass->sock); - flush_workqueue(mappass->wq); destroy_workqueue(mappass->wq); kfree(mappass); -- 2.30.2