Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4980154pxb; Thu, 14 Oct 2021 16:18:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzONbJYYHK46y7ds7Zr9ru3WmGHfxfK9AjbhkAsacpsuowgJuk1qCIdcGvSZbOHFQYnW72 X-Received: by 2002:a62:1704:0:b0:44c:5066:47 with SMTP id 4-20020a621704000000b0044c50660047mr7855094pfx.18.1634253539611; Thu, 14 Oct 2021 16:18:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634253539; cv=none; d=google.com; s=arc-20160816; b=A/dqwc5jvPbQACXKW6lHctTWdtgKzNKhKp3sWwUTXc66TTgtNfTRWIpKist2DYoMqh 1Mu3QJN2nWzZjZtjso/QC+16M1ZdA8pYg+0XZwGQd1EwzQ20RyYvdCKDYT5yBomoFF25 UTelWK8O3jTEGmfHBkoyZ2P0y03vIbT0gtHtZLAUVSaXiJ1el3sAc244WKU9QH24opAp WpgB1rMlnxikr3619AsqjX0u3SU7a/KNc0/beKFfW6Dh7LPuOMG29V/+0RAC1iwrZ+oW za2/lkHvUtsH88RyPKpE4col/8CmfURMauDn6fo6boxA3fo2tZOZAgtHP12N31V09rGe 7IBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZJWeI237I8vJJhqiJWMB6c2JMjtxXJ/9AbonOkMBp6s=; b=PDU4oIg/NNGHwH0zKlNepxvE0mmfLhJgLW8VZJ1o6Kvx01+KYgF++szdriRQuVhV9/ 23+bFQsdn2tX01ZNEA3qOTfwJCH+NPFXVUJFjvgD1dI+QYH8Z3jyPq9BjAjqeqYnrWAf stcnCJJfjRU12IJiXOc1zHIunjgA3Jsdezskwx8BfMh9FN7muR2ekX0uCHHkQ2Xu4ytQ xs2WOJtj2KtMoOaWSB+/x8Qe5qhrMgXKzU59yJIzoObvWCIJzM0cHRwGNCewnAn9cLG0 sUptvJzkNH4GZwZQlIdilR/q/pFG229gn7c6KOCH9ndVyG3V8RgNuBMoEPaW2g1C4QHa Y5RA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZUnPH2PV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s13si4887523plq.286.2021.10.14.16.18.45; Thu, 14 Oct 2021 16:18:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZUnPH2PV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231340AbhJNSmQ (ORCPT + 99 others); Thu, 14 Oct 2021 14:42:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28640 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233982AbhJNSmM (ORCPT ); Thu, 14 Oct 2021 14:42:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634236806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZJWeI237I8vJJhqiJWMB6c2JMjtxXJ/9AbonOkMBp6s=; b=ZUnPH2PVgIU9SVI/d5aHOYR461aliqV2Zt06vql+E+DgBkztGW/lx2i4CAZ3wfiHYsLZC8 vTIt4/OdYqL9/5OFpfKn52v0hzG877rmzmog96wdCrso2yzZrF+prUEszp6rxMhblG4LVt upmGw3c902S+Wfo9Qiz8wT+BAO/UM0o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-516-3FPBGYrzPP2tjFPWdQCfmQ-1; Thu, 14 Oct 2021 14:40:02 -0400 X-MC-Unique: 3FPBGYrzPP2tjFPWdQCfmQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 373491006AA2; Thu, 14 Oct 2021 18:40:00 +0000 (UTC) Received: from x1.localdomain (unknown [10.39.192.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C39A60583; Thu, 14 Oct 2021 18:39:57 +0000 (UTC) From: Hans de Goede To: "Rafael J . Wysocki" , Mika Westerberg , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , Myron Stowe , Juha-Pekka Heikkila , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" Cc: Hans de Goede , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" Subject: [PATCH v5 2/2] x86/PCI/ACPI: Replace printk calls with pr_info/pr_warn calls Date: Thu, 14 Oct 2021 20:39:43 +0200 Message-Id: <20211014183943.27717-3-hdegoede@redhat.com> In-Reply-To: <20211014183943.27717-1-hdegoede@redhat.com> References: <20211014183943.27717-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The direct use of printk is deprecated, replace the printk calls in arch/x86/pci/acpi.c with pr_info/pr_warn calls. Acked-by: Rafael J. Wysocki Signed-off-by: Hans de Goede --- Changes in v5: - Rebase on v5 of: "x86/PCI: Ignore E820 reservations for bridge windows on newer systems" and send it out as part of a series instead of as a stand-alone patch - Add Rafael's Acked-by --- arch/x86/pci/acpi.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c index 72d473054262..f357dac92610 100644 --- a/arch/x86/pci/acpi.c +++ b/arch/x86/pci/acpi.c @@ -1,4 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 + +#define pr_fmt(fmt) "PCI: " fmt + #include #include #include @@ -38,7 +41,7 @@ static int __init set_nouse_crs(const struct dmi_system_id *id) static int __init set_ignore_seg(const struct dmi_system_id *id) { - printk(KERN_INFO "PCI: %s detected: ignoring ACPI _SEG\n", id->ident); + pr_info("%s detected: ignoring ACPI _SEG\n", id->ident); pci_ignore_seg = true; return 0; } @@ -158,10 +161,9 @@ void __init pci_acpi_crs_quirks(void) else if (pci_probe & PCI_USE__CRS) pci_use_crs = true; - printk(KERN_INFO "PCI: %s host bridge windows from ACPI; " - "if necessary, use \"pci=%s\" and report a bug\n", - pci_use_crs ? "Using" : "Ignoring", - pci_use_crs ? "nocrs" : "use_crs"); + pr_info("%s host bridge windows from ACPI; if necessary, use \"pci=%s\" and report a bug\n", + pci_use_crs ? "Using" : "Ignoring", + pci_use_crs ? "nocrs" : "use_crs"); /* * Some BIOS-es contain a bug where they add addresses which map to @@ -186,8 +188,8 @@ void __init pci_acpi_crs_quirks(void) else if (pci_probe & PCI_USE_E820) pci_use_e820 = true; - printk(KERN_INFO "PCI: %s E820 reservations for host bridge windows\n", - pci_use_e820 ? "Using" : "Ignoring"); + pr_info("%s E820 reservations for host bridge windows\n", + pci_use_e820 ? "Using" : "Ignoring"); } #ifdef CONFIG_PCI_MMCONFIG @@ -362,9 +364,8 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root) root->segment = domain = 0; if (domain && !pci_domains_supported) { - printk(KERN_WARNING "pci_bus %04x:%02x: " - "ignored (multiple domains not supported)\n", - domain, busnum); + pr_warn("pci_bus %04x:%02x: ignored (multiple domains not supported)\n", + domain, busnum); return NULL; } @@ -432,7 +433,7 @@ int __init pci_acpi_init(void) if (acpi_noirq) return -ENODEV; - printk(KERN_INFO "PCI: Using ACPI for IRQ routing\n"); + pr_info("Using ACPI for IRQ routing\n"); acpi_irq_penalty_init(); pcibios_enable_irq = acpi_pci_irq_enable; pcibios_disable_irq = acpi_pci_irq_disable; @@ -444,7 +445,7 @@ int __init pci_acpi_init(void) * also do it here in case there are still broken drivers that * don't use pci_enable_device(). */ - printk(KERN_INFO "PCI: Routing PCI interrupts for all devices because \"pci=routeirq\" specified\n"); + pr_info("Routing PCI interrupts for all devices because \"pci=routeirq\" specified\n"); for_each_pci_dev(dev) acpi_pci_irq_enable(dev); } -- 2.31.1