Message-ID: <4591C230.3070705@gmail.com>
Date: Wed, 27 Dec 2006 01:45:36 +0100
From: Rene Herman <rene.herman@gmail.com>
User-Agent: Thunderbird 1.5.0.9 (X11/20061206)
MIME-Version: 1.0
To: Rusty Russell <rusty@rustcorp.com.au>
CC: Zachary Amsden <zach@vmware.com>, Andrew Morton <akpm@osdl.org>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] romsignature/checksum cleanup
References: <458EEDF7.4000200@gmail.com>  <458F20FB.7040900@gmail.com> <1167179512.16175.4.camel@localhost.localdomain>
In-Reply-To: <1167179512.16175.4.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 801
Lines: 22

Rusty Russell wrote:

> On Mon, 2006-12-25 at 01:53 +0100, Rene Herman wrote:

>> Hmm, by the way, if romsignature() needs this probe_kernel_address() 
>> thing, why doesn't romchecksum()?
> 
> I assume it's all in the same page, but CC'ing Zach is easier than
> reading the code 8)

If we're talking hardware pages here; the romchecksum() might be done 
over an area upto 0xff x 512 = 130560 bytes (there's also an acces to 
the length byte at rom[2] in probe_roms(). I assume that one's okay if 
romsignature() ensured that the first page is in).

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/