Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 1/6] dt-bindings: clock: sunxi: Export CLK_DRAM for
 devfreq
To:     Samuel Holland <samuel@sholland.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Maxime Ripard <mripard@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Rob Herring <robh+dt@kernel.org>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
        linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <a48923b7-12f9-808e-1171-49b826bd5f1c@samsung.com>
Date:   Fri, 15 Oct 2021 10:40:56 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <20211004012739.39053-2-samuel@sholland.org>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20211004012739.39053-1-samuel@sholland.org>
        <CGME20211004012749epcas1p35a959e43208a0de0f14aefa7ac3b0ccc@epcas1p3.samsung.com>
        <20211004012739.39053-2-samuel@sholland.org>
Precedence: bulk

On 10/4/21 10:27 AM, Samuel Holland wrote:
> The MBUS node needs to reference the CLK_DRAM clock, as the MBUS
> hardware implements memory dynamic frequency scaling using this clock.
> 
> Export this clock for SoCs which will be getting a devfreq driver.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>  drivers/clk/sunxi-ng/ccu-sun50i-a64.h      | 2 --
>  drivers/clk/sunxi-ng/ccu-sun8i-h3.h        | 2 --
>  include/dt-bindings/clock/sun50i-a64-ccu.h | 2 +-
>  include/dt-bindings/clock/sun8i-h3-ccu.h   | 2 +-
>  4 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.h b/drivers/clk/sunxi-ng/ccu-sun50i-a64.h
> index 54d1f96f4b68..a8c11c0b4e06 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.h
> +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.h
> @@ -51,8 +51,6 @@
>  
>  #define CLK_USB_OHCI1_12M		92
>  
> -#define CLK_DRAM			94
> -
>  /* All the DRAM gates are exported */
>  
>  /* And the DSI and GPU module clock is exported */
> diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-h3.h b/drivers/clk/sunxi-ng/ccu-sun8i-h3.h
> index d8c38447e11b..e13f3c4b57d0 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun8i-h3.h
> +++ b/drivers/clk/sunxi-ng/ccu-sun8i-h3.h
> @@ -42,8 +42,6 @@
>  
>  /* The first bunch of module clocks are exported */
>  
> -#define CLK_DRAM		96
> -
>  /* All the DRAM gates are exported */
>  
>  /* Some more module clocks are exported */
> diff --git a/include/dt-bindings/clock/sun50i-a64-ccu.h b/include/dt-bindings/clock/sun50i-a64-ccu.h
> index 318eb15c414c..175892189e9d 100644
> --- a/include/dt-bindings/clock/sun50i-a64-ccu.h
> +++ b/include/dt-bindings/clock/sun50i-a64-ccu.h
> @@ -113,7 +113,7 @@
>  #define CLK_USB_OHCI0		91
>  
>  #define CLK_USB_OHCI1		93
> -
> +#define CLK_DRAM		94
>  #define CLK_DRAM_VE		95
>  #define CLK_DRAM_CSI		96
>  #define CLK_DRAM_DEINTERLACE	97
> diff --git a/include/dt-bindings/clock/sun8i-h3-ccu.h b/include/dt-bindings/clock/sun8i-h3-ccu.h
> index 30d2d15373a2..5d4ada2c22e6 100644
> --- a/include/dt-bindings/clock/sun8i-h3-ccu.h
> +++ b/include/dt-bindings/clock/sun8i-h3-ccu.h
> @@ -126,7 +126,7 @@
>  #define CLK_USB_OHCI1		93
>  #define CLK_USB_OHCI2		94
>  #define CLK_USB_OHCI3		95
> -
> +#define CLK_DRAM		96
>  #define CLK_DRAM_VE		97
>  #define CLK_DRAM_CSI		98
>  #define CLK_DRAM_DEINTERLACE	99
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics