Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] spi: cadence: Add of_node_put() before return
Date:   Thu, 14 Oct 2021 23:39:17 -0400
Message-Id: <20211015033919.5915-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iPRV38Gvbg1YCsWNJw0LWdwPbQyg1hwCPyadycFFC4b8VuC42pFNiPT1vEu7?=
 =?us-ascii?Q?UPsHHePvZm4Qx/D88bqIrRMGI79LQHqtr8iguxfwveX8lpeqFt2HR/QFXdWG?=
 =?us-ascii?Q?N8T3jm7svX0f0A2okJUPjdhA+PMaqfK3kc3YByx9byIh1OCYOg81nEOF03U6?=
 =?us-ascii?Q?A4D7ZpRJDxYT76Rzb5icvHMdlOTvOlPesFUShiDxvLjorjeLsAamZYNB05FP?=
 =?us-ascii?Q?Eb7KAVjpIH1qUxcVNvrHWO76QYxv7hgkq4Lpwg8yXHedvw3yhKNA40oK+qgQ?=
 =?us-ascii?Q?/QNYvkMSJlGwg4FEisv1hReWl98OaEoHgnI9n25y1IlCoH8a5LsanAa3rAQP?=
 =?us-ascii?Q?l0cVAR+ffigdWuXzpdjB5gFl8y7YC926So8igbweLAL37PmgUEOirHZh9Tgn?=
 =?us-ascii?Q?OkXcTJN32I6HqFbo4/Tr23EsHeAgr1TOmG2ACZTS2OxUpuLei1+V2JBWQdHC?=
 =?us-ascii?Q?Zc0PIUAvBX5kZzPbv9rM9E7ggPivHD/MJ+8RL4z8Qg4wUv3FBzHhOKmEtfeU?=
 =?us-ascii?Q?hXpTFPvzVAU9K8yck1lFi+hbHTLsJ1HL2WsHP84rkMtWXad63uz4URjWgGbi?=
 =?us-ascii?Q?OuQD+B8StbwPG+VYC4SxBWFULWD+3fWEXYXwQK/ekxMypSEgjpWW8jGFpOBN?=
 =?us-ascii?Q?q8HL2qhslanzOYoIoUnSLVGcM766YTCtJ8rkntOcNaYXmkj8GI9vO+q+2LC6?=
 =?us-ascii?Q?ErgxD0iaeYicpiCQvnePYyfcdMexnv4fqyfSCcX9m/biTieKCkq8JN8w6MGO?=
 =?us-ascii?Q?gHPvUqTbJ1f9hBNKphZ4V2cvO5dsr/OeiaGt+inBhpupPG8isowfZXtvGI3C?=
 =?us-ascii?Q?MRDq11wV2CCbI44esqMibYKzZCd9YnKT1SEDMT0lLetA52f3Y2VQPOcAPhfy?=
 =?us-ascii?Q?j7CBU1pVKFLWX9/pHUNvuNpRpzmounKmcHrjAy+KI0uay+yQCcXpT/6yWo+v?=
 =?us-ascii?Q?IF1GCIjDmwJSlT6l20AfqcLDBQenui/AQyjAZUnQudpcgOnhYEfwcxwi25JJ?=
 =?us-ascii?Q?TcB6i8BwRLXn9viMC9/6O4DM4wpAuKFUneBDwfBrW7a1htZXvPj1ePXUgAWa?=
 =?us-ascii?Q?RENkQO18sO74c3Y2tEr3e6GZ6ps2fNsc/2cG+jXEphdRPSuqTkCLOG45TmFu?=
 =?us-ascii?Q?ky7zSWRG19D2Q3NDldxmIoYMs6AXwTss4RbD6Ds7Tfi719/TzryjgeRN0O8R?=
 =?us-ascii?Q?RmajInU/LSlH/bZRrtleUFkpTjSJFc7wJJ+5keSNnj9AQgM8y/teSxsxyeKv?=
 =?us-ascii?Q?f+OScCkynWMb0L3H89NO3azpKJNNfKXKSst2Kp2CMquYiJW3cC9gK8gIgPYS?=
 =?us-ascii?Q?vVuyp+xK++fqG0i3VI4M+X8w?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7fa419b-67e7-4dec-d2cf-08d98f8d6855
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 03:39:35.5730
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KbG0NX2GfB5J+koK/82m5X7Y5WDQ0opV9pR5Wr1yYT/9ec0Z2/W6Gg+ckCPsMrov9MJ5Hfa/LZCByjdOdPaPzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3449
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/spi/spi-cadence-xspi.c:490:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/spi/spi-cadence-xspi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c
index 6bd0e67fedf4..4bc1b93fc276 100644
--- a/drivers/spi/spi-cadence-xspi.c
+++ b/drivers/spi/spi-cadence-xspi.c
@@ -493,9 +493,11 @@ static int cdns_xspi_of_get_plat_data(struct platform_device *pdev)
 
 		if (of_property_read_u32(node_child, "reg", &cs)) {
 			dev_err(&pdev->dev, "Couldn't get memory chip select\n");
+			of_node_put(node_child);
 			return -ENXIO;
 		} else if (cs >= CDNS_XSPI_MAX_BANKS) {
 			dev_err(&pdev->dev, "reg (cs) parameter value too large\n");
+			of_node_put(node_child);
 			return -ENXIO;
 		}
 	}
-- 
2.20.1