Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] spi: orion: Add of_node_put() before goto
Date:   Thu, 14 Oct 2021 23:40:08 -0400
Message-Id: <20211015034008.6357-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Tm0+G0T3HyTn5KMHcUi2mPV6yXWjXWVNnR3yQ3+xfm4zZvpTMacWbnkx9Xpf?=
 =?us-ascii?Q?Eh89bTqL3gHtzzofesVd0MHjSHJquqLPolvXut8j1qTAyqBuY4QiF5LHXW83?=
 =?us-ascii?Q?6/hfa2Yl40jV0zE5Q942E+G4L3eVfwdJzqlUERsZtSH9Jpodm4KUJRZz5Gmc?=
 =?us-ascii?Q?mJ8vdljghR0OqHvRXB2jL9TWiLp2Slq8wN7sm5lq7glzMQSxjyntEojraJh7?=
 =?us-ascii?Q?LU1DXMCNtC7a0DSm3YdqqbXfz5L70ENP6m6PGp6UgiT2v1ejS3Ya3pIeJvQY?=
 =?us-ascii?Q?f4VYtEKSW0HDmPLvkLgGLP5Ic85bT059k5UWAHIT2EnZL+/QeEqW9AZ5/jGf?=
 =?us-ascii?Q?zCmKOytDXAW8LQX2LoSqaT4sUUHCP5lQwCRFkhV8l7ykrHri3I90svMApzBG?=
 =?us-ascii?Q?6Gx/hJ42Vwm6SX592PMIGOvHA6BXoQYSyjJoo7jZYYQ0LawwTsKcYNNZbO4p?=
 =?us-ascii?Q?Ux3/UUNpJCeucARij2ckYdTNPg3i7wpBMRC/1yioWmYVXdGu3rf4A0R6HfI6?=
 =?us-ascii?Q?a/EFlTEHNtLXvmu3GY3ildP6UTe2994DC+I5J5NoZpzQtNpkup5lRWbGr/8S?=
 =?us-ascii?Q?fOf++pQ6HhUIrdlRQYDZRCAkmM4WbaY5L2nna9iS8UhkTTU4Ba+W+OIr6lJd?=
 =?us-ascii?Q?FyjZUglfVn9Nkxd0GjTl3YM4k97AUWxsIOu1h6tUothuPOWwPoghLHmWnMaL?=
 =?us-ascii?Q?iMT0rGS3CXhtfm500W4mPI/o+3WJGN0/RAD5KR12HyNQ1pIWKZpSi78bkktm?=
 =?us-ascii?Q?sTixWlL2lvnIcLL7VSDN1aAX/7i8/piHJw7396jwo4Xmn2DEMOdP61pc6lB9?=
 =?us-ascii?Q?fWw3o8K/px2ZAvX2g/F7eHXyCkOtAftjFZXr9DN9L/xHallo9TmH7ozmXjj8?=
 =?us-ascii?Q?nQ45464glGsZ6mEEgwfAYZIDyKgnf24od4ZQjNI5Dr+GKOGcPsn7mE484SWs?=
 =?us-ascii?Q?YtFVUVG8ucxbidxB7VXZJEPV9E2eu9yulB5F/rnd5BOWY/+OjAF1rcwgdyWo?=
 =?us-ascii?Q?a4zNwO8wP09jjHk3X0mTfQoFUm199P5AQDpSMg9XekwGq2uQ+ZdHjWC30AfB?=
 =?us-ascii?Q?WGOuK+dTHDj5HU0lBRMh/Eqi6g5cEtos+RKifpidyUQsZk4b2CUVUX3EfWYM?=
 =?us-ascii?Q?HcnKlp6v+13CjWMw88Esth9m4w5X758fpBhaIRsOwARXQ5R04lOdSGq9H/31?=
 =?us-ascii?Q?HKhHKDTaGAoo5DXQtV/AKwNWCTT+WcadRcjEh2NMv1a2GHVkksyvNgbeNQZh?=
 =?us-ascii?Q?RlZ6V/VwUL2ExO/3nnPqNT5+htRg8A/hgAlpB8nfhVMdnatmw0Ft31d2la3Z?=
 =?us-ascii?Q?qiL40eg1BUlYhHPwbDzPziO5?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa885e04-c0e0-42a4-e6b5-08d98f8d83f3
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 03:40:21.9034
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8oaPOV7gBN7IXyR0Dtkuk1JL6HMe+DB/JtEYqg861wQd0rgL0ruBqKk7Q9/PpcEYO2PjGUOwFBsmaqT2r4TzVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3449
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/spi/spi-orion.c:738:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before goto

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/spi/spi-orion.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c
index e8de3cbbfb2a..565cd4c48d7b 100644
--- a/drivers/spi/spi-orion.c
+++ b/drivers/spi/spi-orion.c
@@ -769,6 +769,7 @@ static int orion_spi_probe(struct platform_device *pdev)
 		dir_acc->vaddr = devm_ioremap(&pdev->dev, r->start, PAGE_SIZE);
 		if (!dir_acc->vaddr) {
 			status = -ENOMEM;
+			of_node_put(np);
 			goto out_rel_axi_clk;
 		}
 		dir_acc->size = PAGE_SIZE;
-- 
2.20.1