Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Gregory Clement <gregory.clement@bootlin.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] ARM: dove: Add of_node_put() before break
Date:   Fri, 15 Oct 2021 02:39:53 -0400
Message-Id: <20211015063953.8603-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YbdB1sWWrbb1QDi4sSvQ/dEtZoR6XCTNxaV099u5PDOuQqhZeFGvf+MbjQ4R?=
 =?us-ascii?Q?qA7e3Z0MMp01t7vjLr9Iw1aHVtY6nB+/vlUKN/+YIMRVOkhAmE5T8Qkxdn88?=
 =?us-ascii?Q?rQLQbaWkgB5TZo07VyE4QDOZwQvB2rpLE+4W9D3FjmDhlDCJbADJxkSg1fb/?=
 =?us-ascii?Q?D7WgVJ7UdoxYLSLfRNSMxkzoSAAOQBfdoG8x5bF6oM6Ak3kJbw7d6YWREs+T?=
 =?us-ascii?Q?DK11kRc/Dtw4LO2HMavVHNLAr3n/5OtqqD4tBlEw1vE0Vb0nHvFijyj+5m16?=
 =?us-ascii?Q?hMrYFbzcnjgqysXR0gRbk2NvU+eMuIhuzDpOSOxlEGCJ1VXmZD2HT027/Aoq?=
 =?us-ascii?Q?qoi4xnAKW+w6jJDe5CqlLTBdAcl7BguCY+ZZwRe1cI+trYW5BS3UNeYgoTgH?=
 =?us-ascii?Q?ksG0Pa9bxaKPerK6TafhVt1y4QrTQXpcywGqeT/xYtVP3VlQQNPQ8bnSvkva?=
 =?us-ascii?Q?2o8vu0TF60GGrxu1Wy1kuTddjcJFU5tN8IDhUkEKbmjguYGjyyqBYl7tTcq4?=
 =?us-ascii?Q?aKY5r+5KhYkrCKHm+ImKFXtYEx8HfzELNSIAQrqMRKa9CmxsHuXGgp5tfCCz?=
 =?us-ascii?Q?b48hyAU63faEmJ4EAmnGao7TGm+pRi99J2Y2oMvq4yS1ihZUmOsv0pEXc413?=
 =?us-ascii?Q?dUC6/BuAeXHtQ0Pj6CXubRBKjMRUWs3t5Oqo9SPbAo+j0tEuZAkffgV++tw6?=
 =?us-ascii?Q?fOR7PdjIvACwubdUc95gbMbQ21kVNG61t+FLsb809oyxYKOmOoNVN+W5cMn6?=
 =?us-ascii?Q?Q/YBuCYSH1hzgJGlzux+zDujGH4G9u0zBhAzui+3oT8Oc+79zPmRwA0xnOMX?=
 =?us-ascii?Q?8KL73LHxPHL84Hu1/OKOB6hXbnmpWvv91VRBNUsm2m3rj2An9ceGTUx2m/xz?=
 =?us-ascii?Q?XoxDL9Hwv9N7ciKIrv4Xpxy5qwCwCS48R01GvXNpP+j49Qwr21782xChtBCu?=
 =?us-ascii?Q?98A0OMqM5eh7zewOYAOtaFmuBGz8m8j0YU2x/ypUAoOMhXXwb8o5tW+dbWPi?=
 =?us-ascii?Q?im2mT4ZarOs+7rq58Jx4A1SRZxYupzU6rEIHEcd//Wlg0KHDsN0qGHOYwabn?=
 =?us-ascii?Q?BfsfUaTni1oQK/1KlyOzAU0GFERKYYhFnRFYu6d2qMel/RXdqZulHkr6vD0B?=
 =?us-ascii?Q?r0nwDb3Akyoy9oWYzIi91EK9jMd6GYhv7QU9t3sSZUDAcEBniY6ZgyU6jQGp?=
 =?us-ascii?Q?P37w5LCSSNNxx3Uwda0ZEahj81Yhbcr2rAt/yAqzl9bYsvbJdKUMCNF8SBWH?=
 =?us-ascii?Q?QCsddrHFmN/lCAejn1QhlZpttrC8rrX3bvB5pyoiVcXulbaLdmCy8FhdMdxY?=
 =?us-ascii?Q?8c2C3nXfGNdhfxyeyFI++Zdd?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8926e8d9-1587-46a4-dca5-08d98fa6a875
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 06:40:20.7273
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Us7vN7TeHLWiALLrePFh/LjNakOTjHhlbpgC7peeZwLr6JuHiwhYP8LFPHy8oWGLb9H5Rkn8VNjiVi8H8NYYAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3449
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/soc/dove/pmu.c:408:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before break

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/soc/dove/pmu.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
index ffc5311c0ed8..6202dbcd20a8 100644
--- a/drivers/soc/dove/pmu.c
+++ b/drivers/soc/dove/pmu.c
@@ -410,13 +410,16 @@ int __init dove_init_pmu(void)
 		struct pmu_domain *domain;
 
 		domain = kzalloc(sizeof(*domain), GFP_KERNEL);
-		if (!domain)
+		if (!domain) {
+			of_node_put(np);
 			break;
+		}
 
 		domain->pmu = pmu;
 		domain->base.name = kasprintf(GFP_KERNEL, "%pOFn", np);
 		if (!domain->base.name) {
 			kfree(domain);
+			of_node_put(np);
 			break;
 		}
 
-- 
2.20.1