Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Qing Wang <wangqing@vivo.com>
To:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     mike.looijmans@topic.nl, Qing Wang <wangqing@vivo.com>
Subject: [PATCH RESEND] clk-si5341: replace snprintf in show functions with sysfs_emit
Date:   Thu, 14 Oct 2021 23:45:28 -0700
Message-Id: <1634280331-4150-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BEoCswIkWowP1ERSrIjtVH1tKu4+4KWTH3MlUuOnSeFSEocVodmmV5Gm3m9z?=
 =?us-ascii?Q?BZ0vkhmmdZ1yVaHLYtRuLFUme4ohT/6kki7kESGBZgbTNkwEOEHZ5TTNCzpd?=
 =?us-ascii?Q?GCPZamUig15SHJStYcAxiOfdpcF+2SN8nJUMsa92U5QKzdnghduPZvvUPqjg?=
 =?us-ascii?Q?5Ap+vZOfF3N+8BbLC23l0KzMJyMOZAafQ/T0adEeEFE3MTOUrtUuLsKib3pk?=
 =?us-ascii?Q?X1AriKgfiVcuFzFfyzkrzP7C2CPvQQt5UE9ubbfmYiWn4/qugGZCRHwMg+gV?=
 =?us-ascii?Q?pdZm/6uV61ePeGAW3eE9Jz4lZD4QCeQt39FBEP2r2LT+NEViwNpgee2m+3yD?=
 =?us-ascii?Q?rDTq7ZBCpadWYHyu/ZCBQejta3h6oCz2fUO/jMYeu//ZJpYUfBdEGCcTdDiz?=
 =?us-ascii?Q?qeG87d/+a0OlVqBfjrax/7uS54wOx5GX4OAlZd1oEMNzyfDWshZ3pU0HcTrj?=
 =?us-ascii?Q?I2Jutwv8uMwujqD57ElfLqZEepNLmvuom8hpDNkH60d1XDUibx6wUDXCszjw?=
 =?us-ascii?Q?g0oGhdSqT78PXItU61cqWN6Tqn6zb+jentDfB72faFvptD2zIhxJlagAsydi?=
 =?us-ascii?Q?VFT0LCN6gfuAc/JhDWu58dSM0QUG+D9x6g7KPCk9+qI8YxtPZiaT6mf4Ucje?=
 =?us-ascii?Q?GJnWToikh1MooI513TMpuNkAZao9wxPzEfnTzrH3G44lfQlkIDZ+T0nvEKXE?=
 =?us-ascii?Q?nOowayZN2GYHR5NdRmMoJosh2jXrMVGcBS9JyklpDInNizor2aSC3+d8ejEn?=
 =?us-ascii?Q?P+XwgOQhSG3GepE2x02jreH5umCZjH8reehcP07bcf3RNq7ykCPfZPmLQsZb?=
 =?us-ascii?Q?dnMJ8KSXh7DLyfX88066dBgXQU40EYxnqT6Mnv6LA7eXsOigoDmQAxm20Z1v?=
 =?us-ascii?Q?qDOv8tOEpjk1VlKMpjDcGNARsbSLEQn9NpJ1ygINlOg6VCLbvuMilR0mlJdF?=
 =?us-ascii?Q?wuTLPlO/7uBvwFIrmDCkVfqhRw8yALTqmQ8iO9PS5mf28tLOolnQmNzoQUfn?=
 =?us-ascii?Q?PZr+nPZJYeUJ2cJwdvplFc5F9Jy0jnhn2uIbvg0mWwnjKrpEDbok9wOe+xqF?=
 =?us-ascii?Q?uCowKXuJ6oIsh/MG3lg6XdOOEnB1I8tUDkQacwnqFCBGybyqPl/RqhWneAWx?=
 =?us-ascii?Q?PKYYt0HeI4zgpHK7i7fFwsxoWF+/NTX329nzHRve/JvUcg57txeIPd+IBbpF?=
 =?us-ascii?Q?VZTNDBbU4PoDj3Qno8P4EhayRz8AIGDFFY+Lgot79U//GDVWDEPOQTxWtEef?=
 =?us-ascii?Q?8WPIjgslo9RxyPclPjg1eC69B1Nkp/3dxrFzoR2H6sP9IBOSC+vP7o7UIxvk?=
 =?us-ascii?Q?H9CbZC4GJO8kOQH2rwi7SQKl?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 117eae58-8dbe-4783-21c7-08d98fa76dad
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 06:45:51.4207
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f15roTlWwAx/ZS1oEKJi88eaSYXjJfvvKxaoe+9p7dLxOI6heCCA9A3mhjkCmbA5fF7Vicb+r6EXm6LHZ321iQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3147
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

coccicheck complains about the use of snprintf() in sysfs show functions.

Fix the following coccicheck warning:
drivers/clk/clk-si5341.c:1471: WARNING: use scnprintf or sprintf.
drivers/clk/clk-si5341.c:1486: WARNING: use scnprintf or sprintf.
drivers/clk/clk-si5341.c:1501: WARNING: use scnprintf or sprintf.
drivers/clk/clk-si5341.c:1516: WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: Qing Wang <wangqing@vivo.com>
---
 drivers/clk/clk-si5341.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c
index 57ae183..5d62ddb 100644
--- a/drivers/clk/clk-si5341.c
+++ b/drivers/clk/clk-si5341.c
@@ -1468,7 +1468,7 @@ static ssize_t input_present_show(struct device *dev,
 	if (res < 0)
 		return res;
 	res = !(status & SI5341_STATUS_LOSREF);
-	return snprintf(buf, PAGE_SIZE, "%d\n", res);
+	return sysfs_emit(buf, "%d\n", res);
 }
 static DEVICE_ATTR_RO(input_present);
 
@@ -1483,7 +1483,7 @@ static ssize_t input_present_sticky_show(struct device *dev,
 	if (res < 0)
 		return res;
 	res = !(status & SI5341_STATUS_LOSREF);
-	return snprintf(buf, PAGE_SIZE, "%d\n", res);
+	return sysfs_emit(buf, "%d\n", res);
 }
 static DEVICE_ATTR_RO(input_present_sticky);
 
@@ -1498,7 +1498,7 @@ static ssize_t pll_locked_show(struct device *dev,
 	if (res < 0)
 		return res;
 	res = !(status & SI5341_STATUS_LOL);
-	return snprintf(buf, PAGE_SIZE, "%d\n", res);
+	return sysfs_emit(buf, "%d\n", res);
 }
 static DEVICE_ATTR_RO(pll_locked);
 
@@ -1513,7 +1513,7 @@ static ssize_t pll_locked_sticky_show(struct device *dev,
 	if (res < 0)
 		return res;
 	res = !(status & SI5341_STATUS_LOL);
-	return snprintf(buf, PAGE_SIZE, "%d\n", res);
+	return sysfs_emit(buf, "%d\n", res);
 }
 static DEVICE_ATTR_RO(pll_locked_sticky);
 
-- 
2.7.4