Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Qing Wang <wangqing@vivo.com>
To:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Qing Wang <wangqing@vivo.com>
Subject: [PATCH] media: ccs: replace snprintf in show functions with sysfs_emit
Date:   Thu, 14 Oct 2021 23:49:22 -0700
Message-Id: <1634280562-4629-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sBPvtwJhZZtV4pz/is5F7e9xeWlnbIZ8/1x/mZvuSa34YQu274HhyQGz7y4I?=
 =?us-ascii?Q?/yihn+ijWBInAOHlfggCuYbk/o4qO7c9ZG8Bxdq4AU4d/J8IjHYdkAOiA6Z7?=
 =?us-ascii?Q?l17bDggyPrRmeXfbf9e5MYAWskRAgylOEHlLo/ofgYSZZVR4w02Jz0Y6rlA8?=
 =?us-ascii?Q?+M2E+3Ap35RRLhyjz87aJt2Si3N4flmrBCOUCYSp/waHrFsN3PPL4By51+f2?=
 =?us-ascii?Q?2Nu2zDsOBgmcX8kUfO64/CXSlxAXcTjUGkV27Owfm2KIJF2+tQfyTtJBE6Cy?=
 =?us-ascii?Q?ksvzhInNZMYUAkILfPhy5ZMw4nhLv6TPyIbMlB16KearCa1QIkUTSPCaTxw8?=
 =?us-ascii?Q?uMlXu+AHVFwTPJ7Y6LGoQG80Mu0hUYB7C6XshpLR5lgPYSdtNEXkomKnPD7A?=
 =?us-ascii?Q?OIQ+xG2nqgXnsJaH99LW02JlRZFqi4FrM0W8gKaHGijxTq71jZoGRLTD7R+c?=
 =?us-ascii?Q?EbT8YoS1Ieh2pDe+bmPeEQ4OrztMssHo0+t5cuz33U4WQWfWiNwjXuW7YXJh?=
 =?us-ascii?Q?nRSnWt5tzCcDLoTp1QEFygw7auOiP3i8lZL7Wl40cz4ZmTl5ovI92cE/if/D?=
 =?us-ascii?Q?2pjd9fg9a0TiyvgxlJ19FcZ378gMt7QZJLu9NIbZ3jve8va6p36+dYtR2RhC?=
 =?us-ascii?Q?GmG8cPpB/bCRGzVLA1/m3o2+vZL6+9+YcuMBM/XdMmGWjtKsUluAcyWfJ7IX?=
 =?us-ascii?Q?9DIeTJU2wZrp/kyNTL+hCdKPevDapc9Qc7MCC8bniGYEQPfL+0OLQyvpeCRU?=
 =?us-ascii?Q?xs4xsVgOssMRswd5PEakkueobYZkEP62XjVAxpy3MYuVU6mNsyJUk8dRvIoa?=
 =?us-ascii?Q?9WT2tU4YxThiNn0O8w7vmtvcs9FK99jHMI9J25J6yejhxsmO4WgEdMKN0551?=
 =?us-ascii?Q?x14gsdvQrGum6PHtZ6Ar8+3E2GsjdXL79Xih7nf/87+le16tz/AOp8gsGmQf?=
 =?us-ascii?Q?uXyLEpzeCi71UURo+L5U3ZnqqiZxN3WXQNuvw0tbGiNqDK1tHquIRMsowUip?=
 =?us-ascii?Q?FyCQLgGCwPVwZlhicKA3+Xi/GT9w8dl0HObw9HdCQpezrby/zB8smvf0ZQDB?=
 =?us-ascii?Q?wj4AeeSVrHsph1pdmD7CR59LEwBdHT8/ocBNp8MbzKkDDYIcp2FmqWjTN1DS?=
 =?us-ascii?Q?xzX3XBDJM/TY8K9m0q6dmsv9e/cu9t+C/nIr/Nic7oQ+aPK54YP9qkIzp7Mo?=
 =?us-ascii?Q?mNFslZ9Nd3UVKIlKoJTKgdMw/GIRvcGcLky0C8ZLHmgxdLxyoKiLllPXts1L?=
 =?us-ascii?Q?1uCWaRljCz0GwT7I12Z64uGHEZR+P4rT8Ez0OmkKUFtyysxtutKfQHT5c6p3?=
 =?us-ascii?Q?DGslzlCo9LFQ9IL9Lf+c4UBE?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 949315ff-fe40-4e98-068f-08d98fa7efcf
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 06:49:29.7237
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CEJMoDTlNBF+Wk9RmTHQkBxeN3GVxUFARf8k/8NPAfhVMJ+1zL9NYybNbhQaKu0gi/sagEMaeh+9nLm2YWvmGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3388
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

show() must not use snprintf() when formatting the value to be
returned to user space.

Fix the following coccicheck warning:
drivers/media/i2c/ccs/ccs-core.c:2717: WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: Qing Wang <wangqing@vivo.com>
---
 drivers/media/i2c/ccs/ccs-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
index a9403a2..21a156d 100644
--- a/drivers/media/i2c/ccs/ccs-core.c
+++ b/drivers/media/i2c/ccs/ccs-core.c
@@ -2715,11 +2715,11 @@ ccs_sysfs_ident_read(struct device *dev, struct device_attribute *attr,
 	struct ccs_module_info *minfo = &sensor->minfo;
 
 	if (minfo->mipi_manufacturer_id)
-		return snprintf(buf, PAGE_SIZE, "%4.4x%4.4x%2.2x\n",
+		return sysfs_emit(buf, "%4.4x%4.4x%2.2x\n",
 				minfo->mipi_manufacturer_id, minfo->model_id,
 				minfo->revision_number) + 1;
 	else
-		return snprintf(buf, PAGE_SIZE, "%2.2x%4.4x%2.2x\n",
+		return sysfs_emit(buf, "%2.2x%4.4x%2.2x\n",
 				minfo->smia_manufacturer_id, minfo->model_id,
 				minfo->revision_number) + 1;
 }
-- 
2.7.4