Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Qing Wang <wangqing@vivo.com>
To:     Wolfgang Grandegger <wg@grandegger.com>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Qing Wang <wangqing@vivo.com>
Subject: [PATCH] net: can: replace snprintf in show functions with sysfs_emit
Date:   Thu, 14 Oct 2021 23:50:24 -0700
Message-Id: <1634280624-4816-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?csRka1JEPUY5+SFZgl1V+48CMeMvbuLZILHPbcuutvxb+ux/f06A10VwkZuY?=
 =?us-ascii?Q?0xm7gSNxt1q3m0tUsVAUqlc5U8mJrdbia03ctVLi+N8QOFqNF6DkSAY1Q/gk?=
 =?us-ascii?Q?snW9K7M9ohV3+2gCHP+jw9KiBzaKSVBalplY1anW0XN8Gx1XmHDpQcXc3buB?=
 =?us-ascii?Q?cDsODWiP9JO105r1KguonNZ6S3Mqs9tHWuS/S1dBTq/TpjhzyfTCleEhJl2Z?=
 =?us-ascii?Q?p3yFrDeTC7+0ohHp4Duk+UOO26VazBHwcaC3V+1vbBMmnu4mtmRtoK+OAJQP?=
 =?us-ascii?Q?GlwemfUTSUg0EKHgOSM1qIR3tBW81U2rydZfgQbbcS1AjzFKCIA6rQa1CQ/1?=
 =?us-ascii?Q?U+u+QsWAw8/a++pLGFp2ugPlqr8BgocLCehkZ+z28uB72FIeJVPgCM6HnJv0?=
 =?us-ascii?Q?vIKK+U1fOB2WezEaUKD/gxdCLTMIC/nStf6DgV5HZq9w6Utr/kc9J+/Ob1Jr?=
 =?us-ascii?Q?qVy0UlFw8yhpBMOsaaWvdfVaVhd0Wexgi8vYarEe6AziUEbQ0/ZH0PM0t8xk?=
 =?us-ascii?Q?03dT087mnkylHN83iwKE4ng2wMt2zaDKXqnRXbkoO1/EghlaKMJdUamsyRAO?=
 =?us-ascii?Q?Qr7uQfx3OKAdF6nZK4pohhXI1cc7vH7cqG/Og9manCaF7FdDHkZa/ele+wlH?=
 =?us-ascii?Q?Gi1swJz+I1i68aX9UlKpCk3/ACByh18IQcwCdyLNK882MRSPYJ+Mp7SZ96n1?=
 =?us-ascii?Q?hAtgTf/EsXtG0iv6dmXF7bobXfhJNDuoPcpi+K07hwfHXYvKsrJBkoHrJkhQ?=
 =?us-ascii?Q?TTEwIMIrFxrWiolmX5WdqOXL8Pi1NFuSPlcN8s/fNez4UgnAAzhbVgQNMOw8?=
 =?us-ascii?Q?8JBT7q9R80H+gtqnYCmUSrAfDqFZ/6uljrgIEADJ88W78LDYICrQjt9iFCSx?=
 =?us-ascii?Q?ZDpBI08Egw9sB4w/I3YUSpEQb0TEiN0GFImSyTHr2YLfZFkr66TBHcnzFQ70?=
 =?us-ascii?Q?kEIZZmuGoB2TxkoAzcSF6aRsWs8v44VOR05RZwcZwLotVi325OX8bKA/Tq8R?=
 =?us-ascii?Q?ip55dpYxKmaorRGx6otluYEk9qcJH2+rkgA+dOcj2hz6rrCiozoEerKm0vU8?=
 =?us-ascii?Q?DYoFuvCFnA8mMJx5Tkqd5eiZSg4w4IMFVdwaeh+WT1CQTu9ugkBg/QsKgiIR?=
 =?us-ascii?Q?nT/fSm/nYtUZYPYVwOo2L5OmFq59mJn4ZUdcznT7v3uV09DPqFboD+6KwQ8r?=
 =?us-ascii?Q?aqWxRvwP0pukwxDRjHYS3nlnwxv4foVWGXDodY7nt3LOI2px/aPbnQRRHgw2?=
 =?us-ascii?Q?u4sCFrFb4dgBVi+854Nze3kaJ/bb6WOYDrlJftAA/Oi3C9IoLmc0K0GiD57M?=
 =?us-ascii?Q?AI0D0xpuUHq+PoylO078yYec?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 999f1236-87fe-4ead-527a-08d98fa816ae
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 06:50:34.8606
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OfBC8oAywR+zMv28E5Q/dK/PnkuFWOIDDScIIxHuMfb+jukLB55h9Fiw/orISS2hGgC7+kNOOB4gACl12ct3pA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3003
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

show() must not use snprintf() when formatting the value to be
returned to user space.

Fix the following coccicheck warning:
drivers/net/can/at91_can.c:1185: WARNING: use scnprintf or sprintf.
drivers/net/can/janz-ican3.c:1834: WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: Qing Wang <wangqing@vivo.com>
---
 drivers/net/can/at91_can.c   | 4 ++--
 drivers/net/can/janz-ican3.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
index 04d0bb3..e4e754e 100644
--- a/drivers/net/can/at91_can.c
+++ b/drivers/net/can/at91_can.c
@@ -1182,9 +1182,9 @@ static ssize_t at91_sysfs_show_mb0_id(struct device *dev,
 	struct at91_priv *priv = netdev_priv(to_net_dev(dev));
 
 	if (priv->mb0_id & CAN_EFF_FLAG)
-		return snprintf(buf, PAGE_SIZE, "0x%08x\n", priv->mb0_id);
+		return sysfs_emit(buf, "0x%08x\n", priv->mb0_id);
 	else
-		return snprintf(buf, PAGE_SIZE, "0x%03x\n", priv->mb0_id);
+		return sysfs_emit(buf, "0x%03x\n", priv->mb0_id);
 }
 
 static ssize_t at91_sysfs_set_mb0_id(struct device *dev,
diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c
index 2a6c918..feedc13 100644
--- a/drivers/net/can/janz-ican3.c
+++ b/drivers/net/can/janz-ican3.c
@@ -1831,7 +1831,7 @@ static ssize_t ican3_sysfs_show_term(struct device *dev,
 		return -ETIMEDOUT;
 	}
 
-	return snprintf(buf, PAGE_SIZE, "%u\n", mod->termination_enabled);
+	return sysfs_emit(buf, "%u\n", mod->termination_enabled);
 }
 
 static ssize_t ican3_sysfs_set_term(struct device *dev,
-- 
2.7.4