Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Wan Jiabing <wanjiabing@vivo.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net
Subject: [PATCH] soc: bcm: brcmstb: Add of_node_put() in pm-mips
Date:   Fri, 15 Oct 2021 02:49:23 -0400
Message-Id: <20211015064958.9826-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?14MO1nTpbWs6UGkXS6/sasTHOwGIfuCl6+41H+u7iacrcYh7I0NekFMMdP58?=
 =?us-ascii?Q?nOaCVfSz6J7/Y+whbwZGLBcYvh5ETnkKhwINeSOGvgaZ4hewLrNlb8WwomWc?=
 =?us-ascii?Q?wug/JKoAC8/zOm2X6TQoPgVh8S83L+AC+cYO8w32+qFqsaR9QyFP1qDk2OXW?=
 =?us-ascii?Q?0u3SUaCPWG2AcPGDVj7VV2FqUj08ZdUPqyefINr/3TwFSD9dribst6PlrjBV?=
 =?us-ascii?Q?kFbEH/GYocyIyEswm4FGeCjp9nsVfzAGzVDS8LBLJnhl01Pvi0Kim7vnT7OH?=
 =?us-ascii?Q?X3uvNgMdbPDqoeDXJnKgnpiH4Q67J/8zYOE1nbfr4cIPnAA+v8o4QmQaY0FD?=
 =?us-ascii?Q?+yIzcrNXJbthD4dVmbAdNySW2B7ujU8mVO9OOVprU8A7VouB71KkeYU4dfNV?=
 =?us-ascii?Q?C2ueolmwWjwkTR3fhxbl26f8P7Q5l/VyTGbcsDE34a3G99559Fy78zqglrw0?=
 =?us-ascii?Q?v+jX0smfgzwV9ob+l0ez94AmTSKO+kr0nX3sW3JTJWhQ1VptIRGCruEyrUU5?=
 =?us-ascii?Q?Jz3rHFqQrvrZBFzB8EoqA/e7424tnheFA5jy+AVdYnA5npokpf9Xtq+B/5TU?=
 =?us-ascii?Q?suHDEHovRgc2FARpXjfu83tsuHt8dB/qrI121zzXj4la0lIlJnClQvIrOVne?=
 =?us-ascii?Q?TXoQoElHnFnzbRS9cQAiwWCLrruKX+LLOnlV/R7YIiGJW1xmHrzJ8gTy6UoW?=
 =?us-ascii?Q?T5eDetqLk1/slz3L/nmMQFvQTJr5h6sjUqyDfIUljmFwG7GYsq99stTg2jeG?=
 =?us-ascii?Q?f7hFs/ukeI7l7YXQFu/LRBji0MWosrIcez52GlLkz4G8ul6qmwXLWU/MD8JQ?=
 =?us-ascii?Q?gYChVe+B6buZJjIJmntCsKjEUsmvm30ftnklXa8vBVyFo8v0iDVlq6DOixhU?=
 =?us-ascii?Q?qw38k4VXoLj8E9LjaDCKWQx9iW1PWaqVZMtX4raIEJPqt5oEM+v/hGSGgl5j?=
 =?us-ascii?Q?9J1KJhta4XBzDYuoayxhXfGcKUrp00P4UuLe8gR0x7ScIw6ojqLeoT9jPLcN?=
 =?us-ascii?Q?/83HP1k9IODkHF0kl4NISkL6ercLkCBGS2ZWPbQaEeVfKJvM7SxxKKQPouYL?=
 =?us-ascii?Q?acRxVxQNAlM1UIjKBvhrE+IuyS6HISsk946Qi2/w1xxEf4geAcwhCIWVmdYq?=
 =?us-ascii?Q?ZDxcY6RsdRqFWMeMavIUpR2NXCo63z3aG7l73CWBaVrV8kvEB4F+QkBGfaXW?=
 =?us-ascii?Q?yEL/XpNK2hbGpCGsjklM3DJ7jysBct/LzB7296QzR9NAc8CFW/D+dTeRPHhH?=
 =?us-ascii?Q?OniWrcHWgFqGPVngn3greDgs7XbKZpfb1TgoFFhhKR3kvRryHZp6au/jiuq+?=
 =?us-ascii?Q?ER7OwZCz8EeMnC7OnxQrxosS?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: edd9fe25-c19b-4175-3e5c-08d98fa811d8
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 06:50:26.8486
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: llONUdURaZQ4cFm1DhbfzrY2YVuXmuSuqAJC9O3keARIMbr76y+CnlHgJx5FeNs6xBp3KqHPWGNDQMfNnOpJag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2777
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/soc/bcm/brcmstb/pm/pm-mips.c:404:1-23: WARNING: Function
for_each_matching_node should have of_node_put() before goto or break

Early exits from for_each_matching_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/soc/bcm/brcmstb/pm/pm-mips.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/bcm/brcmstb/pm/pm-mips.c b/drivers/soc/bcm/brcmstb/pm/pm-mips.c
index cdc3e387f049..4dfb5a85032b 100644
--- a/drivers/soc/bcm/brcmstb/pm/pm-mips.c
+++ b/drivers/soc/bcm/brcmstb/pm/pm-mips.c
@@ -405,11 +405,14 @@ static int brcmstb_pm_init(void)
 		i = ctrl.num_memc;
 		if (i >= MAX_NUM_MEMC) {
 			pr_warn("Too many MEMCs (max %d)\n", MAX_NUM_MEMC);
+			of_node_put(dn);
 			break;
 		}
 		base = brcmstb_ioremap_node(dn, 0);
-		if (IS_ERR(base))
+		if (IS_ERR(base)) {
+			of_node_put(dn);
 			goto ddr_err;
+		}
 
 		ctrl.memcs[i].ddr_phy_base = base;
 		ctrl.num_memc++;
-- 
2.20.1