Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp311042pxb; Fri, 15 Oct 2021 06:05:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9yt0RVStLZzRacjNnvZjhFqYiiQ3BPuIZnkBfpXuumqu2+7DSXvartt37cDQQEsSaBLoY X-Received: by 2002:a17:90a:644d:: with SMTP id y13mr13653770pjm.10.1634303145826; Fri, 15 Oct 2021 06:05:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634303145; cv=none; d=google.com; s=arc-20160816; b=O6h1mOcgqin/Z0KZ+CsIihp5GPHRFJ1of5kPBL6FhXKn84GmpSCytyXnsEw2amRshJ Pj4mzQZgLnAEiUIbdOMwhTV2367GzLMEub74DBYrB72W1cqHfrRvjypemVussHuaFP/f t8B7lmKKd74TIHcH85i6VWU6ybNLvYfwBQfrPYCqV8UwKBOyUe6QuQQd+VtCwfICoRwt kyCTLKzzM0vIDAS13WDAUL5bJsF5pLKvuGxsFu3ArB1i2vMjjbg5aa6alfR/O+eFobqc +tRnjGsvl7UgUTrAEVqeXNYwZzV/68ylwoOGi/EUA3Ikc2HYERczuCOGNzsmU1gBR5Gs mVZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ov+QRA5KrsbOiHEG9w3Yf/dXptzbzwfNGDGYyMBAmvM=; b=lkNROrhjPEFm3kOb/yNEg7uGioysSzYQi7W7D6Ik+YCgBZg33gUaPaZh0XYMWD22Jz M6EUQXDdCif6XNyH0n16orW+2fn/5MIdwmH9wh4bqQAa/VajcqWv9eiVdNPv4ivV7QVC XAqkWcfeiDNZS//26BF3IhWl9OHQ9b9y5/Ng93ONGP3vO89vWRZfNtEd6wUmLfCFq7Db A68tu4Tq51LZYtJDAUXkh4Befrm/dmvU+9KRkmtdn2KZgim4rWEV6Ztwv5lnndHXS/Ci ZZNUc03X3/+v/qN3/q8OEPWuvuBcG71kBCpTy3fRLF7x1rhNPw1Lbh0/wTOhHgiEy79F AgIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=npfqi6Bw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a13si7103743plm.85.2021.10.15.06.05.01; Fri, 15 Oct 2021 06:05:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=npfqi6Bw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234444AbhJOGy6 (ORCPT + 99 others); Fri, 15 Oct 2021 02:54:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:34678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233916AbhJOGy5 (ORCPT ); Fri, 15 Oct 2021 02:54:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4E7636108B; Fri, 15 Oct 2021 06:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634280771; bh=kJLNNbvPPxCqKxbEnHqwodixRci4rQ5VNfWqTPDU11U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=npfqi6Bwgq784kVm6QnBH/YRbtpYfPoX2HhfQmec2i/s0SBnhQKUpNASSu47zYWrZ VjN2sAEgsEbQwBd26MSIdXODu5UBkjlsRS4aoaZKGDkSNuZOInJ33I3doI2KkeEPMm SaVLTIa/gm5QnPFgoz8g/CNrrOJdNG7Mx7MVzdCA= Date: Fri, 15 Oct 2021 08:52:49 +0200 From: Greg KH To: lianzhi chang Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, jirislaby@kernel.org, andriy.shevchenko@linux.intel.com, linux-input@vger.kernel.org, 282827961@qq.com Subject: Re: [PATCH] input&tty: Fix the keyboard led light display problem Message-ID: References: <20211015064534.26260-1-changlianzhi@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015064534.26260-1-changlianzhi@uniontech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 02:45:34PM +0800, lianzhi chang wrote: > Switching from the desktop environment to the tty environment, > the state of the keyboard led lights and the state of the keyboard > lock are inconsistent. This is because the attribute kb->kbdmode > of the tty bound in the desktop environment (xorg) is set to > VC_OFF, which causes the ledstate and kb->ledflagstate > values of the bound tty to always be 0, which causes the switch > from the desktop When to the tty environment, the LED light > status is inconsistent with the keyboard lock status. > > Signed-off-by: lianzhi chang > --- > drivers/input/input.c | 46 ++++++++++++++++++++++++++++++++++++++- > drivers/tty/vt/keyboard.c | 19 ++++++++++++++-- > include/linux/input.h | 3 +++ > 3 files changed, 65 insertions(+), 3 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot