Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211015070122.11467-1-wanjiabing@vivo.com>
In-Reply-To: <20211015070122.11467-1-wanjiabing@vivo.com>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Fri, 15 Oct 2021 15:06:39 +0800
Message-ID: <CAAhV-H5Uu9REzepwN7BA+g3jgzy-gd263OZjGU2z+b+Eh57bhw@mail.gmail.com>
Subject: Re: [PATCH] MIPS: Loongson64: Add of_node_put() before break
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        "open list:MIPS" <linux-mips@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, kael_w@yeah.net
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Reviewed-by: Huacai Chen <chenhuacai@kernel.org>

On Fri, Oct 15, 2021 at 3:01 PM Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> Fix following coccicheck warning:
> ./arch/mips/loongson64/init.c:174:1-22: WARNING: Function
> for_each_node_by_name should have of_node_put() before break
>
> Early exits from for_each_node_by_name should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  arch/mips/loongson64/init.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/loongson64/init.c b/arch/mips/loongson64/init.c
> index 4ac5ba80bbf6..ee8de1735b7c 100644
> --- a/arch/mips/loongson64/init.c
> +++ b/arch/mips/loongson64/init.c
> @@ -179,6 +179,7 @@ static __init void reserve_pio_range(void)
>
>                 if (of_range_parser_init(&parser, np)) {
>                         pr_info("Failed to parse resources.\n");
> +                       of_node_put(np);
>                         break;
>                 }
>
> --
> 2.20.1
>