Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 15 Oct 2021 10:30:42 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Mwesigwa Guma <mguma@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        Nicolas Saenz Julienne <nsaenz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Ojaswin Mujoo <ojaswin98@gmail.com>,
        Amarjargal Gundjalam <amarjargal16@gmail.com>,
        Phil Elwell <phil@raspberrypi.com>,
        bcm-kernel-feedback-list@broadcom.com,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-staging@lists.linux.dev, fedora-rpi@googlegroups.com,
        Joel Savitz <jsavitz@redhat.com>,
        Chukpozohn Toe <ctoe@redhat.com>,
        Clark Williams <clark@redhat.com>
Subject: Re: [PATCH] staging: vchiq_arm: Add 36-bit address support
Message-ID: <20211015073042.GP8429@kadam>
References: <20211014223230.451659-1-mguma@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211014223230.451659-1-mguma@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vWNQeK/4gHBxTjXYgjDQhwVMYfgnt3yf+nEJ2GluQNTOu3fvRtsTiE9KwQ0m?=
 =?us-ascii?Q?Z7KxYgSkoeJqtsmNu5KVecXsXwIRT89bj97cAS2ZkHjCSD2O7r5l3rrr2BAj?=
 =?us-ascii?Q?fqSDguD5D9R5oz3rQkOiY5SNDK5WGdKEyiAk0RKetWRzpUinfeYn0/DAYmnv?=
 =?us-ascii?Q?tm+/KNQr85bpkBYVAODz2UuISMcndoDIYTlCGdGXNPMaa6cPPDGWeAj0A84p?=
 =?us-ascii?Q?0QZq2OvsFB0KPAHUYmG1Zu6POgsoXeTlhGW5UvV1LqotvPYpu8Maua99tL6C?=
 =?us-ascii?Q?e+W8Zoka/U/XioGv9di1+MiGqUg8GzdHD7mcoJqYEX3A0B8Fzzft+m/cTb3v?=
 =?us-ascii?Q?KtXoJbM96Q6DKIuXYyxiUCOzE++wNoephMlKe0FOIE+PXqNGKviAJ64qU8eC?=
 =?us-ascii?Q?rPStHgSc+JNnk9XsINRDWtNyHNmEGG3xM9eH41d69WjemXihlz/aNJpN9szb?=
 =?us-ascii?Q?CH8f6cNhtI191032v1NIxEb4YIkjVjIIkAmXz5MVv462lvtjrPdP00pIix7n?=
 =?us-ascii?Q?BiYwzvMvkTegJzLFXWLOUp0Ygmijnm5b8HsnDvEZQgLIZ7dFstAeJj4tngBl?=
 =?us-ascii?Q?EhioOu5BRM4WUAWdz7jz5UzCUiekK+8QPZREBMyZ0TaCHWEBDP3S6q1C4F2E?=
 =?us-ascii?Q?H0YU6d4AHmolU5l5OXl4uuFwxdtSqTYdfvNpgyXlPnmETnCIOvgzWa3u5Acv?=
 =?us-ascii?Q?dhdTtQiv3lzhzvYG3FDlJu+vtJNJwtIjQQkEOcNZi85KNOtPCuNnqQws/yX/?=
 =?us-ascii?Q?kdpdGACYz36sFZEt+e5R8+ogEqFqj9zxPf99565D9BUwBPeRw9xYUgtxYqbt?=
 =?us-ascii?Q?q96nicGy0ZEotL+4GvDBBO2fCph37WIClvY7M99R1yf6tvAqP8J7VrCIGifJ?=
 =?us-ascii?Q?5E/sZ/5iWBAV0ypbvhtnqxE84DX8ndUeNnwyDXexpuHVQYS3SpmBfexSVMdY?=
 =?us-ascii?Q?UadWmemQuOxxnl26KoLSH1M7n5rv1yuKNaXqLqsl4ZSyop6qjua/DZp0N0SH?=
 =?us-ascii?Q?R9F3Mu1rLWokWsb6MazvulqSCwVIFebONEOnbTvmHq5QQjhJekcCODIFwO9X?=
 =?us-ascii?Q?vB/XgumSh2FtgD4yFJ3pqWMfK47mdPahUJ3rFo5PuApPwmmLzeDMpk5wjS//?=
 =?us-ascii?Q?r0+Ood5EVRhs3OIy3WJp4WBecw1bbBILjKYu41xNNStk1Nofl9Il9LZG2T7J?=
 =?us-ascii?Q?v0Fh9egoz/2/aErCpngEmwKcOfHPXWTRZ+9qFSkVcZCEBez1If9btAlh5WRz?=
 =?us-ascii?Q?3yyiU8iWq9mlGzawl3b6+ksld8hAexLHzC/4DiSoaTMyPH8XG0Y8UeTdRHG3?=
 =?us-ascii?Q?AnsUP4Sg2PSi6l3d3m5D8CDP?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb058b69-6fd0-4630-42a8-08d98fadbd14
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 07:31:01.7669
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 85lbac2pQd2OmLC7aGTRwTJhEapoLbmTkxYJ7+uSVYadtt9MmFb5RV+T1RvMRpr9MJwDq5oug3ynHoF07CYyIauis38C5EGo63G5Othgn6k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1952
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10137 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110150046
X-Proofpoint-ORIG-GUID: kbXBY-94B5WwcXg2tqQk65d503-U-TfN
X-Proofpoint-GUID: kbXBY-94B5WwcXg2tqQk65d503-U-TfN
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 14, 2021 at 06:32:30PM -0400, Mwesigwa Guma wrote:
> Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Stefan Wahren <stefan.wahren@i2se.com>
> Cc: Ojaswin Mujoo <ojaswin98@gmail.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Amarjargal Gundjalam <amarjargal16@gmail.com>
> Cc: Phil Elwell <phil@raspberrypi.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: linux-rpi-kernel@lists.infradead.org 
> Cc: linux-arm-kernel@lists.infradead.org 
> Cc: linux-staging@lists.linux.dev 
> Cc: fedora-rpi@googlegroups.com
> Cc: Joel Savitz <jsavitz@redhat.com>
> Cc: Chukpozohn Toe <ctoe@redhat.com>
> Cc: Clark Williams <clark@redhat.com>
> 

Did you intend to put this CC list here?  It goes at the end next to
the Signed-off-by line if so.  I don't feel like it's required except
maybe Phil to show he was Cc'd.

> This is a forward port of Phil Elwell's commit from the Raspberry Pi
> Linux fork described as follows [1]:

Please use the From: header to give authorship credit.

From: Phil Elwell <phil@raspberrypi.com>

Make that the first line of the email.

> 
>     Conditional on a new compatible string, change the pagelist encoding
>     such that the top 24 bits are the pfn, leaving 8 bits for run length
>     (-1), giving a 36-bit address range.
>     
>     Manage the split between addresses for the VPU and addresses for the
>     40-bit DMA controller with a dedicated DMA device pointer that on non-
>     BCM2711 platforms is the same as the main VCHIQ device. This allows
>     the VCHIQ node to stay in the usual place in the DT.
> 
> This commit enables VCHIQ device access on a Raspberry Pi 4B running the 
> mainline Linux kernel.
> 
> Tested on Fedora Linux running on a Raspberry Pi 4B.
> 
> [1]: https://github.com/raspberrypi/linux/commit/97268fd23eb8d08dc74eac5e3fd697303de26610
> 
> Signed-off-by: Mwesigwa Guma <mguma@redhat.com>

regards,
dan carpenter