Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Leon Romanovsky <leon@kernel.org>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] net: ethernet: ti: Add of_node_put() before return
Date:   Fri, 15 Oct 2021 03:30:57 -0400
Message-Id: <20211015073107.13046-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iNEXfipzYb0oh7c72ytFmM1HNJiHZ/2TGOQp29eDkmcm6dBqp3r9HrWL2h/1?=
 =?us-ascii?Q?I3eJJWeBGZFRiOIFVnJ2nCiuHPHORqoS5gkvmXwK6qfkuWoX97kA1kFd0tbu?=
 =?us-ascii?Q?MmAvsRIWXuoplp54hxGPd0FUwXLcNKUWhWWsyHWkxmXvFZBBkFEOXAAbroEv?=
 =?us-ascii?Q?dkC208cvVo2jT30YJ7uRzQ6c7/ADirNd+A7KvNl36Ejo/UBjGoNCujxtesm6?=
 =?us-ascii?Q?3E1SWw2uuHubN9KL1ztFdGOAF/N0zfGZ6CAzgiWs9BVGI8bT6jut5VhyKiWk?=
 =?us-ascii?Q?RMDqdDqEGyDtYsJU+Qvl90tN0Mux/1ljxXkVvM0rXw7Dt/sjmOSW/FDMSblg?=
 =?us-ascii?Q?ETLEKzp0IIUlvvxd1U1RwfCwnO58cyz1mHEJjBlp6Wi49bJwf6tq26w6Ng85?=
 =?us-ascii?Q?q6QFW9PwJ9jli2VzURSi5YrL4Y0nkSHJmNG4tP6C8KlXia4eNMaCw3CNaPKd?=
 =?us-ascii?Q?OImYO4ZuGYIVhqMXawieG4dn83qvPhBIGPqdNI0Y8EUf4ouLnmVjohB/zAje?=
 =?us-ascii?Q?yvQImr7C4jwpQPb+1ugqweOsp6znVd/p0tOpu2kZ1KBwAi8t2n3ADS2jmtxK?=
 =?us-ascii?Q?fdERu6k8aNf5C0jtVM9wHEpqO01B+HnfmPNxcJcFMoCh0v8kru2O0LOnXDDa?=
 =?us-ascii?Q?uIk5KXAIEARDcXLRrqMH14NUFLINjiQeBEL+G5I7SpmvV82s1Vm/qr6H0gnn?=
 =?us-ascii?Q?zsSyTQyIj9Jb3xjz8YR4ueK2a8icUmLN4iYiZCqEBpcenQ6Qj3LCQxMenT19?=
 =?us-ascii?Q?Isdl8aM6xnlXjVR+nbxHgcOEHvyZqCIWKe87aRPcRFhu8WYiZMGpWG8I+LjP?=
 =?us-ascii?Q?PC0+1x+OMAeW8i+10C9IgoIi+jRj77ZOpqZ/+EVX3IYYix6rREpuI+62wQ7m?=
 =?us-ascii?Q?ug3zuNtKJDhLNNmhAtr7nbdikO16STthYkT33zb/aMk5yQ4YDp8OwTf4svmG?=
 =?us-ascii?Q?CLo82CQhE8PYc/yW28MfdFYaCz1AJwFTfGT6I+UboV5RKDoZtqM67Wo5ZGbV?=
 =?us-ascii?Q?6yaWXl7yHzgBV/3ZCJer7L+n2PsJeijv7pognuJyOjixvid3wdwnYewvl0If?=
 =?us-ascii?Q?36SB/JkIqSl/jNsbu4FGR5nSKq1TZlyd/bRfTzHnoYvLMJwym+BO3JqYYrrq?=
 =?us-ascii?Q?3mkP0rgX38ke7y/mRght+Cweyhodz4CapiZrKdGo5c/Rvg5l8eosqM4IXB4d?=
 =?us-ascii?Q?fR44kxjcpKOZWhLxKfQnjg/7pSzsJV5IJKoiGSIbQxnXh3J06LBe8H+bgq3r?=
 =?us-ascii?Q?1Q9yunkno+TjUZl83dDzFUkgNcVT1AQTNL8/vMQLas8qaMtFR52iz5MDq26v?=
 =?us-ascii?Q?d3Shrz4kkhRbcE0pgleW7NoZ?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9820adb9-76e7-49e2-50b1-08d98fadd5b8
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 07:31:43.1144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ei7h+ltTnN27gpKcnyEJAU+m1h7pOb7YqbMxp0wCKzCSCt/9gpnTvzNWoNQirh7tnXxyHs/W62dIj78A5Gvimw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3578
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/net/ethernet/ti/am65-cpsw-nuss.c:1835:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index 6904bfaa5777..00ef27cdde84 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -1844,12 +1844,14 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 		if (ret < 0) {
 			dev_err(dev, "%pOF error reading port_id %d\n",
 				port_np, ret);
+			of_node_put(port_np);
 			return ret;
 		}
 
 		if (!port_id || port_id > common->port_num) {
 			dev_err(dev, "%pOF has invalid port_id %u %s\n",
 				port_np, port_id, port_np->name);
+			of_node_put(port_np);
 			return -EINVAL;
 		}
 
@@ -1866,8 +1868,10 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 				(AM65_CPSW_NU_FRAM_PORT_OFFSET * (port_id - 1));
 
 		port->slave.mac_sl = cpsw_sl_get("am65", dev, port->port_base);
-		if (IS_ERR(port->slave.mac_sl))
+		if (IS_ERR(port->slave.mac_sl)) {
+			of_node_put(port_np);
 			return PTR_ERR(port->slave.mac_sl);
+		}
 
 		port->disabled = !of_device_is_available(port_np);
 		if (port->disabled) {
@@ -1880,6 +1884,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 			ret = PTR_ERR(port->slave.ifphy);
 			dev_err(dev, "%pOF error retrieving port phy: %d\n",
 				port_np, ret);
+			of_node_put(port_np);
 			return ret;
 		}
 
@@ -1889,10 +1894,12 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 		/* get phy/link info */
 		if (of_phy_is_fixed_link(port_np)) {
 			ret = of_phy_register_fixed_link(port_np);
-			if (ret)
+			if (ret) {
+				of_node_put(port_np);
 				return dev_err_probe(dev, ret,
 						     "failed to register fixed-link phy %pOF\n",
 						     port_np);
+			}
 			port->slave.phy_node = of_node_get(port_np);
 		} else {
 			port->slave.phy_node =
@@ -1902,6 +1909,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 		if (!port->slave.phy_node) {
 			dev_err(dev,
 				"slave[%d] no phy found\n", port_id);
+			of_node_put(port_np);
 			return -ENODEV;
 		}
 
@@ -1909,6 +1917,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 		if (ret) {
 			dev_err(dev, "%pOF read phy-mode err %d\n",
 				port_np, ret);
+			of_node_put(port_np);
 			return ret;
 		}
 
-- 
2.20.1