Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp347544pxb; Fri, 15 Oct 2021 06:45:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtPtlO/94RA3e6lsMlZHERVAXcl9x33yxlCbutaKZACFgzCpWCYdqIh+6IKrnoMOVInuUZ X-Received: by 2002:a50:cf87:: with SMTP id h7mr17868457edk.330.1634305523178; Fri, 15 Oct 2021 06:45:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634305523; cv=none; d=google.com; s=arc-20160816; b=o/oZW/DY69duwybOhE2LoqS96+NZBWRBKBnb2npIE6mJ0iKKf2HyyOJpcY+guf2x4x UvYVpBnIdDJ+lmzAu4D9Gpuo7zMI1aziZXCaFPBXsDBi7FaMS9pVnKznrhA1mWOgkpoM qdyBaWc+8s6PCx5fNfOl0CuIdFQ5xIFv84suwugph9kvsxUnS4sH6o+uEi+oZzO4XOE8 S8eiRkQrljxY+AYCwNzAGoPqWWOEpJiC1qJFNlLlPis/nqSEmf1GUayz9Yhur2GF61MI KOAkWv9zvkAhu3zB+Svo8I6aggS1TZTbKm4cIdF37wRbAUlvepKr+5xlARh0Y4ctBSU/ 3Skw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dmarc-filter:sender:dkim-signature; bh=kAntNQHuXNNYiMl1eS0qX1uZ1jRQgpLgR9OVNPkS2Hg=; b=XBoEK7U6ZFB+mRq13wfu4No2DzenbCVhi4JYxDnJWiQ1hANNqyrBlWABCpdSqteuuk a5ZN8YqFMPj4PCZwTp9gYPqBeo01YhgUrtPZ5geTPm5UIAcP/N1NonV0Q8WVS9FTanI+ XOIuvLZ4tDzGIhjXf6IaxNrgA39N2U4cwV68xVBQN0BT+bpW6QoV8c9EQEL2YETc5J/c h4BD71iQrHWknb7cR9mBcg2G+wI5O17bnbqJlGd84hm7DCZ3HjxD5nZcdZiA+ZO1JsGF dxMfrlIcQntD37QLSYJP8WqFdxV7TpenVEbAJsWzjw/krh9ZYlsNNn9I0a+E53C5lpdU rh+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=FQeyN0Y9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg22si10688255ejc.776.2021.10.15.06.44.36; Fri, 15 Oct 2021 06:45:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=FQeyN0Y9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236185AbhJOHiA (ORCPT + 99 others); Fri, 15 Oct 2021 03:38:00 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:62902 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236168AbhJOHh7 (ORCPT ); Fri, 15 Oct 2021 03:37:59 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1634283353; h=References: In-Reply-To: Message-Id: Date: Subject: Cc: To: From: Sender; bh=kAntNQHuXNNYiMl1eS0qX1uZ1jRQgpLgR9OVNPkS2Hg=; b=FQeyN0Y90CpoTjn76jrPtVrwJWSHSMo97gLvia4GIalfqQtGXN4P7jcIjxZPXRyAeVCtM09z KlJJygGiBrQnOib6h4P5LYMUJnonTl2KalqRP0UQ8SQACkiJBEYOrjiFl/i8qVpKaH4Fz+Cx oBSSi7kHFww2fUz+rmVJlon9Dj8= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 61692f3ef3e5b80f1f7c498c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 15 Oct 2021 07:35:26 GMT Sender: luoj=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 19780C4338F; Fri, 15 Oct 2021 07:35:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from akronite-sh-dev02.qualcomm.com (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: luoj) by smtp.codeaurora.org (Postfix) with ESMTPSA id D9D5BC43616; Fri, 15 Oct 2021 07:35:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org D9D5BC43616 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Luo Jie To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org, Luo Jie Subject: [PATCH v2 02/13] net: phy: at803x: use phy_modify() Date: Fri, 15 Oct 2021 15:34:54 +0800 Message-Id: <20211015073505.1893-3-luoj@codeaurora.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211015073505.1893-1-luoj@codeaurora.org> References: <20211015073505.1893-1-luoj@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Convert at803x_set_wol to use phy_modify. Signed-off-by: Luo Jie --- drivers/net/phy/at803x.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 5843b5b742f8..c5e145ff5ec8 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -348,16 +348,12 @@ static int at803x_set_wol(struct phy_device *phydev, phy_write_mmd(phydev, MDIO_MMD_PCS, offsets[i], mac[(i * 2) + 1] | (mac[(i * 2)] << 8)); - value = phy_read(phydev, AT803X_INTR_ENABLE); - value |= AT803X_INTR_ENABLE_WOL; - ret = phy_write(phydev, AT803X_INTR_ENABLE, value); + ret = phy_modify(phydev, AT803X_INTR_ENABLE, 0, AT803X_INTR_ENABLE_WOL); if (ret) return ret; value = phy_read(phydev, AT803X_INTR_STATUS); } else { - value = phy_read(phydev, AT803X_INTR_ENABLE); - value &= (~AT803X_INTR_ENABLE_WOL); - ret = phy_write(phydev, AT803X_INTR_ENABLE, value); + ret = phy_modify(phydev, AT803X_INTR_ENABLE, AT803X_INTR_ENABLE_WOL, 0); if (ret) return ret; value = phy_read(phydev, AT803X_INTR_STATUS); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project