Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] net: phy: Add of_node_put() before return
Date:   Fri, 15 Oct 2021 03:49:49 -0400
Message-Id: <20211015074949.14589-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w0XYmD8DGKwJKoLF9xKX41FqP/7I9dF6wrna0Ir5ChZJj2BkiM1n7mtFQny3?=
 =?us-ascii?Q?lB/e6ZkuDwA8GsQQhrwAP53xylRaS0YmjeBByCkefO2o+oGNJ1sSwaDA/l2O?=
 =?us-ascii?Q?EgU4H5vQk9wEAZlIgmTmBPVxLkOKTGSQ6XJx8rUvqo7yzBgKm+0X04H+JHU3?=
 =?us-ascii?Q?EOEZfNuaU+WJCiYtNWN5Ip5bgOfJ0BLSSQ4HMq+Xi6yroEupUB4yLdsOQAkp?=
 =?us-ascii?Q?De1i2DY/qI6j6g9o5Eqzm4NPu443nOabVh8ZEug1bXISerrMz6jKMBDsEVZl?=
 =?us-ascii?Q?7+05l/6U3zTch/fsQ7Axk8OwazItXILOT0Vf07ZGwOjkIR8zFUw/FktP8nn6?=
 =?us-ascii?Q?xCzJFNwIVtJldb82bajCZf4AZ+9EUeLfKRDYnJxSO3g0z+Ihx0GmY3kGUdmY?=
 =?us-ascii?Q?mzKGkXMSPauePD4wtGWcZT1ph/V87JZdF9+5s2BTTjXyaaTVtC3O8yL3digq?=
 =?us-ascii?Q?5eV2j4q6o2LoduptaUziHptlbTggAJ+5AbztRBY/shlnVOAaDeecpizvbiRQ?=
 =?us-ascii?Q?Z31QkPisS9k1xJ7qVQ2VMW4xHpDKRS2oFFkZjYkgY44fEFrC6vw+4RkPmgRn?=
 =?us-ascii?Q?3FOUzm6MGZg8YM0OACh1b1YMIMFkYD6xZY6OdEQDz20oxDBQgrKc9NATYgti?=
 =?us-ascii?Q?xrIscybJk6bbZylIUfHuQBqI8mezq8bfoPVJ9YOmCvzaCfOFlFqvUGfINSco?=
 =?us-ascii?Q?Qzfiw1aEKOdjnRmK4+HBU+fNVJmXrnRBFJNE9KY2ogEiypDV5Wj3Ci5k/eZf?=
 =?us-ascii?Q?Gol8D58crwdw4NOFKiO9pgC0OO6z2gxXxREZN1cW6kb1dHapEuAF0ZW7p3D0?=
 =?us-ascii?Q?s22y2MXe0IF5eZVxYpfnM+Bgh6KhqBbX0KAknb1yvcz7R2aqYfN7Dpek2P1g?=
 =?us-ascii?Q?+5QyOec1wmShSnzSUS9gb4hnDeCuQ5U64lmwJEGbHECgRyiholkceXJ8KnhA?=
 =?us-ascii?Q?7SVc+orwo/R4X/oYMs8Qn3bEV9D7bIHvtRTHHiFV6mYouxG4j4Lflkkmff8i?=
 =?us-ascii?Q?qzKQtyMUXnv5iuM3mH4VWmmhiWrpsdyS87I5KezE3dUXiBjiBSiwhP8adGJZ?=
 =?us-ascii?Q?9g7Larl6C5B3Cstt0MlFq7fI5CNV4Tnha/j/Pa9cIaKJRaLaZZNx2QHzNxff?=
 =?us-ascii?Q?YCoznfycRSUsfy+OtgZ4pW+qm34i508KL2em72BymJGUTgt0sRvNg2cfZv3G?=
 =?us-ascii?Q?sgSL+bMXKR+xkWqOPKGEGTjX8vFVJFPoyyCoXR8FtJk7o2FiTYYWd2ZKAWvy?=
 =?us-ascii?Q?LY7dtA/+v3RQ8aQLX5F3WEPK20TnIRll3QaPFfrE0Wq6nlAUi9ETM/z3Srxv?=
 =?us-ascii?Q?aiuy5UsnyzaPNzYKJNyklhpf?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d6fc678-c0ea-46f0-ee30-08d98fb0666b
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 07:50:04.8139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XZKptHd4EZuYp8wris8v8pD6w7OBxqalp7bx4+sLVunfh7c3IeneZZ12BI5GprGITkZwnzbjjyXjD6i9o6FlOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3822
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/net/phy/mdio_bus.c:454:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/net/phy/mdio_bus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index c204067f1890..d19ee8a69e6c 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -460,6 +460,7 @@ static void of_mdiobus_link_mdiodev(struct mii_bus *bus,
 
 		if (addr == mdiodev->addr) {
 			device_set_node(dev, of_fwnode_handle(child));
+			of_node_put(child);
 			return;
 		}
 	}
-- 
2.20.1