Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 15 Oct 2021 08:54:45 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Luo Jie <luoj@codeaurora.org>
Cc:     andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH v2 05/13] net: phy: add qca8081 ethernet phy driver
Message-ID: <YWkzxd7xzTDngoT9@shell.armlinux.org.uk>
References: <20211015073505.1893-1-luoj@codeaurora.org>
 <20211015073505.1893-6-luoj@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211015073505.1893-6-luoj@codeaurora.org>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Fri, Oct 15, 2021 at 03:34:57PM +0800, Luo Jie wrote:
> @@ -1431,6 +1433,18 @@ static struct phy_driver at803x_driver[] = {
>  	.get_sset_count = at803x_get_sset_count,
>  	.get_strings = at803x_get_strings,
>  	.get_stats = at803x_get_stats,
> +}, {
> +	/* Qualcomm QCA8081 */
> +	PHY_ID_MATCH_EXACT(QCA8081_PHY_ID),
> +	.name			= "Qualcomm QCA8081 PHY",

I don't think we need the " PHY" suffix. This name gets printed in a
context where it's obvious it's a network PHY.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!